Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Sept. 25, 2015, 3:12 a.m., Milian Wolff wrote: > > src/codecs/doctermscodec.cpp, line 73 > > > > > > this and the below cases look fine to me - anything else sounds super > > dangerous and could leak to subt

Re: Review Request 125362: Avoid QByteArray::fromRawData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85910 --- src/codecs/doctermscodec.cpp (line 63)

Re: DBus service for screenshots.

On Thursday 24 September 2015 23:54:59 Emmanuele Bassi wrote: > > The service we've implemented is called org.freedesktop.Screenshot > > (we're using the freedesktop namespace because we truly want the > > service to be DE or platform agnostic). > > Commendable spirit, but that's not how it works

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125369/#review85905 --- runners/baloo/baloosearchrunner.cpp (line 165)

Re: Review Request 125365: Do not ignore subterms if not found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/ --- (Updated Sept. 24, 2015, 11:45 p.m.) Status -- This change has been

Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125374: TagListJob: Emit error when failed to open database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125374/#review85903 --- Ship it! - Vishesh Handa On Sept. 24, 2015, 2:32 p.m., Davi

Re: Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85902 --- Ship it! src/qml/experimental/monitor.cpp (line 127)

DBus service for screenshots.

Hi, In December we'll be releasing a new screenshot app for KDE. We've implemented a generic DBus interface for this app, and I'm posting this to the dbus mailing list as others may be interested in this idea and may want to implement it in their own desktop environments. The service we've implem

Re: Icons installed by apps

On 24 September 2015 at 22:54, Jaroslaw Staniek wrote: > Dear All, > One more question about the theme setting behaviour or philosophy. In > a Plasma4 session I am using a custom prefix for KF5 libs and > KF5-based apps. > > Then in $XDG_CONFIG_HOME/.config5/kdeglobals editing setting > > [Icons]

Re: Icons installed by apps

On Tuesday 22 September 2015 18:44:47 Jaroslaw Staniek wrote: > On 22 September 2015 at 14:17, Jaroslaw Staniek wrote: > > Hello, > > A couple of related questions while wrestling with issues such as [1]. > > > > Let's assume Kexi app installs some icons to > > PREFIX/share/kexi/icons/oxygen/32x32

Re: Icons installed by apps

Dear All, One more question about the theme setting behaviour or philosophy. In a Plasma4 session I am using a custom prefix for KF5 libs and KF5-based apps. Then in $XDG_CONFIG_HOME/.config5/kdeglobals editing setting [Icons] Theme= does not seem to mean anything to these apps. Also having

Re: Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- (Updated Sept. 24, 2015, 4:52 p.m.) Review request for Baloo and Vishesh

Re: Icons installed by apps

On 24 September 2015 at 10:40, Harald Sitter wrote: > On Wed, Sep 23, 2015 at 11:27 PM, Jaroslaw Staniek wrote: Thirdly, I suppose it's possible to indicate in the code that I am looking for a "place" icon group for example. That would slash the number of lookups and also limit con

Review Request 125374: TagListJob: Emit error when failed to open database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125374/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Review Request 125374: TagListJob: Emit error when failed to open database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125374/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Icons installed by apps

On Wed, Sep 23, 2015 at 11:27 PM, Jaroslaw Staniek wrote: >>> Thirdly, I suppose it's possible to indicate in the code that I am >>> looking for a "place" icon group for example. That would slash the >>> number of lookups and also limit conflicts. Maybe that would be a >>> violation of behaviour r

Re: Review Request 125365: Do not ignore subterms if not found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/#review85859 --- Ship it! Ship It! - Pinak Ahuja On Sept. 23, 2015, 6:43 p.

Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125369/ --- Review request for Baloo and Plasma. Repository: plasma-workspace Descr

Re: Review Request 125359: Remove baloo-monitor from baloo

> On Sept. 23, 2015, 2:20 p.m., Hrvoje Senjan wrote: > > src/tools/CMakeLists.txt, line 4 > > > > > > Please mention in the changelog that users that will upgrade to KF5 > > 5.15 will lose the app. I don't think

Re: Review Request 125359: Remove baloo-monitor from baloo

> On Sept. 23, 2015, 2:08 p.m., Vishesh Handa wrote: > > Maybe you could split this into one patch where you remove the monitor and > > one in which you introduce the experimental qml monitor.h? > > > > Feel free to ship the one where you remove it. We've introduced the experimental monitor al

Re: Review Request 125351: Don't ignore AND subterm if there is no results

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/ --- (Updated Сен. 24, 2015, 7:05 д.п.) Status -- This change has been di

Re: Review Request 125365: Do not ignore subterms if not found

> On Сен. 24, 2015, 7:03 д.п., Igor Poboiko wrote: > > Ship It! I've tested it: no more confusing results, it works as expected. Going to close my review request (https://git.reviewboard.kde.org/r/125351/) - Igor --- This is an automat

Re: Review Request 125365: Do not ignore subterms if not found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/#review85854 --- Ship it! Ship It! - Igor Poboiko On Сен. 23, 2015, 6:43 п.