Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Сен. 23, 2015, 2:59 п.п., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, awe

Re: Icons installed by apps

On 23 September 2015 at 22:55, Albert Astals Cid wrote: > El Dimecres, 23 de setembre de 2015, a les 22:12:39, Jaroslaw Staniek va > escriure: >> On 23 September 2015 at 09:31, Harald Sitter wrote: >> >> You mean if {appname} and {appname}-foo doesn't right? >> >> >> >> the XDG icon spec has some

Re: Icons installed by apps

El Dimecres, 23 de setembre de 2015, a les 22:12:39, Jaroslaw Staniek va escriure: > On 23 September 2015 at 09:31, Harald Sitter wrote: > >> You mean if {appname} and {appname}-foo doesn't right? > >> > >> the XDG icon spec has some kind of inheritance built into the name so > >> > >> someacti

Re: Icons installed by apps

On 23 September 2015 at 22:12, Jaroslaw Staniek wrote: > My fresh test results in one observation, network-server-database-kexi > which causes the above 515 stat()'s > sits in share/icons/hicolor/22x22/places/network-server-database-kexi.svg. > It is not found, instead > share/icons/breeze/places/

Re: Icons installed by apps

On 23 September 2015 at 09:31, Harald Sitter wrote: >> >> You mean if {appname} and {appname}-foo doesn't right? >> >> the XDG icon spec has some kind of inheritance built into the name so >> >> someaction.png >> >> is chosen if you don't have >> >> someaction-veryspecific.png >> >> So you may wan

Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Sept. 23, 2015, 8:29 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125351: Don't ignore AND subterm if there is no results

> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote: > > Oh wow. This is bad. Thanks for diagnosing it. > > > > I'm wondering if this is the best way of solving it. The assumption always > > is that if a DB does not have any values then it can just return 0. If we > > change this assumption in

Review Request 125365: Do not ignore subterms if not found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/ --- Review request for Baloo, Pinak Ahuja and Igor Poboiko. Repository: baloo

Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, aw

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/ --- (Updated Sept. 23, 2015, 3:42 p.m.) Status -- This change has been m

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

> On Sept. 23, 2015, 6:30 p.m., Vishesh Handa wrote: > > You guys are awesome for diagnosing this and figuring out the issue. Nicely > > done! Debugging is fun :-D I've re-opened the issue to make the code cleaner. - Boudhayan --- Thi

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/ --- (Updated Sept. 23, 2015, 8:54 p.m.) Review request for Baloo, Pinak Ahuja

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/ --- (Updated Sept. 23, 2015, 3:20 p.m.) Status -- This change has been m

Re: Review Request 125362: Avoid QByteArray::fromRawData

> On Сен. 23, 2015, 2:59 п.п., Vishesh Handa wrote: > > Hmm. This is actually an optimization I care about. > > Do you think you could share your `~/.local/share/baloo/index` file. That > > way I will be able to reproduce it and see exactly where/why the data is > > changing? > > > > Btw, awe

Re: Review Request 125362: Avoid QByteArray::fromRawData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85830 --- Hmm. This is actually an optimization I care about. Do you th

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85829 --- Ship it! src/tools/balooctl/main.cpp (line 47)

Review Request 125362: Avoid QByteArray::fromRawData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/ --- Review request for Baloo. Repository: baloo Description --- I've n

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/ --- (Updated Sept. 23, 2015, 8 p.m.) Review request for Baloo, Pinak Ahuja an

Re: Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85827 --- src/tools/CMakeLists.txt

Re: Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85824 --- Maybe you could split this into one patch where you remove the

Re: Review Request 125358: Improve i18n in Balooshow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125358/ --- (Updated Sept. 23, 2015, 2:07 p.m.) Status -- This change has been m

Re: Review Request 125358: Improve i18n in Balooshow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125358/#review85823 --- Ship it! - Vishesh Handa On Sept. 23, 2015, 1:11 p.m., Boud

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85822 --- src/tools/balooctl/main.cpp (line 114)

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85819 --- You may want to s/QLatin1String/QStringLiteral/ to reduce allo

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

> On Sept. 23, 2015, 7:11 p.m., Armin K. wrote: > > You may want to s/QLatin1String/QStringLiteral/ to reduce allocations. > > Otherwise, looks nice. The rest of balooctl uses QLatin1String, so let's stick with that for now. I'm also not sure whether QStringLiteral == QLatin1String, QStringLit

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

> On Sept. 23, 2015, 7:04 p.m., Pinak Ahuja wrote: > > Nice! :) I'm still not sure if default should be true. Can vHanda take a look? - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85817 --- Ship it! Nice! :) - Pinak Ahuja On Sept. 23, 2015, 1:31 p.

Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Review Request 125358: Improve i18n in Balooshow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125358/ --- (Updated Sept. 23, 2015, 6:41 p.m.) Review request for Baloo, Pinak Ahuja

Review Request 125359: Remove baloo-monitor from baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85815 --- You guys are awesome for diagnosing this and figuring out the

Re: Review Request 125358: Improve i18n in Balooshow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125358/#review85814 --- I'm wondering if we should actually translate all the public s

Review Request 125358: Improve i18n in Balooshow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125358/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Review Request 125355: Make balooshow fail gracefully if the index cannot be opened.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125355/ --- (Updated Sept. 23, 2015, 12:35 p.m.) Status -- This change has been

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85813 --- Ship it! Maybe we just want to remove all this logic. It used

Re: Review Request 125351: Don't ignore AND subterm if there is no results

> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote: > > Oh wow. This is bad. Thanks for diagnosing it. > > > > I'm wondering if this is the best way of solving it. The assumption always > > is that if a DB does not have any values then it can just return 0. If we > > change this assumption in

Re: Review Request 125351: Don't ignore AND subterm if there is no results

> On Sept. 22, 2015, 8:32 p.m., Albert Astals Cid wrote: > > Can this checked by an autotest? Definitely. Thanks for the reminder :) - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.o

Re: Review Request 125355: Make balooshow fail gracefully if the index cannot be opened.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125355/#review85810 --- Ship it! Nice work! - Vishesh Handa On Sept. 23, 2015, 9:3

Review Request 125355: Make balooshow fail gracefully if the index cannot be opened.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125355/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Icons installed by apps

Am 22.09.2015 10:32 nachm. schrieb "Albert Astals Cid" : > > El Dimarts, 22 de setembre de 2015, a les 14:17:28, Jaroslaw Staniek va > escriure: > > Hello, > > A couple of related questions while wrestling with issues such as [1]. > > > > Let's assume Kexi app installs some icons to > > PREFIX/shar

Re: Icons installed by apps

On Wed, Sep 23, 2015 at 12:17 AM, Albert Astals Cid wrote: > El Dimarts, 22 de setembre de 2015, a les 23:01:06, Jaroslaw Staniek va > escriure: >> On 22 September 2015 at 22:55, Matthias Klumpp > wrote: >> > Am 22.09.2015 10:32 nachm. schrieb "Albert Astals Cid" : >> >> El Dimarts, 22 de setembr