folder icons where should they be set

2015-09-10 Thread Harald Sitter
salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file har

Re: Moving KDE Connect out of playground

2015-09-10 Thread Aleix Pol
On Thu, Sep 10, 2015 at 2:20 PM, Luigi Toscano wrote: > On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: >> +kde-core-devel >> >> Hi, >> >> With the latest changes we are making to KDE Connect as part of the sprint >> in Randa, I think that the project is becoming mature enough to be m

Re: Moving KDE Connect out of playground

2015-09-10 Thread Jeremy Whiting
As Luigi suggested please follow the procedure and move to kdereview first. On Thu, Sep 10, 2015 at 11:44 AM, Filipe Saraiva wrote: > Em 10-09-2015 05:32, Albert Vaca escreveu: >> Hi, >> >> With the latest changes we are making to KDE Connect as part of the >> sprint in Randa, I think that the pr

Re: Moving KDE Connect out of playground

2015-09-10 Thread Filipe Saraiva
Em 10-09-2015 05:32, Albert Vaca escreveu: > Hi, > > With the latest changes we are making to KDE Connect as part of the > sprint in Randa, I think that the project is becoming mature enough to > be moved out of playground. Not only that, but Kubuntu and other > distros are already installing KDE C

Re: Moving KDE Connect out of playground

2015-09-10 Thread Luigi Toscano
On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved > out of playground. Not only that, but Kubuntu and othe

Re: Moving KDE Connect out of playground

2015-09-10 Thread Jeremy Whiting
+1 here too. On Thu, Sep 10, 2015 at 3:39 AM, Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only that, but Kubuntu and

Re: Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
+kde-core-devel Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it b

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/ --- (Updated Sept. 10, 2015, 9:37 a.m.) Status -- This change has been m

Re: Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
+kde-core-devel Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it b

Re: Moving KDE Connect out of playground

2015-09-10 Thread Harald Sitter
+1000 On Thu, Sep 10, 2015 at 10:32 AM, Albert Vaca wrote: > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only that, but Kubuntu and other distros are already

Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it being in playgroun

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/#review85089 --- Ship it! Looks good, thanks. Not sure which boilerplate code

Re: KF5 with qmake problems

2015-09-10 Thread David Faure
On Thursday 10 September 2015 07:57:11 Oswald Buddenhagen wrote: > On Sun, Sep 06, 2015 at 11:10:29AM +0200, David Faure wrote: > > This seems to be a bug in Qt. > > The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) > > turns "core gui KParts" into "core gui + all the deps from K

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- (Updated Sept. 10, 2015, 7:36 a.m.) Status -- This change has been m

Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/ --- Review request for Baloo, David Faure and Vishesh Handa. Repository: balo

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread David Faure
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi