Re: KF5 with qmake problems

2015-09-09 Thread Oswald Buddenhagen
On Sun, Sep 06, 2015 at 11:10:29AM +0200, David Faure wrote: > This seems to be a bug in Qt. > The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) > turns "core gui KParts" into "core gui + all the deps from KParts". But > KParts itself is missing. > > If I change > # Topolog

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes updateConfi

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 --- src/file/mainadaptor.cpp (line 45)

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- (Updated Sept. 10, 2015, 5:28 a.m.) Status -- This change has been m

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85076 --- Ship it! - Vishesh Handa On Sept. 9, 2015, 9:38 p.m., Pinak

Re: Review Request 124244: Implement logging in for baloo_file_extractor

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124244/ --- (Updated Sept. 9, 2015, 9:51 p.m.) Status -- This change has been di

Re: Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125124/ --- (Updated Sept. 9, 2015, 9:48 p.m.) Status -- This change has been ma

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-09-09 Thread David Faure
> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125124/#review85072 --- Ship it! Ship It! - Pinak Ahuja On Sept. 9, 2015, 8:46 p.m

Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- Review request for Baloo, David Faure and Vishesh Handa. Repository: balo

Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

2015-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125124/ --- Review request for Baloo. Repository: baloo Description --- Instal

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, lines 174-177 > > > > > > This can also stay like it was, just do > > > > return excluded.toSet() == mountPoints.toSet(); > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:53 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Martin Klapetek
> On Sept. 9, 2015, 8:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, lines 174-177 > > > > > > This can also stay like it was, just do > > > > return excluded.toSet() == mountPoints.toSet(); > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, line 167 > > > > > > const QStorageInfo &si > > Ovidiu-Florin BOGDAN wrote: > If I do that I get this: > > > /home/ovid

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:47 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- (Updated Sept. 9, 2015, 9:45 p.m.) Review request for Baloo, Plasma and V

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, line 167 > > > > > > const QStorageInfo &si If I do that I get this: /home/ovidiu/kde-devel/src/kde/workspace/plasma-desktop/kcms/ba

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/#review85057 --- kcms/baloo/kcm.cpp (line 165)

Review Request 125117: Moved check for all mount points excluded out of widget class

2015-09-09 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125117/ --- Review request for Baloo, Plasma and Vishesh Handa. Repository: plasma-de

Re: Review Request 125107: Renamed functions and variables for better Qt compliance and better description

2015-09-09 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125107/ --- (Updated Sept. 9, 2015, 5:07 p.m.) Status -- This change has been ma

Krusader release

2015-09-09 Thread Ovidiu-Florin BOGDAN
Hello, I'm a KDE developer, and at work me and my coleagues use Krusader. I see that the last release was 2 years ago (even though it was a beta), but since then there have been a multitude of commits. What heppened? Why hasn't there been a release for so long? I saw in the commit log that you