Re: Review Request 124805: Generate xml interface file using qt5_generate_dbus_interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124805/ --- (Updated Aug. 18, 2015, 7:40 p.m.) Status -- This change has been ma

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 7:32 p.m.) Review request for Baloo, Bhushan Shah

Re: Review Request 124794: Create one Database instance per process

> On Aug. 18, 2015, 6:46 p.m., Vishesh Handa wrote: > > src/tools/balooctl/main.cpp, line 127 > > > > > > We just put the extra '/' over here. ah, my stupidity! - Ashish -

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review84014 --- src/tools/balooctl/main.cpp (line 125)

Re: Review Request 124805: Generate xml interface file using qt5_generate_dbus_interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124805/#review84013 --- Ship it! Nice, I was thinking of doing this but never got aro

Re: Review Request 124794: Create one Database instance per process

> On Aug. 18, 2015, 6:26 p.m., Vishesh Handa wrote: > > src/tools/balooctl/main.cpp, line 125 > > > > > > I think you can use the `fileIndexDbPath` function over here? Actually it ends with one extra "/" as it's

Re: Review Request 124794: Create one Database instance per process

> On Aug. 17, 2015, 7:50 p.m., Vishesh Handa wrote: > > autotests/unit/lib/filefetchjobtest.cpp, line 92 > > > > > > What is this used for? > > Ashish Bansal wrote: > I have removed autotests/unit/lib/db.cpp

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- (Updated Aug. 18, 2015, 6:30 p.m.) Status -- This change has been ma

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review84011 --- autotests/unit/lib/CMakeLists.txt (line 24)

Review Request 124805: Generate xml interface file using qt5_generate_dbus_interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124805/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/#review84009 --- Ship it! - Vishesh Handa On Aug. 18, 2015, 1:07 p.m., Armin

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 6:08 p.m.) Review request for Baloo, Bhushan Shah

Re: Review Request 124794: Create one Database instance per process

> On Aug. 17, 2015, 7:50 p.m., Vishesh Handa wrote: > > autotests/unit/lib/filefetchjobtest.cpp, line 92 > > > > > > What is this used for? I have removed autotests/unit/lib/db.cpp which contained these functions

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124790/ --- (Updated Aug. 18, 2015, 1:07 p.m.) Review request for Baloo. Repository

Re: Review Request 124794: Create one Database instance per process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 12:59 p.m.) Review request for Baloo, Bhushan Sha