Re: Review Request 124719: Add baloo monitor to baloo's qml plugin

2015-08-16 Thread Pinak Ahuja
> On Aug. 13, 2015, 9:03 p.m., Vishesh Handa wrote: > > I rather not make the monitor API public, if we make it public we have > > about 2 weeks to make sure we like it, and then we're stuck with it > > forever. Though maybe these API restrictions do not apply to QML based > > APIs. Maybe we c

Re: KScreenGenie 2.0.0 Release Announcement

2015-08-16 Thread Boudhayan Gupta
Hi, On 16 August 2015 at 16:47, David Edmundson wrote: > Edit: on re-read that comes across as harsh, what I meant was I was just > curious if this was discussed somewhere as I would have wanted to add some > comments. > Heh, that's fine :-) As for discussions, Martin Graesslin originally sug

Re: KScreenGenie 2.0.0 Release Announcement

2015-08-16 Thread David Edmundson
On Sun, Aug 16, 2015 at 11:23 AM, David Edmundson < da...@davidedmundson.co.uk> wrote: > > >> It is further recommended (although it is not required) that >> KScreenGenie be set as the default screenshot tool, > > > Recommended by whom? > > Edit: on re-read that comes across as harsh, what I meant

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- (Updated Aug. 16, 2015, 11:12 a.m.) Status -- This change has been m

KScreenGenie 2.0.0 Release Announcement

2015-08-16 Thread Boudhayan Gupta
On 16 August 2015 at 15:53, David Edmundson wrote: > > >> It is further recommended (although it is not required) that >> KScreenGenie be set as the default screenshot tool, > > > Recommended by whom? > > By me. I'm under the impression that as an independent releaser, I'm allowed to make this re

Re: KScreenGenie 2.0.0 Release Announcement

2015-08-16 Thread David Edmundson
> It is further recommended (although it is not required) that > KScreenGenie be set as the default screenshot tool, Recommended by whom? >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/#review83861 --- Ship it! Nice. You'll probably have to start refactoring the

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- (Updated Aug. 16, 2015, 8 a.m.) Review request for Baloo and Vishesh Hand

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
> On Aug. 13, 2015, 9:27 p.m., Vishesh Handa wrote: > > src/file/extractorprocess.cpp, line 71 > > > > > > Could you please check if this is internally spawning an event loop? We > > want to avoid that. > > Pina