Re: Review Request 124162: Only export urls when monitor is running

2015-06-25 Thread Pinak Ahuja
> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124162: Only export urls when monitor is running

2015-06-25 Thread Stefan Brüns
> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la

Re: Review Request 124153: Use interface generated from org.kde.baloo.file.indexer.xml in monitor

2015-06-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124153/ --- (Updated June 25, 2015, 11:37 a.m.) Review request for Baloo and Vishesh

Re: Review Request 124162: Only export urls when monitor is running

2015-06-25 Thread Pinak Ahuja
> On June 24, 2015, 10:54 p.m., Stefan Brüns wrote: > > Some comments about the DBus interface you are exporting: > > I think you should make the current file name a property. Signal changes > > through the standard PropertiesChanged DBus signal. This way you can also > > add more properties la