Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81562 --- This is starting to look quite good. src/file/extractor/main

Re: Review Request 124124: Add a basic Monitor with a QML UI

2015-06-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124124/#review81560 --- Ship it! - Vishesh Handa On June 18, 2015, 4:12 p.m., Pinak

Re: Review Request 124124: Add a basic Monitor with a QML UI

2015-06-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124124/#review81559 --- Seems interesting. I'm guessing this is the same code as your

Re: Review Request 124124: Add a basic Monitor with a QML UI

2015-06-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124124/ --- (Updated June 18, 2015, 4:12 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 124124: Add a basic Monitor with a QML UI

2015-06-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124124/ --- (Updated June 18, 2015, 4:09 p.m.) Review request for Baloo and Vishesh H

Review Request 124124: Add a basic Monitor with a QML UI

2015-06-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124124/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Notes to developers: what KAboutData::setApplicationData() is

2015-06-18 Thread Jaroslaw Staniek
On 18 June 2015 at 14:50, Jeremy Whiting wrote: > Jaroslaw, > > On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek wrote: >> Hi >> If you look at apps ported to KF5, KAboutData::setApplicationData() is >> used but there are also redundant lines in main(), at least these: >> >> app.setApplicationNa

Re: Notes to developers: what KAboutData::setApplicationData() is

2015-06-18 Thread Thomas Lübking
On Donnerstag, 18. Juni 2015 14:50:45 CEST, Jeremy Whiting wrote: Jaroslaw, On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek wrote: Hi If you look at apps ported to KF5, KAboutData::setApplicationData() is used but there are also redundant lines in main(), at least these: app.setApplicationN

Re: Notes to developers: what KAboutData::setApplicationData() is

2015-06-18 Thread Jeremy Whiting
Jaroslaw, On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek wrote: > Hi > If you look at apps ported to KF5, KAboutData::setApplicationData() is > used but there are also redundant lines in main(), at least these: > > app.setApplicationName(aboutData.componentName()); > app.setApplicationDisplayN

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Pinak Ahuja
> On June 18, 2015, 1:03 a.m., Vishesh Handa wrote: > > I'm not quite comfortable with this code. It makes the FileContentIndexer > > class way messier, but I haven't thought enough on how to improve it. Now filecontentindexer just returns average time per batch which is required all the time

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- (Updated June 18, 2015, 12:46 p.m.) Review request for Baloo and Vishesh

Re: kde-apps/kcm-fcitx Exit unnormally

2015-06-18 Thread Thomas Lübking
already reported as https://github.com/fcitx/kcm-fcitx/issues/9 You should add a backtrace there (DrKonqui "developer information" tab) Cheers, Thomas On Donnerstag, 18. Juni 2015 11:24:15 CEST, Wallance Lee wrote: Hi,Everyone. I am new to here.I have a question.I am a Chinese user,and I use

Re: Notes to developers: what KAboutData::setApplicationData() is

2015-06-18 Thread Jaroslaw Staniek
(I am sorry, forgot to include kde-devel too) On 18 June 2015 at 11:20, Jaroslaw Staniek wrote: > Hi > If you look at apps ported to KF5, KAboutData::setApplicationData() is > used but there are also redundant lines in main(), at least these: > > app.setApplicationName(aboutData.componentName());

Re:kde-apps/kcm-fcitx Exit unnormally

2015-06-18 Thread Wallance Lee
Sorry,the exact version of kcm-fcitx is 0.5.0 At 2015-06-18 17:24:15, "Wallance Lee" wrote: Hi,Everyone. I am new to here.I have a question.I am a Chinese user,and I use Fcitx as my Chinese input method.Whenever I use kde-frontend to configure my fcitx and try to deselect "Only show current la

kde-apps/kcm-fcitx Exit unnormally

2015-06-18 Thread Wallance Lee
Hi,Everyone. I am new to here.I have a question.I am a Chinese user,and I use Fcitx as my Chinese input method.Whenever I use kde-frontend to configure my fcitx and try to deselect "Only show current language", the kcm-fcitx exited unnormally. And the following are my computer information: Gentoo