KDE Frameworks 5.11.0 released

2015-06-12 Thread David Faure
12th June 2015. KDE today announces the release of KDE Frameworks 5.11.0. KDE Frameworks are 60 addon libraries to Qt which provide a wide variety of· commonly needed functionality in mature, peer reviewed and well tested· libraries with friendly licensing terms. For an introduction see the· Frame

Re: Review Request 124080: Export file being processed by extractor

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124080/ --- (Updated June 12, 2015, 7:18 p.m.) Status -- This change has been ma

Re: Review Request 124085: FileMetaDataProvider: Check if indexing disabled before calling IndexedDataRetriever

2015-06-12 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124085/ --- (Updated June 12, 2015, 7:15 p.m.) Status -- This change has been ma

Re: Review Request 124080: Export file being processed by extractor

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124080/#review81424 --- Ship it! Okay. Ship it. I'm not totally comfortable with thi

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124081/ --- (Updated June 12, 2015, 6:56 p.m.) Status -- This change has been di

Re: Review Request 124080: Export file being processed by extractor

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124080/ --- (Updated June 12, 2015, 6:55 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
> On June 12, 2015, 3:41 p.m., Vishesh Handa wrote: > > src/tools/balooctl/monitor.cpp, line 40 > > > > > > Is this required? > > Pinak Ahuja wrote: > In my opinion, makes the output look better otherwise we

Re: Review Request 124085: FileMetaDataProvider: Check if indexing disabled before calling IndexedDataRetriever

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124085/#review81422 --- Ship it! It's strange that the patch was lost in the KF5 port

Review Request 124085: FileMetaDataProvider: Check if indexing disabled before calling IndexedDataRetriever

2015-06-12 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124085/ --- Review request for Baloo and Vishesh Handa. Bugs: 332065 http://bugs.

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Vishesh Handa
> On June 12, 2015, 3:45 p.m., Vishesh Handa wrote: > > I'm fine with this simple approach as a starting point, but I'm not sure if > > FileContentIndexer is the correct place. I am not quite sure how you're > > planning to hook this up with the monitor. > > > > Also has this been tested? > >

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Vishesh Handa
> On June 12, 2015, 3:41 p.m., Vishesh Handa wrote: > > src/tools/balooctl/monitor.cpp, line 40 > > > > > > Is this required? > > Pinak Ahuja wrote: > In my opinion, makes the output look better otherwise we

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
> On June 12, 2015, 3:41 p.m., Vishesh Handa wrote: > > src/tools/balooctl/CMakeLists.txt, line 3 > > > > > > Could you please split each file into a separate line? The monitor will also have No. of files indexed/

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
> On June 12, 2015, 3:41 p.m., Vishesh Handa wrote: > > src/tools/balooctl/monitor.cpp, line 40 > > > > > > Is this required? In my opinion, makes the output look better otherwise we end up with a huge growing l

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Pinak Ahuja
> On June 12, 2015, 3:45 p.m., Vishesh Handa wrote: > > I'm fine with this simple approach as a starting point, but I'm not sure if > > FileContentIndexer is the correct place. I am not quite sure how you're > > planning to hook this up with the monitor. > > > > Also has this been tested? * T

Re: Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81412 --- I'm fine with this simple approach as a starting point, but I'

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124081/#review81410 --- This is good start for the monitor. What other information did

Re: Review Request 124080: Export file being processed by extractor

2015-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124080/#review81409 --- src/file/extractor/app.cpp (line 76)

Review Request 124082: Estimate time remaining for FileContentIndexer

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124081/ --- (Updated June 12, 2015, 12:31 p.m.) Review request for Baloo and Vishesh

Review Request 124081: add balooctl monitor option

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124081/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Review Request 124080: Export file being processed by extractor

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124080/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 124075: Export file being indexed by FileContentIndexer

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124075/ --- (Updated June 12, 2015, 12:17 p.m.) Status -- This change has been d

Re: Review Request 124063: Add docSize(id) to transaction

2015-06-12 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124063/ --- (Updated June 12, 2015, 12:18 p.m.) Status -- This change has been d