Re: Guidance Required

2015-06-02 Thread Bhushan Shah
Hello! On Wed, Jun 3, 2015 at 1:37 AM, Karan Thakkar wrote: > > I am interested and excited to contribute to KDE, basically for Plasma > Media Centre. I have gone around through development guide of KDE for the > same. > Thanks for your interest in the Plasma Media Center. > I have basic C++

Guidance Required

2015-06-02 Thread Karan Thakkar
Hello all, I am interested and excited to contribute to KDE, basically for Plasma Media Centre. I have gone around through development guide of KDE for the same. I have basic C++ knowledge and have been indulged in competitive coding for a while. I would appreciate if you guide me about the thing

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/ --- (Updated June 2, 2015, 12:05 p.m.) Status -- This change has been ma

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Pinak Ahuja
> On June 2, 2015, 11:25 a.m., Vishesh Handa wrote: > > src/file/extractor/iohandler.h, line 49 > > > > > > You do not really need this variable. You could just decrease the > > `m_batchSize` each time. Yeah, th

Re: Review Request 123964: Re-introduce batch committing in baloo_file_extractor

2015-06-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123964/#review81072 --- Ship it! Good work. Next time. This should be 3 different pa