Re: Qt -fPIC building suggestion

2015-05-22 Thread Jeremy Whiting
Perfect, thanks. That patch does fix building phonon here also. On Fri, May 22, 2015 at 12:21 PM, Harald Sitter wrote: > On Fri, May 22, 2015 at 7:48 PM, Jeremy Whiting wrote: >> I also tried adding >> >> SET(CMAKE_POSITION_INDEPENDENT_CODE ON) >> >> to phonon's CMakeLists.txt, with the same res

Re: Qt -fPIC building suggestion

2015-05-22 Thread Harald Sitter
On Fri, May 22, 2015 at 7:48 PM, Jeremy Whiting wrote: > I also tried adding > > SET(CMAKE_POSITION_INDEPENDENT_CODE ON) > > to phonon's CMakeLists.txt, with the same result. that feature only sets PIE on actual executable targets and PIC on library targets. relevant RR: https://git.reviewboard.

Re: Qt -fPIC building suggestion

2015-05-22 Thread Jeremy Whiting
I also tried adding SET(CMAKE_POSITION_INDEPENDENT_CODE ON) to phonon's CMakeLists.txt, with the same result. On Fri, May 22, 2015 at 11:43 AM, Jeremy Whiting wrote: > Hey list, > > I just recently got a new gcc 5.1 package in arch stable, so I thought > I'd rebuild all of kde with it to see if

Qt -fPIC building suggestion

2015-05-22 Thread Jeremy Whiting
Hey list, I just recently got a new gcc 5.1 package in arch stable, so I thought I'd rebuild all of kde with it to see if I still get the kbuildsycoca5 crash (if arch's qt5 packages are still built with gcc 4.9). At any rate, I'm not able to build even kdesupport anymore. Once kdesrc-build gets to

Re: Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

2015-05-22 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123863/#review80728 --- Could you please also update balooshow/main.cpp to use this co