Review Request 123868: Avoid copying QByteArray

2015-05-20 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123868/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Weird linkage failure on OSX CI

2015-05-20 Thread Thiago Macieira
On Wednesday 20 May 2015 12:14:36 Daniel Vrátil wrote: > 00:28:09.901 Undefined symbols for architecture x86_64: > 00:28:09.902 "std::__1::basic_string, > std::__1::allocator >::c_str() const", referenced from: this is std::string::c_str(), which is inline in libc++: _LIBCPP_INLINE_VISIBILI

Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

2015-05-20 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123863/ --- Review request for Baloo. Repository: baloo Description --- Result

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Aleix Pol
On Wed, May 20, 2015 at 2:01 PM, Thomas Lübking wrote: > On Mittwoch, 20. Mai 2015 12:19:38 CEST, Daniel Vrátil wrote: > >> OK, if you think it's a bug, I'll post a RR to remove the behaviour. > > Afaiu it violates FRC 4648 which allows further RFCs (MIME) to weaken > restrictions, but itself forb

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Thomas Lübking
On Mittwoch, 20. Mai 2015 12:19:38 CEST, Daniel Vrátil wrote: OK, if you think it's a bug, I'll post a RR to remove the behaviour. Afaiu it violates FRC 4648 which allows further RFCs (MIME) to weaken restrictions, but itself forbids it: "Implementations MUST reject the encoded data if it con

Re: Is KF5::KCodecs::base64Encode now including a trailing newline?

2015-05-20 Thread Daniel Vrátil
On Tuesday, May 19, 2015 03:32:03 PM Albert Astals Cid wrote: > El Dimarts, 19 de maig de 2015, a les 11:17:09, Daniel Vrátil va escriure: > > On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote: > > > Hi, > > > > > > In the process of porting Tellico to KF5, one of my unit tests that > > >

Weird linkage failure on OSX CI

2015-05-20 Thread Daniel Vrátil
Hi, I'm trying to get kdepim to build on the OSX CI, but this one is beyond me. Hopefully someone more knowledgable of the OSX build system might help. The build is currently failing with following error: 00:28:09.901 Undefined symbols for architecture x86_64: 00:28:09.902 "std::__1::basic_st