Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/ --- (Updated May 10, 2015, 3:52 a.m.) Review request for Baloo. Changes ---

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/ --- (Updated May 10, 2015, 3:02 a.m.) Review request for Baloo. Changes ---

Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/ --- Review request for Baloo. Repository: baloo Description --- BasicI

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE/removed 'virtual'

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123695/ --- (Updated May 9, 2015, 5:48 p.m.) Status -- This change has been mark

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE/removed 'virtual'

2015-05-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123695/#review80134 --- Ship it! Awesome :) I'll push it into the repo for you. - Vi

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE/removed 'virtual'

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123695/ --- (Updated May 9, 2015, 3:54 p.m.) Review request for Baloo. Changes

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE

2015-05-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123695/#review80126 --- Do you think you could also remove the 'virtual' keyword? It's

Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE

2015-05-09 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123695/ --- Review request for Baloo. Repository: baloo Description --- Added

Confused shortcuts on Plasma5 with a non-standard primary keyboard layout variant

2015-05-09 Thread Wolfgang Mader
Hello list, I use KDE in the sense of the software-bundle. Abstract In KDE4 times, there was a QT bug messing up shortcuts when a non-standard (russian, neo, etc.) keyboard layout or variant was set as the default layout either via xorg.conf or in the System Setting of KDE4. This is d