Re: Review Request 120657: Dublic core conversion

2014-10-19 Thread Emmanuel Pescosta
> On Oct. 19, 2014, 3:33 p.m., Emmanuel Pescosta wrote: > > What are the possible benefits of this patch? > > > > You still have a lot of code duplication in both plugins, an additional > > dependency on Qt xml in KFileMetaData itself and (possible) slowdowns in > > both plugins (esp. in odf e

Re: Review Request 120657: Dublic core conversion

2014-10-19 Thread Thomas Lübking
> On Okt. 19, 2014, 1:33 nachm., Emmanuel Pescosta wrote: > > What are the possible benefits of this patch? > > > > You still have a lot of code duplication in both plugins, an additional > > dependency on Qt xml in KFileMetaData itself and (possible) slowdowns in > > both plugins (esp. in odf

Re: Review Request 120657: Dublic core conversion

2014-10-19 Thread Pinak Ahuja
> On Oct. 19, 2014, 1:33 p.m., Emmanuel Pescosta wrote: > > What are the possible benefits of this patch? > > > > You still have a lot of code duplication in both plugins, an additional > > dependency on Qt xml in KFileMetaData itself and (possible) slowdowns in > > both plugins (esp. in odf e

Re: Review Request 120657: Dublic core conversion

2014-10-19 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120657/#review68706 --- What are the possible benefits of this patch? You still have

Review Request 120657: Dublic core conversion

2014-10-19 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120657/ --- Review request for Baloo and Vishesh Handa. Repository: kfilemetadata D