Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/#review67881 --- Ship it! src/file/autotest/basicindexingjobtest.cpp

Re: How to detect KDE libraries with AutoConf

2014-10-03 Thread Jeremy Whiting
why do you need to build your application with kde knowledge if you aren't linking any kde libraries? If you are just executing kdialog --passivepopup from your application, just execute that, no need to build with library paths or anything like that. On the other hand if you want to know if kdial

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Pinak Ahuja
> On Oct. 3, 2014, 3:22 p.m., Vishesh Handa wrote: > > src/file/autotest/basicindexingjobtest.cpp, line 111 > > > > > > This part of the test wouldn't actually be checking anything since this > > temporary file

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/ --- (Updated Oct. 3, 2014, 5:16 p.m.) Review request for Baloo and Vishesh Ha

How to detect KDE libraries with AutoConf

2014-10-03 Thread Ahmed Ibrahim Khalil
Hello, I'm trying to integrate Profanity [1] XMPP client with KDE notifications. Profanity uses Autotools as its build systems. My question is, How could I detect if I am using KDE platform using Autoconf ? As I'm trying to use the "kdialog --passivepopup" command to display new messages notifi

Re: Review Request 120472: Don't exit the file metadata fetching loop when no file indexing information was found.

2014-10-03 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120472/ --- (Updated Oct. 3, 2014, 4:21 p.m.) Status -- This change has been mar

Re: Review Request 120466: Completed unit test for BasicIndexingJob

2014-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120466/#review67862 --- Nice work. You're almost there. src/file/autotest/basicindex

Re: Review Request 120472: Don't exit the file metadata fetching loop when no file indexing information was found.

2014-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120472/#review67861 --- Ship it! Looks good. - Vishesh Handa On Oct. 3, 2014, 12:5

KF5 full session

2014-10-03 Thread Luca
Hello everybody I'm trying to setup a full kde5 session on my debian sid machine. I have fully build from git thank to kdesrc-build script and the tutorial at https://community.kde.org/Frameworks/Building. Moreless everything has been build apart - kwayland: due to missing wayland dev library - k

Re: Review Request 120472: Don't exit the file metadata fetching loop when no file indexing information was found.

2014-10-03 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120472/ --- (Updated Oct. 3, 2014, 2:58 p.m.) Review request for Baloo. Changes ---

Review Request 120472: Don't exit the file metadata fetching loop when no file indexing information was found.

2014-10-03 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120472/ --- Review request for Baloo. Repository: baloo Description --- Don't