Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/ --- Review request for Baloo and Vishesh Handa. Repository: baloo-widgets D

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-07-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63469 --- bump! - Aleix Pol Gonzalez On Jan. 16, 2014, 7:30 p.m., Lau

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/ --- (Updated July 29, 2014, 12:36 p.m.) Status -- This change has been m

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated July 29, 2014, 12:26 p.m.) Status -- This change has been m

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-29 Thread Vishesh Handa
> On July 28, 2014, 4:38 p.m., Vishesh Handa wrote: > > Maybe we want to declare the FileMonitor in each test, but I don't have a > > strong opinion on it. I'm fine with the patch. Nice job! > > Felix Eisele wrote: > Thanks. I have no write access to git. Can I you please push for me? I >

Re: Review Request 119511: Removed KDialog from kcommentwidget

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63395 --- Ship it! Ship It! - Vishesh Handa On July 28, 2014, 6:17 p