Re: Review Request 119511: Removed KDialog from kcommentwidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated Juli 28, 2014, 8:17 nachm.) Review request for Baloo and Vishesh

Re: Review Request 119459: Added some Unittest for FileMonitor

> On Juli 28, 2014, 6:38 nachm., Vishesh Handa wrote: > > Maybe we want to declare the FileMonitor in each test, but I don't have a > > strong opinion on it. I'm fine with the patch. Nice job! Thanks. I have no write access to git. Can I you please push for me? I would to get a contributer acc

Re: Review Request 119511: Removed KDialog from kcommentwidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63341 --- Looks good! :D src/keditcommentdialog.h

Re: Review Request 119459: Added some Unittest for FileMonitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63339 --- Ship it! Maybe we want to declare the FileMonitor in each tes

Re: Review Request 119519: QueryParser: Use $ instead of % in the pattern strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119519/#review63331 --- Good catch! The patch looks good to me. I don't know if I can

Review Request 119519: QueryParser: Use $ instead of % in the pattern strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119519/ --- Review request for Baloo and Denis Steckelmacher. Repository: baloo Des

Re: Review Request 119511: Removed KDialog from kcommentwidget

> On Juli 28, 2014, 12:33 nachm., Kai Uwe Broulik wrote: > > No opinion on the patch but a few coding style issues, see below: Thank you for your reply. I'm very new in programming qt/kde. I saw we are very close neighbours. I live in waiblingen. > On Juli 28, 2014, 12:33 nachm., Kai Uwe Broul

Re: Review Request 119511: Removed KDialog from kcommentwidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- (Updated Juli 28, 2014, 2:27 nachm.) Review request for Baloo and Vishesh

Re: Review Request 119511: Removed KDialog from kcommentwidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63314 --- No opinion on the patch but a few coding style issues, see bel

Review Request 119511: Removed KDialog from kcommentwidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/ --- Review request for Baloo and Vishesh Handa. Repository: baloo-widgets D