Re: Review Request 116675: kdeexamples/plasma/c++/plasmoids/tooltips did not build

2014-07-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116675/ --- (Updated July 25, 2014, 2:04 a.m.) Status -- This change has been di

Re: Review Request 119450: Unittest style

2014-07-24 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119450/ --- (Updated Juli 24, 2014, 11:26 nachm.) Status -- This change has been

Re: Review Request 119450: Unittest style

2014-07-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119450/#review63063 --- Hi. Could you please follow the coding style over here - http

Re: Review Request 119450: Unittest style

2014-07-24 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119450/ --- (Updated Juli 24, 2014, 10:49 vorm.) Review request for Baloo and Vishesh

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-24 Thread Christian Mollekopf
> On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > I know this is not a review for me, but I was curious :-) This review is for everyone how cares, and I always appreciate your input =) > On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > src/pim/agent/collectionindexer.cpp, line 65 > >

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-24 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/#review63032 --- I know this is not a review for me, but I was curious :-) sr