Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

> On June 12, 2014, 6:05 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, if there's anything you're doubting I'd suggest you to > > take a look at another framework, such as KParts. If you guys are ok with the patch, can you please push it? I don't have commit access. - Bernd

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

> On June 17, 2014, 9:43 a.m., Vishesh Handa wrote: > > src/file/basicindexingjob.cpp, line 32 > > > > > > I'm a little surprised this works. Could you please add the explicit > > instead. This way it is obvious

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118752/#review60251 --- Ship it! Nice work. You'll have to wait for the other review

Re: Review Request 118438: Add an option to only build baloo's libraries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/#review60225 --- Ship it! Go ahead then :) - Vishesh Handa On May 31, 2014,