Re: Review Request 118231: Scheduler for the akonadi indexer.

2014-06-13 Thread Christian Mollekopf
> On June 13, 2014, 10:17 a.m., Thomas Braxton wrote: > > src/pim/agent/agent.h, line 80 > > > > > > Couldn't they just not be pointers? Then you don't have to worry about > > deleting them. hmmm... can't rememb

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-06-13 Thread Denis Steckelmacher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118448/ --- (Updated June 13, 2014, 11:02 a.m.) Review request for Baloo, Localizatio

Re: Review Request 118231: Scheduler for the akonadi indexer.

2014-06-13 Thread Thomas Braxton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59957 --- src/pim/agent/agent.h

Re: Review Request 118231: Scheduler for the akonadi indexer.

2014-06-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59951 --- some small nitpicks from my side - no clue about the actual fu

Re: Review Request 118231: Scheduler for the akonadi indexer.

2014-06-13 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118231/#review59935 --- ping? Are there still things that need to be addressed? - Chr