Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/#review59899 --- Ship it! Looks good to me, if there's anything you're doubtin

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Bernd Steinhauser
> On June 12, 2014, 5:25 p.m., Aleix Pol Gonzalez wrote: > > In practice, every KF5KFileMetaData should be KF5FileMetaData > > Bernd Steinhauser wrote: > What about the other uses of "KFileMetaData"? > > This definitely goes beyond changing the cmake files (to which I tried to > st

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Hrvoje Senjan
> On June 12, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote: > > In practice, every KF5KFileMetaData should be KF5FileMetaData > > Bernd Steinhauser wrote: > What about the other uses of "KFileMetaData"? > > This definitely goes beyond changing the cmake files (to which I tried to > st

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Bernd Steinhauser
> On June 12, 2014, 5:25 p.m., Aleix Pol Gonzalez wrote: > > In practice, every KF5KFileMetaData should be KF5FileMetaData What about the other uses of "KFileMetaData"? This definitely goes beyond changing the cmake files (to which I tried to stick at this point). What about the include direct

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/ --- (Updated June 12, 2014, 5:47 p.m.) Review request for Baloo, Aleix Pol Go

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/#review59890 --- In practice, every KF5KFileMetaData should be KF5FileMetaData

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/ --- (Updated June 12, 2014, 2:30 p.m.) Review request for Baloo, Aleix Pol Go

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/#review59884 --- Looks good to me otherwise. Let Aleix comment on this. src/e

Re: kded-statusnotifier question?

2014-06-12 Thread Sebastian Kügler
Hi Damian, On Thursday, June 12, 2014 11:23:46 Damian Ivanov wrote: > Hi all, > why does > getProperty("RegisteredStatusNotifierItems") > return the StatusNotifiers with the path appended? > see: qdbus org.kde.StatusNotifierWatcher /StatusNotifierWatcher > org.kde.StatusNotifierWatcher.RegisteredS

Fwd: StatusNotifier stand-alone implementation (help)

2014-06-12 Thread Damian Ivanov
I see it is the type of data not recognized by qml. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: kded-statusnotifier question?

2014-06-12 Thread Damian Ivanov
Is this a bug or a feature? I workaround it by appending .slice(0,-19) in qml to the element. 2014-06-12 11:23 GMT+03:00 Damian Ivanov : > Hi all, > why does > getProperty("RegisteredStatusNotifierItems") > return the StatusNotifiers with the path appended? > see: qdbus org.kde.StatusNotifierWatch

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118670/#review59853 --- Thanks for working on this. I've been missing being able to ru

kded-statusnotifier question?

2014-06-12 Thread Damian Ivanov
Hi all, why does getProperty("RegisteredStatusNotifierItems") return the StatusNotifiers with the path appended? see: qdbus org.kde.StatusNotifierWatcher /StatusNotifierWatcher org.kde.StatusNotifierWatcher.RegisteredStatusNotifierItems org.kde.StatusNotifierItem-xx-1/StatusNotifierItem org.kd