Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Luis Silva
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. > > Thomas Lübking wrote: > Aside this, the approach

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Christoph Feck
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. > > Thomas Lübking wrote: > Aside this, the approach

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Albert Astals Cid
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. > > Thomas Lübking wrote: > Aside this, the approach

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Thomas Lübking
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. > > Thomas Lübking wrote: > Aside this, the approach

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Luis Silva
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. > > Thomas Lübking wrote: > Aside this, the approach

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Luis Silva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114632/ --- (Updated Jan. 6, 2014, 5:47 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Thomas Lübking
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. > > Christoph Feck wrote: > Yes, because the compiler does not read comments. Aside this, the approach seems too naive? DOIs have a de

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Christoph Feck
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) > > Luis Silva wrote: > What do you mean? It all works fine here. Yes, because the compiler does not read comments. - Christoph --- This is an au

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Luis Silva
> On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: > > Hm, you broke the comment :) What do you mean? It all works fine here. - Luis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11