Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Albert Astals Cid
El Dimecres, 7 de novembre de 2012, a les 06:07:43, Vishesh Handa va escriure: > On Wed, Nov 7, 2012 at 6:00 AM, Albert Astals Cid wrote: > > El Dimecres, 7 de novembre de 2012, a les 05:51:45, Vishesh Handa va > > > > escriure: > > > On Wed, Nov 7, 2012 at 5:36 AM, Albert Astals Cid wrote: > >

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Vishesh Handa
On Wed, Nov 7, 2012 at 6:00 AM, Albert Astals Cid wrote: > El Dimecres, 7 de novembre de 2012, a les 05:51:45, Vishesh Handa va > escriure: > > On Wed, Nov 7, 2012 at 5:36 AM, Albert Astals Cid wrote: > > > El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va > > > > > > escri

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread David Edmundson
missed one: from the docs: KioSlave::listDir "The slave should emit ERR_CANNOT_ENTER_DIRECTORY if it doesn't exist" yours does not. So you can enter "tags://madeUpNonExistingTag" and it will show the root dir. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Albert Astals Cid
El Dimecres, 7 de novembre de 2012, a les 05:51:45, Vishesh Handa va escriure: > On Wed, Nov 7, 2012 at 5:36 AM, Albert Astals Cid wrote: > > El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va > > > > escriure: > > > El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread David Edmundson
Your .protocol file is missing "Description" parameter (I'm not entirely sure where actually shows it anymore, I seem to remember kinfocenter used to.. but it's part of the other protocol files, so it's something that could be legitimately brought back and shown) kio_tags.cpp: Incredibly minor p

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Vishesh Handa
On Wed, Nov 7, 2012 at 5:36 AM, Albert Astals Cid wrote: > El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va > escriure: > > El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh Handa va > escriure: > > > Ping? > > > > > > I'll be merging this on Thursday. I would appr

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Albert Astals Cid
El Dimarts, 6 de novembre de 2012, a les 18:30:27, Albert Astals Cid va escriure: > El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh Handa va escriure: > > Ping? > > > > I'll be merging this on Thursday. I would appreciate it if somone could > > review the code. > > I'll have a look l

Re: diff master and own branch for review

2012-11-06 Thread Reza Shah
Hi Ben, Thanks for the info, just tried this and seems working fine. Regards, Reza On Wed, Nov 7, 2012 at 3:57 AM, Ben Cooksley wrote: > > You will want to merge master into your branch, which should then > allow you to generate a diff of only the changes in your branch. > > > Regards, > Ben >

Re: diff master and own branch for review

2012-11-06 Thread Ben Cooksley
On Tue, Nov 6, 2012 at 12:40 PM, Reza Shah wrote: > Hi, Hi Reza, > > I have created my own branch for porting c++ plasmoid to qml one. > > I created diff for review board manually, just doing git diff > master..rshah/comicqml, > then remove unnecessary diff from other application using kwrite. >

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Albert Astals Cid
El Dimarts, 6 de novembre de 2012, a les 18:17:29, Vishesh Handa va escriure: > Ping? > > I'll be merging this on Thursday. I would appreciate it if somone could > review the code. I'll have a look later today (based on my 0 knowledge of nepomuk & friends). Cheers, Albert P.S: You sent the em

Re: Nepomuk Tags kioslave - Please Review

2012-11-06 Thread Vishesh Handa
Ping? I'll be merging this on Thursday. I would appreciate it if somone could review the code. On Wed, Oct 31, 2012 at 3:12 AM, Vishesh Handa wrote: > Hey everyone > > I recently wrote a 'tags' kio slave, which allows one to browse nepomuk > tags, and the files containing those tags. It is curr

Re: Query about how to contribute!!

2012-11-06 Thread Myriam Schweingruber
Hi Girish, On Tue, Nov 6, 2012 at 4:00 AM, Girish Baranda wrote: > Hello, > I am Girish Baranda from India. And my query was that how should I get > started to contribute to code. I know C, C++ and some knowledge of Qt > framework. As i am very new to open source i don't know much about i