cases, there is no reason for KUrl::protocol to
> exist.
>
> Less difference between Qt and KDE API for no lasting reason is a
> good
> thing.
Hi,
just out of curiosity: Why is Intel blocking this to get into Qt?
Greetings
Christoph
--
-- Christo
- Original Message -
> On Tuesday, 24 de January de 2012 19.26.01, Christoph Cullmann wrote:
> > Hi,
> >
> > just out of curiosity: Why is Intel blocking this to get into Qt?
>
> The Qt Contribution License Agreement has not been approved
> internally yet.
> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote:
> > Good from my POV (cmake stuff).
UI-wise looks also fine. Was there anything else we needed to do? If not, merge
to master. Thanks, you rock!
- Christoph
---
T
On Thursday 09 February 2012 01:44:07 Ben Cooksley wrote:
> On Fri, Nov 4, 2011 at 9:50 AM, Christoph Feck
wrote:
> > On Thursday 03 November 2011 13:14:31 Dag Andersen wrote:
> >> Torsdag 03 november 2011 10:32:43 skrev Christoph Feck:
> >> > On Thursday 03 Novem
paths correctly, the patch fails for cases 2) and 5). It
does not find the class name in the map, falls back to user property (what Qt
provides now since 4.8), and thus not handle our custom code.
- Christoph Feck
On Feb. 9, 2012, 11:28 p.m., Albert Astals Cid wrote
> On Feb. 10, 2012, 12:01 a.m., Christoph Feck wrote:
> > Thanks Albert for looking at it. Not sure if I understand everything
> > correctly, but what happens, when I have a subclass of Q/KComboBox, that
> > does not have its own user property?
> >
> > I am c
ted in KDE when I told him
that there is work in progress to replace the Windows Explorer shell.
But I already feared it would be a job needing many more years of
development, if it materializes at all.
Christoph Feck (kdepepo)
lor-manager" for what is already
available.
Christoph Feck (kdepepo)
KDE Quality Team
n? The compression is probably wanted. I have not
checked if Qt uses quality 0 or 100 for the fastest mode, but the default PNG
compression is utterly slow (as you noticed ;)
- Christoph Feck
On Feb. 23, 2012, 7:23 p.m., Mark Gaiser
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote:
> > kdeui/util/kimagecache.cpp, line 106
> > <http://git.reviewboard.kde.org/r/104052/diff/2/?file=50867#file50867line106>
> >
> > This fails to correctly handle palettized images.
> >
> >
/kconfigdialogmanager.cpp
<http://git.reviewboard.kde.org/r/103909/#comment8783>
if( x ) => if (x)
- Christoph Feck
On Feb. 21, 2012, 11:55 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mai
uld be "Remove Image" to be HIG compliant.
- Christoph Feck
On Feb. 23, 2012, 8:53 p.m., Ralf Jung wrote:
>
> ---
> This is an automatically generated e-mail
QPixmap, so I do
not think we should try to be smart here. There general rule is: Use QImage, if
you need to access individual pixels, use QPixmap everywhere else. This way we
can benefit from any optimizations that can only be applied to opaque datatypes
(which QImage isn't).
- Christoph
ttp://git.reviewboard.kde.org/r/104134/#comment8944>
const ModelIndex &index
- Christoph Feck
On March 1, 2012, 6:26 p.m., Daniele Elmo Domenichelli wrote:
>
> ---
> This is an automatically generated e-mail. To r
ttp://git.reviewboard.kde.org/r/104054/#comment9014>
These two lines should have the same identation.
New string => master
Thanks :)
- Christoph Feck
On March 7, 2012, 9:44 p.m., Ralf Jung wrote:
>
> ---
> This is an automatically ge
esting. Crash reporting does not work right now, so there is nothing that
could break.
If possible, this should also be committed to 4.7 branch later, and
distributions informed for an eventual online update.
- Christoph Feck
On March 9, 2012, 12:45 a.m., George Kiagiadakis
y, either
> move kxmlrpcclient to kdelibs or make kde-runtime depend on kdepimlibs.
There were compatibility fixes in bugs.kde.org, so do we still need this? I
guess using xmlrpc is the more correct way to do it, so we don't break it again
later, but maybe this can be postponed to 4.9+
ing this in a way that is
> only a little related to bugzilla and get free from the thinking
> imposed by bugzilla.
Bugzilla has a long tradition of being a tool that annoys users,
developers, as well as bug triagers. Anything that improves the
situation is welcomed :)
Christoph Feck (kdepepo)
KDE Quality Team
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104261/#review11447
---
Could you please add group "Plasma" to reviewers?
-
s makes me believe there should
be a helper function, even if inline, that does all the option setup?
- Christoph Feck
On March 18, 2012, 1:44 a.m., Daniele Elmo Domenichelli wrote:
>
> ---
> This is an automatically generated e-ma
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104322/#review11973
---
Ship it!
Ship It!
- Christoph Feck
On March 28, 2012, 8:32
(see surrounding
code).
x=y; => x = y;
x+3 => x + 3
etc.
- Christoph Feck
On April 4, 2012, 5:10 a.m., Anant Kamath wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboar
On Saturday 30 October 2010 19:56:36 Camila Ayres wrote:
> *What project is in need of some love and dedication?*
Check https://bugs.kde.org/weekly-bug-summary.cgi
(In other words, helping hands are needed everywhere...)
Christoph Feck (kdepepo)
ot; when it is
> toggled. This is clearly wrong.
Exactly. Left-over from the days where KToggleAction did not force a check
box.
David Faure is the maintainer of XMLGUI stuff and actually was in favor of
those API changes, so wait for his decision.
Christoph Feck (kdepepo)
ck box, either checked or unchecked. If the difference isn't
clear enough using Oxygen style, I am sure Hugo can improve it.
Christoph Feck (kdepepo)
your mind *and* actually
> made this whole public experiment. It's certainly an advancement to know
> what's not an advancement. :-)
>
> Have a nice day,
> Hans
Agreed. I wish a few more developers would be that honest with their
"mistakes" instead of being
/hig-book/stable/menus-types.html.en
[2]
http://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html
Christoph Feck (kdepepo)
On Wednesday 10 November 2010 00:29:32 Thiago Macieira wrote:
> So I have to ask again: do we allow or support multiple logins of the same
> user, on the same machine (same $HOME)?
With the current mess^Wstate of Multi Screen support we need to. At least I
need.
Christoph Feck (kdepepo)
rd member is not initialized? The code
looks good :)
Christoph Feck (kdepepo)
On Wednesday 17 November 2010 21:29:54 Christoph Feck wrote:
> On Wednesday 17 November 2010 20:59:13 Jaime wrote:
> > Conditional jump or move depends on uninitialised value(s)
> >
> > at 0x5362167: KLed::setLook(KLed::Look) (kled.cpp:225)
> > by 0x40
n the QImage to render
the filmstrip holes at different sizes?
- Christoph
On 2010-11-22 20:16:46, Andreas Scherf wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboa
Hi,
kdereview contains two new modules, but I did not see the announcement here.
libkmap probably needs a changed/clarified name, I suggest kmap -> kgeomap. I
first thought it was some replacement for QMap ;) Not sure about kface.
Christoph Feck (kdepepo)
rip.h file. The upstream
project has to use it, because it doesn't have a way to paint on a QImage. But
if you want to work on it later, please commit this for now, too small holes
don't look nice on HD video files :)
- Christoph
On 2010-11-22 20:16:46, Andre
ize [2]
3) find out how the setting is/was passed to kapplymousetheme
4) add an option to the UI to allow changing the size
Fredrik Höglund wrote the Xcursor theme support, so he is probably the right
person to ask if you got stuck. Patches go to reviewboard, please :P
Christoph Feck (kdep
that I am very happy to see that you are improving
Konqueror. Be assured that there are still users who did not ditch it
yet ;) Thanks!
Christoph Feck (kdepepo)
KDE Quality Team
It can be tested using an adapted version of the plasmoid menubar:
> https://code.launchpad.net/~megabigbug/plasma-widget-menubar/appmen
> u-kde
Christoph Feck (kdepepo)
KDE Quality Team
e spin-up behavior,
because that seems to be caused by Solid's icon determination code, according
to comments in mentioned bug reports.
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kd
is anyway "deprecated"
in favour
of the V8 based new variant?
But does the new engine provide the same nice features to easily wrap your
objects and expose a custom API?
That was the major reason we switched over from KJS to QtScript.
Greetings
Christoph
--
-
/kdelibs/kio/kio/tcpslavebase.cpp: In member function 'int
KIO::TCPSlaveBase::connectToHost(const QString&, quint16, QString*)':
/local/git/KDE/libs/kdelibs/kio/kio/tcpslavebase.cpp:460:1: error: control
reaches end of non-void function [-Werror=return-type]
- Christoph Feck
On May
ts own and I doubt we would have the same quality if arbitrary
users
just write up their knowledge.
I think an additional standardized point of contact in the wiki would be great,
just like hitting "Help..." hit "Support Base..." or what ever and get there
the community info
eems like the "The
> > > one that does the work decides" is being ingored.
> >
> > This is not in any way dissing the work of those that put in much
> > effort but -
> >
> > If the current system is so good, can someo
egisters, and you cannot get them in the
backtrace.
>
> In gdb itslef, there are addons that already provide some pretty
> printing through KDevelop:
> https://projects.kde.org/projects/extragear/kdevelop/kdevelop/repos
> itory/revisions/master/show/debuggers/gdb/printers (file kde4.py)
> Maybe this can be reused?
>
> Thanks,
> Dominik
Christoph Feck (kdepepo)
KDE Quality Team
e the structure
directly in the hash?
- Christoph Feck
On July 5, 2012, 12:23 p.m., Dan Vratil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
ttp://git.reviewboard.kde.org/r/105451/#comment12061>
Actually, I wonder how that would have worked before. If the date was not
in hash, it would have inserted and returned a null pointer.
Probably a Qt 3 porting relict, looks better now.
- Christoph Feck
On July 5, 2012, 6:07 p.m., Dan Vratil
> On July 5, 2012, 7:53 p.m., Christoph Feck wrote:
> >
... to 4.9 branch, not master.
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105451/#re
ttp://git.reviewboard.kde.org/r/105531/#comment12240>
Do not set fixed spacing, let the style figure it out.
- Christoph Feck
On July 12, 2012, 10:18 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail.
it works, so I did not test it.
Thanks,
Christoph Feck
Diff: http://git.reviewboard.kde.org/r/105620/diff/
Testing
---
I tested with the steps from the bug report.
Thanks,
Christoph Feck
KDE, we should make
sure they still act integrated.
- Christoph Feck
On July 20, 2012, 1:41 p.m., Allen Winter wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
cters removed from the
template file, and again it creates "Test.doc" when trying to create a file
"Test".
Note that I did not enter "Test.txt", but only "Test".
So unless this issue is fixed (nobody wants to see a file called "NEWS.doc",
but only &q
> On Aug. 7, 2012, 11 a.m., Christoph Feck wrote:
> > I tried again on today's master with the two characters removed from the
> > template file, and again it creates "Test.doc" when trying to create a file
> > "Test".
> >
> > Note tha
- [supported by GCC since] 4.3
>
> I too would be interested in variadic templates, would this be
> acceptable in
> a tier 2 KF component (i18n)?
Then there is no longer Windows support.
MSVC (even the upcoming one) doesn't support that.
Greetings
Christoph
--
-
/show_bug.cgi?id=305350
Diffs
-
kcontrol/colors/colorscm.cpp 465a90c
Diff: http://git.reviewboard.kde.org/r/106066/diff/
Testing
---
Thanks,
Christoph Feck
continously
getting crash reports for KTorrent. I tried contacting kdnssd maintainer, but
got no answer.
- Christoph Feck
On July 19, 2012, 1:55 a.m., Christoph Feck wrote:
>
> ---
> This is an automatically generated e-mail.
coming days.
> and please review the code :D which is right now at
> https://projects.kde.org/projects/playground/base/print-manager
> but a sysadmin request to move has already been filled
Sorry, cannot read sysadmin bugs. Where do you want it to move?
Christoph Feck (kdepepo)
KDE Quality Team
On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote:
> 2012/8/23 Christoph Feck :
> > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote:
> >> two years ago I started print-manager, at that time
> >> I was using Debian which is affected by this bug
ing them out to unmaintained.
Replacing a Python-based code with (debuggable) C++ code is worth the
change alone. You do not want to see the Python backtraces we get...
(and yes, Daniel already asked Jonathan :)
Christoph Feck (kdepepo)
On Sunday 26 August 2012 06:34:30 Daniel Nicoletti wrote:
> 2012/8/25 Christoph Feck :
> > On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote:
> >> 2012/8/23 Christoph Feck :
> >> > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote:
>
On Monday 27 August 2012 22:15:18 Daniel Nicoletti wrote:
> 2012/8/27 Christoph Feck :
> > I am talking about whatever design mistake is responsible for bug
> > 242648, which isn't about CUPS at all. Sorry for side-tracking
> > this thread. I was just thinking that
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106290/#review18338
---
Ship it!
Ship It!
- Christoph Feck
On Aug. 31, 2012, 4:31
bp.cpp
<http://git.reviewboard.kde.org/r/106300/#comment14515>
Same here, should handle pure RGB case.
kimgio/webp.cpp
<http://git.reviewboard.kde.org/r/106300/#comment14516>
"header.size() == 12 && ..."
Otherwise, it would return true for the file
> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote:
> > kimgio/webp.cpp, line 49
> > <http://git.reviewboard.kde.org/r/106300/diff/1/?file=82610#file82610line49>
> >
> > Needs to check image.isValid() before writing data via scanLine()
> > pointers.
the data stored in the file
unmodified, and if an application works faster with premultiplied data
(e.g. in case it composes using QPainter), it can opt to convert to
premultiplied alpha.
Christoph Feck (kdepepo)
On Wednesday 05 September 2012 20:10:53 Alexander Neundorf wrote:
> In KDE3 it was possible to set the wallpaper via dcop in kdesktop.
> So we can't do this anymore ?
It's still being worked on, see bug 217950 and linked review request.
3cb16
kdeui/fonts/kfontcombobox.cpp 0ded6fb
Diff: http://git.reviewboard.kde.org/r/106425/diff/
Testing
---
Thanks,
Christoph Feck
http://bugs.kde.org/show_bug.cgi?id=306625
Diffs
-
kdeui/fonts/kfontcombobox.h de3cb16
kdeui/fonts/kfontcombobox.cpp 0ded6fb
Diff: http://git.reviewboard.kde.org/r/106425/diff/
Testing
---
Thanks,
Christoph Feck
On Sunday 16 September 2012 19:16:27 Thomas Lübking wrote:
> Because any access to the plasma theme cache takes considerable
> time here, i just took a short look.
>
> 1. all plasma theme caches are 82324 kB and mostly consist of
> paddings (actually the default one seems to consist of nothing
> e
something along the
line that you can choose which pages to restore.
- Christoph Feck
On Sept. 19, 2012, 9:15 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboa
." in Konqueror, the file
dialog starts at "Custom Path" (and lists root folder), without remembering the
previously used path.
- Christoph Feck
On Sept. 17, 2012, 10:39 a.m., Alex Fiestas wrote:
>
> ---
> This is an autom
tch end up being cherry-picked
> into 4.9 branch ??!?! It is only supposed to be in master for 4.10 release.
See bug 260282 comment #3.
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewbo
about
KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to the
spawned process.
- Christoph Feck
On Oct. 24, 2012, 5:56 p.m., Dominik Haumann wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote:
> > Are you sure it fixes bug 165355 ? That bug tracks the issue about
> > KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to
> > the spawned process.
To clarify: I don't object to have this
Solid, but a patch there should be of
similar complexity as this one, and I would rather wait for it instead of
cluttering kfile with a workaround. If the Solid fix, however, is not expected
before 4.10, then "Ship it!"
- Christoph Feck
On Oct. 24, 2012, 9:13 p.m., Dan Vr
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107030/#review20831
---
Ship it!
On a second look, I see no cluttering.
- Christoph
> On Oct. 4, 2012, 4:28 p.m., Christoph Feck wrote:
> > Causes a regression. When using "Save Image As..." in Konqueror, the file
> > dialog starts at "Custom Path" (and lists root folder), without remembering
> > the previously used path.
>
>
On Thursday 01 November 2012 12:05:51 David Faure wrote:
> as soon as we branch out other modules for 4.10, we'll reopen
> master, it will be less confusing to everyone.
Good grief :P
On Thursday 01 November 2012 22:19:03 Lamarque V. Souza wrote:
> Em Thursday 01 November 2012, Ben Cooksley escreveu:
> > Hi everyone,
>
> Hi,
>
> > The following projects which are in KDE Review appear to have
> > been there for more than 2 weeks:
> > - appmenu kded module (kded-appmenu)
>
Hi,
my git foo is limited, but if I interpret http://ompldr.org/vZzZxaw
correctly, then somehow master got merged into KDE/4.9 branch,
meaning, for example, that Alex's commits to depend on cmake 2.8.8 are
now in KDE/4.9 branch.
I suggest to not to commit to kdelibs, until this is resolved.
--hard" in the 4.9 branch,
to get rid of an initial commit I made in that branch. So HEAD doesn't
refer to the remote head in the current branch, but always to the head
of master?
Christoph Feck (kdepepo)
php
You could then also request an entry in the bug tracker, so that bugs
can be easily reassigned to KDE components, in case they are "not your
bugs".
PS: Be prepared to handle 1000+ votes on "Add POP3 support" request ;)
Christoph Feck (kdepepo)
KDE Quality Team
Mark Gaiser wrote:
> I regret to ask if you could do it...
> I'm getting some merge conflicts where i don't quite know what the
> intention is.. (deleted files, but modified in head.. and some other merge
> conflicts).
What does the code do, if the QTime wraps ar
... is there a
> > better way of determining if a language is CJK?
"CJK" is actually naming the languages which use CJK, so the list is hardcoded
by definition.
- Christoph
---
This is an automatically generated e-mail. To repl
-devel irc channel,
or on an KDE developers mailing list. The diff needs to be uploaded differently.
- Christoph Feck
On Jan. 17, 2013, 6:07 p.m., Julien Borderie wrote:
>
> ---
> This is an automatically generated e-mail. To rep
nalitza" is used as a library name,
visible to developers only. As such, I see no reason to change it.
Christoph Feck (kdepepo)
KDE Quality Team
, the bug won't help at all ;)
Greetings
Christoph
- Ursprüngliche Mail -
> Hi folks,
>
> at FOSDEM I was approached by a person who asked me to relay his
> dissatisfaction with the requirement of having a KDE Bugzilla account
> to
> report crashes via the KDE crash
ean, I have nothing against allowing people to login with their Google
account or whatever
if that is possible, but I would not like to see bug reports by
.
Greetings
Christoph
--
-- Christoph Cullmann -
AbsInt Angewandte Informatik GmbH Email
On a common setup this should result in a 22px icon - the same you use
> now (for the configured toolbar size)
Regarding 22 vs. 24, the geometric mean of 16 and 32 is 22.63, which got
rounded down to 22 to get even sized icons. For the newer (larger) icon sizes,
a simple "multiple of
; modules in
> question? (And if so, I'd appreciate ideas for better ways to fix).
Hi,
I would have no problem with moving kate.git around, splitting is IMHO
a pain for later developing on it, as all parts are tightly coupled anyway.
Greetings
Christoph
--
----
itable is anyway problematic,
guess users will have to live with "less safe" saving in such settings.
Will KSaveFile get some of that patches, too?
Greetings
Christoph
--
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH Email: c
There
> are a few exceptions (qbF\FdHCy, U2WVF9kLH) that still score worse
> with the new algorithm. One of them has no digit, the other no
> special, so I am not surprised as there are very few transitions
> between character classes in them.
>
> So, yes, you are absolutely right. Suggestions about how to improve
> that absolutely welcome.
>
> Eike
Christoph Feck (kdepepo)
KDE Quality Team
Dolphin behavior,
so I am not sure we should replicate it in kdelibs.
- Christoph Feck
On April 13, 2013, 3:12 p.m., Eike Hein wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboa
> On April 13, 2013, 5 p.m., Christoph Feck wrote:
> > Regarding the icon tinting, there are bugs filed against this Dolphin
> > behavior, so I am not sure we should replicate it in kdelibs.
bug 304643, bug 309722 to be more specific :
instead of 0x18000
codes.
- Christoph Feck
On April 16, 2013, 2:59 p.m., Róbert Szókovács wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
++ skills, could you
try creating the objects on the stack instead, so they are automatically
deleted once out of scope?
- Christoph Feck
On April 16, 2013, 9:31 p.m., Dario Cambié wrote:
>
> ---
> This is an automatically generated e
out this change?
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106300/#review32734
---
On May 18, 2013, 12:44 p.m., Mart
> On May 18, 2013, 12:44 p.m., Commit Hook wrote:
> > This review has been submitted with commit
> > df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch master.
>
> Christoph Feck wrote:
> Just noticed this has been committed to kolourpaint instead o
, though.
- Christoph Feck
On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
report. Using Dolphin I could
rename, delete, and "Open With" Okteta the file.
- Christoph Feck
On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote:
>
> ---
> This is an automatically generated e-mail. To r
org/buglist.cgi?query_format=advanced&long_desc_type=substring&long_desc=gdk_x_error&bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=NEEDSINFO&bug_severity=crash&list_id=697588
Christoph Feck (kdepepo)
KDE Quality Team
kfile/kfileplacesitem.cpp 5a12486
Diff: http://git.reviewboard.kde.org/r/111626/diff/
Testing
---
I could not test, my system has no disc drives.
Thanks,
Christoph Feck
301 - 400 of 419 matches
Mail list logo
