Re: libicu dependancy

2023-09-17 Thread christoph
On 2023-09-17 20:59, Michael Reeves wrote: Is libicu in the CI images already? Hi, i assume for Qt it is there, but is there a need to use it directly? Qt should provide a lot of stuff that allows to skip that. Greetings Christoph

Re: KDE Builder: request for review

2024-07-13 Thread christoph
nges or large dependency increases without a real good reason. But that is just my viewpoint. Greetings Christoph Thiago

Re: KDE Builder: request for review

2024-07-15 Thread christoph
be in my eyes no further backward incompatible changes or large dependency increases without a real good reason. But that is just my viewpoint. Hi, any feedback on that? Thanks. Greetings Christoph Greetings Christoph Thiago

Re: KDE Builder: request for review

2024-07-15 Thread christoph
st not breaking changes. Like we do it with Frameworks and Co. or how CMake handles that. The build tool shall not require the user to fixup the config without really good reasons. Greetings Christoph (please keep the list in CC) Hi, I think before we promote this more as 'the tool

Re: Crow Translate

2024-07-17 Thread christoph
n the app, either as inline message widget or popup, one can not expect that users need to read the meta data somewhere. We try to be privacy sensitive, once telling that the data will float around the internet is really important in my eyes. Greetings Christoph

Re: KDE Builder: request for review

2024-07-21 Thread christoph
at doesn't mean there shall be no new features, just not breaking changes. Like we do it with Frameworks and Co. or how CMake handles that. The build tool shall not require the user to fixup the config without really good reasons. Greetings Christoph (please keep the list in CC) any f

Re: Licensing for cxx-kde-frameworks (Rust bridge for KF6)

2024-11-03 Thread christoph
er is effectively the same as GPL-2.0-or-later with Rust because it's statically linked. MPL-2.0 preserves the copyleft at a per source file level, but allows the binary artifact to have a composition of compatible licenses (including the GNU ones). This is the least messy for Rust bindings to LGPL libraries. If upstream cxx-qt uses Apache-2.0+MIT I would propose to just follow that. Greetings Christoph

Re: migrating old metadata (kdesrc-build action needed)

2024-11-03 Thread christoph
https://invent.kde.org/sysadmin/repo-metadata/-/merge_requests/389 months ago that is no issue. Greetings Christoph HS

Re: Assistance with two bugs

2024-09-22 Thread christoph
. Greetings Christoph

Re: Request to become the maintainer of Trojitá

2024-09-23 Thread christoph
, that is great! Greetings Christoph

Re: Sunsetting Qt 5

2024-11-30 Thread christoph
deadline for that, like one of the Gear releases there. But just to be sure, about how many applications on invent do we talk. Greetings Christoph Cheers, Albert Any application that does not have a port underway as at the point where feature releases become forbidden is proposed to

[kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Christoph Feck
l amazed how Laurent manages to find the time while busy with PIM. Christoph Feck (kdepepo)

Re: Feature matrix for future infrastructure

2015-01-29 Thread Christoph Feck
a different person online, then I *want that*. I find it much more time consuming and demotivating to nitpick small style/whitespace changes, than to simply edit them out. Christoph Feck (kdepepo)

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Christoph Feck
to follow equivalent steps as described at http://qt-project.org/wiki/Setting-up-Gerrit to contribute, then I predict another big loss of developers. Christoph Feck (kdepepo)

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread Christoph Feck
g/r/122341/#comment51969> Please do not use "//" on every line to disable a section of code. It touches every line in the git change log. Better use "#if" on a separate line. - Christoph Feck On Jan. 31, 2015, 6:24

Help solving this month's "Bug of the Month"

2015-02-04 Thread Christoph Feck
patches to the relevant pages, review requests, or bugzilla pages. Anyone is invited to participate and our users will appreciate this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com

Re: Help solving this month's "Bug of the Month"

2015-02-04 Thread Christoph Feck
On Wednesday 04 February 2015 21:51:53 Albert Astals Cid wrote: > El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark > va > > escriure: > > On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: > > > According to recent comments, this i

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2015-02-04 Thread Christoph Feck
unted before > > And the following override list probably needs to be some sort of > tristate - defaulting to no override, what could be done by a leading > checkbox column which activates the override for this device itfp. Fra

[kmplot][kturtle] merged frameworks to master

2015-02-24 Thread Christoph Feck
I just merged these frameworks porting branches to master: - kmplot - kturtle These applications will be released as KF5 applications (using KDELibs4Support) for the KDE Applications 15.04 release. Please help updating translations, CI etc. Christoph Feck (kdepepo)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Christoph Feck
in the menu. - Christoph Feck On May 16, 2015, 12:40 p.m., Patrick Eigensatz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Christoph Feck
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > <https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32> > > > > It would be immensely useful, if Klipper also showed leading/trailing > >

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
e only need to find a name for this option. I wouldn't enable this option by default. The default should be pasting what was copied. Also, please do not mix options that affect the actual clipboard contents and the representation in the menu. An option that says "Replace whitespace with

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
till didn't work. > Now trying with cmake ;) > > Patrick Eigensatz wrote: > Just a small resumé: > 1) Create an option "NAME" to simplify the strings using > QString::simplify() > 2) This option is enabled by default > > >

KDE Applications Versioning

2015-06-08 Thread Christoph Cullmann
nsuse packages seems to have patched release numbers, at least for Konsole). Greetings Christoph -- ----- Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-

Re: KDE Applications Versioning

2015-06-09 Thread Christoph Cullmann
E_APPLICATIONS_ variables around for people wanting to use them. And I think it makes sense to use them for a lot apps, given not many apps have any real version number updates it seems ;=) (it makes bug reports much nicer, if you can actually track the bug to some released version)

Re: KDE Applications Versioning

2015-07-11 Thread Christoph Cullmann
Hi, something like that? https://userbase.kde.org/KDE_Applications_Versioning Where to move it? And is the script in place now? Greetings Christoph - Ursprüngliche Mail - > On Wed, Jul 8, 2015 at 1:24 PM, Aleix Pol wrote: > > > On Wed, Jul 8, 2015 at 11:43 AM, Mar

Re: KDE Applications Versioning

2015-07-11 Thread Christoph Cullmann
- Ursprüngliche Mail - > El Dissabte, 11 de juliol de 2015, a les 15:52:44, Christoph Cullmann va > escriure: > > Hi, something like that? > > > > https://userbase.kde.org/KDE_Applications_Versioning > > I'd like to make it clearer that this is option

Re: KDE Applications Versioning

2015-07-12 Thread Christoph Cullmann
- Ursprüngliche Mail - > El Dissabte, 11 de juliol de 2015, a les 16:59:13, Christoph Cullmann va > escriure: > > - Ursprüngliche Mail - > > > > > El Dissabte, 11 de juliol de 2015, a les 15:52:44, Christoph Cullmann va > > > > > &

Re: KDE Applications Versioning

2015-07-20 Thread Christoph Cullmann
> - - > > > > If it is OK this way, I can add it later today to the wiki page. I somehow missed that mail ;=) I am all for adding that paragraph and then moving the wiki page to the right place. Greetings Christoph -- ---

Re: KDE Applications Versioning

2015-07-26 Thread Christoph Cullmann
. Greetings Christoph - Ursprüngliche Mail - > El Dilluns, 20 de juliol de 2015, a les 09:42:40, Andreas Cord-Landwehr va > escriure: > > On Tuesday 14 July 2015 07:08:57 Andreas Cord-Landwehr wrote: > > > If it is OK this way, I can add it later today to the wiki page. >

RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Christoph Cullmann
ust reopen it again. I think this would make a lot of time consuming bug triaging much easier. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel:

Re: [Development] Please help me get my pending review count down

2015-08-02 Thread Christoph Cullmann
until the QApplication was correctly constructed in all cases before the first QDBus use. Greetings Christoph - Ursprüngliche Mail - > On Wednesday, July 29, 2015 11:03:15 AM Martin Klapetek wrote: > > On Wed, Jul 29, 2015 at 11:47 AM, Marc Mutz wrote: > > > On Wednesday

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Christoph Feck
On Monday 17 August 2015 20:04:04 Albert Astals Cid wrote: > Hi guys, i just merged the frameworks port of rsibreak to master. > > rsibreak is in the unmaintained silo, i'd like to bring it back to > extragear- utils (i guess kdeutils is too much for this niche > app?). > > Anyone wants to review

Re: Moving KDE Connect out of playground

2015-09-15 Thread Christoph Feck
look for documentation. The check on the porting status page looks for an application .desktop file (assuming it appears in the K menu), that's why it flags missing documentation. Christoph

QIcon Search Paths Question

2015-10-21 Thread Christoph Cullmann
with breeze dir inside the "icons" path with the index.theme inside. Sometimes, that even works, sometimes, not. Is there anything special to do? Does KIconThemes play around with that, too? Greetings Christoph -- ----- Dr.-Ing. Christoph Cullmann ---

Re: QIcon Search Paths Question

2015-10-21 Thread Christoph Cullmann
;=) Forget my question, macdeployqt just purged my svg icon engine ;) Greetings Christoph - Am 21. Okt 2015 um 20:00 schrieb cullmann cullm...@absint.com: > Hi, > > I tried to set the icon search path relative to the application directory, > e.g. > like: > >

Re: Review Request 125816: Allow building KF5::ProcessUi without QtWebkit

2015-10-27 Thread Christoph Feck
I find rather useful). We could use QtWebEngine when QtWebKit is not available. - Christoph Feck On Oct. 27, 2015, 12:20 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 125816: Allow building KF5::ProcessUi without QtWebkit

2015-10-27 Thread Christoph Feck
> On Oct. 27, 2015, 1:19 p.m., Christoph Feck wrote: > > One script is used to show detailed memory information (which I find rather > > useful). We could use QtWebEngine when QtWebKit is not available. ... or QTextBrowse

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Christoph Feck
) <https://git.reviewboard.kde.org/r/125910/#comment60248> I am not sure all compilers support initialization of (non-static) members inside the class declaration. I suggest to move it to the constructor. The same code is also present in knotification-framework. - Christoph Feck On

Re: Policy regarding QtWebKit and QtScript

2015-12-23 Thread Christoph Cullmann
no porting guidelines exist, have not tried it again. (attached the state of the port, if somebody wants to give it a try) But as the above mail indicates, such a guide should come up. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Inf

Re: Qt5 version of qimageblitz

2016-03-09 Thread Christoph Feck
On Wednesday 09 March 2016 08:08:14 Boudewijn Rempt wrote: > On Wed, 9 Mar 2016, Albert Astals Cid wrote: > > I guess for that we need to decide if it should be a framework > > first or not. > > Isn't kolourpaint the only user of qimageblitz at the moment? Krita > used to use it, years and years a

Re: Product versions on bugs.kde.org

2016-03-15 Thread Christoph Feck
.kde.org/announcements/kde-frameworks-5.6.0.php > [2] https://www.kde.org/announcements/kde-frameworks-5.8.0.php > [3] https://www.kde.org/announcements/kde-frameworks-5.9.0.php > [4] https://www.kde.org/announcements/kde-frameworks-5.13.0.php Thanks Alexander for cleaning this up. Could please a

Re: Cervisia?

2016-06-04 Thread Christoph Feck
; not been started yet. > > Just for your information: I have now completed the KF5 port and > master now holds this version Thanks for the porting efforts, Martin! I tried compiling master branch, but get errors about many missing headers, such as klocale.h, kglobalsettings.h, kdemacros.h, kinputdialog.h, kiconloader.h, kdeversion.h, and kstatusbar.h For not yet completed ports, you need to add KF5::KDELibs4Support dependency. -- Christoph Feck KDE Quality Team

Re: kolourpaint now KF5 based

2016-07-13 Thread Christoph Feck
On Wednesday 13 July 2016 20:12:46 Martin Koller wrote: > just wanted to let you know that I have now completed the > kolourpaint port to KF5 and this is now in its master branch. I > have also updated kde-build-metadata Hope I did all correct. The about dialog says it is version 5.25.0 (=framewor

kcharselect maintainership

2016-07-22 Thread Christoph Feck
changed; if there is other stuff that needs to be updated, please notify me. Thanks, Christoph -- Christoph Feck KDE Quality Team https://kdepepo.wordpress.com

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

2016-09-14 Thread Christoph Feck
o it the other way round, leave kwebkitpart for now and revisit > before documentation freeze. > That we we get the konqueror except the kwebkit related stuff immediately > up to date and have minimal changes for now. > > Burkhard Lück wrote: > in https://bugs.kde.org/

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-11 Thread Christoph Feck
lications ported (e.g. KTorrent) where the original developer no longer has time for bug handling, and now the regressions pile up. Of course, this would only work if we find enough developers that join such an event. See above. -- Christoph Feck https://kdepepo.wordpress.com/ KDE Quality Team

Re: Kwave is in kdemultimedia now

2016-11-13 Thread Christoph Feck
On 11.11.2016 20:41, Thomas Eschenbacher wrote: as suggested by Ben, I hereby to inform you that today Kwave has been moved to kdemultimedia :) Thanks for your patience :) Did sysadmins also add an entry at reviewboard or phabricator for code reviews? If not, which would you prefer?

Re: Review Request 129423: keditbookmarks: add standard icons and shortcuts to Undo/Redo actions

2016-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129423/#review100929 --- Ship it! Ship It! - Christoph Feck On Nov. 18, 2016

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Christoph Feck
How much work would it be to allow contributors to upload new versions to the CI? In openSUSE, for example, we have separate repos that contain new package versions that are not yet in standard distribution repositories, and so are able to build and deploy unstable versions for practically all

Re: Review Request 129935: Fix build for GCC 7

2017-02-08 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129935/#review102448 --- Ship it! Ship It! - Christoph Feck On Feb. 8, 2017

Re: Ksysguard dev

2017-06-20 Thread Christoph Feck
On 19.06.2017 20:50, Alexandre Biche wrote: I want to add network I/O stats to ksysguard but I you closed kde-workspace's github repo and I don't find the plasma 5 github repo. Can you give me the way to start contributing please Our repositories are at https://cgit.kde.org/ KSysGuard is split

Re: libqaccessibilityclient now in kdereview

2017-08-03 Thread Christoph Feck
On 25.07.2017 13:25, Jonathan Riddell wrote: libqaccessibilityclient is now in kdereview. The autotests need Qt5Test, but if the dependency is not installed, building fails silently. Either require Qt5Test, or make the tests optional if Qt5Test was not found. Issue found by Fabian from openS

Re: kbackup in kdereview

2018-01-10 Thread Christoph Feck
for liquidshell, please; I have some bug reports lying around 8) -- Christoph Feck

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread Christoph Feck
overview before doing releases. Christoph Feck

Re: CI System Reorganisation

2018-09-09 Thread Christoph Feck
I can view all of "stable" Applications on a single page? I remember I asked if it would still be possible after the change, but I cannot see a filter or link to get an overview of all builds. Christoph Feck

Re: KDE release

2019-02-18 Thread Christoph Feck
ns in the under laying code the require a text file. The plan is allow simple is equal comparison with but binaries. However the current comparison code does not respond well to such files. ENOPARSE Christoph Feck

Possible to move some KF5 frameworks to invent?

2019-08-11 Thread Christoph Cullmann
Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Possible to move some KF5 frameworks to invent?

2019-08-11 Thread Christoph Cullmann
On 2019-08-11 16:53, Albert Astals Cid wrote: El diumenge, 11 d’agost de 2019, a les 12:33:19 CEST, Christoph Cullmann va escriure: Hi, is it possible to move individual framework modules over to invent.kde.org or will that be done at once somewhen in the future? Seems kde-frameworks-devel

Re: Possible to move some KF5 frameworks to invent?

2019-08-13 Thread Christoph Cullmann
nt to invent.kde.org. (I assume we want to do that some when in the future anyways) Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Possible to move some KF5 frameworks to invent?

2019-08-15 Thread Christoph Cullmann
Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KDE Frameworks 5.62.0 released

2019-09-14 Thread Christoph Feck
On 09/14/19 13:35, David Faure wrote: 14th September 2019. KDE today announces the release of KDE Frameworks 5.62.0. http://kde.org/announcements/kde-frameworks-5.62.0.php This web page says the release number is 5.1.0.

HiDPI issues with KDE applications

2019-09-28 Thread Christoph Cullmann
tAttribute(Qt::AA_UseHighDpiPixmaps, true); part that we sprinkled in most of KDE's things in the past. I now rectified that for Kate/KWrite, shall we do this for all our applications? Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: HiDPI issues with KDE applications

2019-09-28 Thread Christoph Cullmann
on if it behaves OK. (I did that for KWrite/Kate) Greetings Christoph On Sat, Sep 28, 2019 at 5:05 PM Christoph Cullmann wrote: Hi, I just checked again the HIDPI support of Kate/KWrite on Windows and it "sucked". It seems we never properly did setup the stuff to auto-

Re: HiDPI issues with KDE applications

2019-09-28 Thread Christoph Cullmann
On 2019-09-28 17:37, Christoph Cullmann wrote: On 2019-09-28 17:34, Albert Vaca Cintora wrote: If this has to be done for all apps, why isn't it done at Qt level? Because in some cases, that breaks the application, e.g. if it expects pixel to be real physical pixel 1:1. Therefore,

Re: HiDPI issues with KDE applications

2019-09-28 Thread Christoph Cullmann
, testing there would be appreciated. I can only tell, that without the below change, already on one screen it looks horrible :=) Greetings Christoph On Sat, Sep 28, 2019, 11:05 AM Christoph Cullmann wrote: Hi, I just checked again the HIDPI support of Kate/KWrite on Windows and it "s

Re: Keysmith in kdereview

2019-12-28 Thread Christoph Feck
questions. Please refer me to any docs I should read. Our framework is already splitted into dozens of individual libraries, see https://techbase.kde.org/KDE_Frameworks -- Christoph Feck

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-30 Thread Christoph Cullmann
pens to contain just TWO independent libraries. Hmm, I am not that sure about that naming. I see that it provides stuff with QTextDocument in mind, but KF6::TextDocument would in my eyes more look like some generic "enhanced" QTextDocument, but Grantlee provides a very specific extens

KUserFeedback integration for Kate

2020-01-27 Thread Christoph Cullmann
that might violate our policy. For now, we just collect some usage statistics. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

KUserFeedback integration for Kate

2020-01-27 Thread Christoph Cullmann
that might violate our policy. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Recommendation: drop ProvidersUrl entry to rely on default value

2020-01-30 Thread Christoph Feck
KNewStuff library as current value. Does it work with all KNewStuff 5.x versions? Otherwise, the required KF5 version would need to be bumped where this change was made. -- Christoph Feck

KUserFeedback integration for Kate

2020-02-02 Thread Christoph Cullmann
that might violate our policy. For now, we just collect some usage statistics. Please provide your feedback either on this list or on the merge request. Thanks! Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KUserFeedback integration for Kate

2020-02-05 Thread Christoph Cullmann
On 2020-02-02 12:27, Christoph Cullmann wrote: Hi, I created some initial merge request for basic user feedback integration into Kate: https://invent.kde.org/kde/kate/merge_requests/60 To do this properly like described in https://community.kde.org/Policies/Telemetry_Policy I would like to

Re: Review Kid3

2020-02-13 Thread Christoph Feck
/doc/trunk-kf5/po/kid3.po/ Kid3 exists since 2003 and I would say that it is quite mature. As it is also available as a Qt-only version (without KDE dependencies) and for macOS, Windows and Android, the build system differs a bit from the typical KDE application. -- Christoph Feck KDE Bug

Re: Review Kid3

2020-02-18 Thread Christoph Feck
On 02/13/20 22:14, Albert Astals Cid wrote: You should change the bug reporting to use bugzilla not your email address in KAboutData Right. Urs, could you please request creation of a bugzilla product? Thanks, Christoph

Re: Is kdeinit still actual?

2020-04-27 Thread Christoph Feck
On 04/27/20 12:53, Alexander Volkov wrote: So, does it still makes sense to use kdeinit? https://phabricator.kde.org/T12140

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-28 Thread Christoph Feck
unce > that I agreed with Michael Leupold to take over the maintainership > [...] Nice to see you stepping up to the plate :) Could you please inform bugzilla maintainers to change the default assignee address for kwalletmanager and kdelibs/kwallet? Merci Christoph Feck (kdepepo) KDE Quality Team

Re: Review Request 112319: Fix network stats with new systemd interface names

2013-09-03 Thread Christoph Feck
ied by two testers, see bug 315259. Thanks, Christoph Feck

Re: kde-workspace master becomes Qt5-based

2013-10-01 Thread Christoph Feck
On Tuesday 01 October 2013 15:25:27 Sebastian Kügler wrote: > On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote: > > > We're planning to merge the frameworks-scratch branch of > > > kde-workspace into master next Monday. > > > > I tried building the branch. It requires qimageblitz, which I

Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac

2013-10-01 Thread Christoph Feck
> On Sept. 23, 2013, 4:18 p.m., Sune Vuorela wrote: > > Ship It! Nicolas, do you have or want to obtain commit rights? If not, Nepomuk developers can commit it for you. - Christoph --- This is an automatically generated e

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called "size_fdiag"

2013-10-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/#review41483 --- Ship it! Ship It! - Christoph Feck On Oct. 10, 2013, 9:51

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Christoph Feck
> On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote: > > Ship It! Thanks Jiří. If possible, please request commit rights to the KDE repositories, so you can commit yourself after each review. This simplifies the work for others. -

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Christoph Feck
> On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote: > > Ship It! > > Christoph Feck wrote: > Thanks Ji?í. If possible, please request commit rights to the KDE > repositories, so you can commit yourself after each review. This simplifies > the work for others.

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Christoph Feck
to mention 800 pixels...) I hope the key size and font size is not hard coded, did not look at the code yet. - Christoph Feck On Oct. 25, 2013, 7:13 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
4.11.3. Someone else must approve. - Christoph Feck On Oct. 27, 2013, 10:36 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, thoug

Re: Review Request 102231: Pass KAboutData::productName() to DrKonqi

2013-10-27 Thread Christoph Feck
hough, it aborted with "drkonqi: Unknown option 'productname'." Thanks, Christoph Feck

Review Request 113504: Fix krunner calculator letter check

2013-10-29 Thread Christoph Feck
pport functions in the case the user had omitted the '=' Diffs - plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504/diff/ Testing --- Thanks, Christoph Feck

Re: Review Request 113504: Fix krunner calculator letter check

2013-10-30 Thread Christoph Feck
7;=', restoring 4.10 behavior. If I understand the letter check correctly, it is very hard to support functions in the case the user had omitted the '=' Diffs - plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504/diff/ Testing --- Thanks, Christoph Feck

Re: Adopting AppData in KDE?

2013-11-04 Thread Christoph Feck
Hi, what would be nice to have is information about which MIME types an application can read and write. Christoph Feck (kdepepo) KDE Quality Team

Re: Review Request 113846: fix kicontheme::list

2013-11-13 Thread Christoph Feck
ttp://git.reviewboard.kde.org/r/113846/#comment31365> Use '/' (single quotes) for single characters. But this line also misses some QLatin1String or QStringLiteral to be NO_ASCII_CAST safe. - Christoph Feck On Nov. 13, 2013, 5:33 p.m., Jonath

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Christoph Feck
y it (including Plasma-NM components, etc.). Christoph Feck (kdepepo) KDE Quality Team

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
: Target `ktimezoned/CMakeFiles/kded_ktimezoned_automoc.dir/build' not remade because of errors. make[1]: *** [ktimezoned/CMakeFiles/kded_ktimezoned_automoc.dir/all] Error 2 Any idea? - Christoph --- This is an automatically gen

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: >

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-11-17 Thread Christoph Feck
x27;t mean it's unmaintained by the distro and > > it's not said that one could upgrade (think of Debian Stable). Jekyll, has this been discussed on the packagers list? - Christoph --- This is an automatically ge

Review Request 113931: Fix process list to start already sorted

2013-11-18 Thread Christoph Feck
Diff: http://git.reviewboard.kde.org/r/113931/diff/ Testing --- I use this patch since some weeks. Thanks, Christoph Feck

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Christoph Feck
ome discussion and links to related bugs. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113965/#review44060 --- O

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Christoph Feck
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.r

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Christoph Feck
a patch :P Anyway, nice analysis, and this probably also fixes bug 290971, but have not tested it yet. - Christoph Feck On Nov. 20, 2013, 9:47 p.m., Yichao Yu wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 114017: Possibly fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
r code. Someone >please confirm it fixes the problem. Diffs - kdeui/widgets/ktabwidget.cpp 49dc293 Diff: http://git.reviewboard.kde.org/r/114017/diff/ Testing (updated) --- Fixes the crash, according to a tester. Thanks, Christoph Feck

  1   2   3   4   5   >