Re: Cervisia?

2015-09-27 Thread Michael Reeves
On Sep 26, 2015 9:22 PM, "Jeremy Whiting" wrote: > > Martin, > > Michael Reeves reeves...@gmail.com mentioned he would be interested in > helping also, maybe the two of you can get it ported away from > Qt3Support, then ported to Qt5/Kf5 ? > > thanks, > Jere

KDE inclusion

2018-01-11 Thread Michael Reeves
I have a version of kdiff3 that I ported to kf5. I like to what build requirements kf5 as a whole has. Also what would be the process for being considered for inclusion in kde?

Re: KDE inclusion

2018-01-14 Thread Michael Reeves
my machine. I generally work with two way comparisons. On Thu, Jan 11, 2018 at 6:24 PM, Albert Astals Cid wrote: > El dijous, 11 de gener de 2018, a les 12:15:15 CET, Kevin Funk va escriure: > > On Tuesday, 9 January 2018 21:06:36 CET Michael Reeves wrote: > > > I have a versio

Re: Re: KDE inclusion

2018-01-14 Thread Michael Reeves
Fixed local file handling prevented merges from being saved. Thin rapper class created to insure scheme is never blank. QUrl::isLocal returns false in this case. On Sat, Jan 13, 2018 at 2:47 AM, Michael Reeves wrote: > Looks the original is a somewhat modified version of be348bcf1. It does

Re: Re: KDE inclusion

2018-01-14 Thread Michael Reeves
l: It seems the repo at https://bitbucket.org/reporter123/kdiff3 > has no public access. > > Kudos, > Joachim > > > *Gesendet:* Donnerstag, 11. Januar 2018 um 22:28 Uhr > *Von:* "Michael Reeves" > *An:* "Albert Astals Cid" > *Cc:* kde-core-dev

Re: Aw: Re: KDE inclusion

2018-01-15 Thread Michael Reeves
Just a not in the at vs. kde. The ported to hf5/qt5 eliminated some of the code differences between the two. I removed to if defs as obsolete. A third I replaced with a platform check for Windows as there seems no other need for it now. I don't have a preference on this. On Jan 15, 2018 3:09 AM, "

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-19 Thread Michael Reeves
working on getting merging in changes from Thomas as needed. Just got through bringing it up to date with Joachim's code. Real fun since it's still kde4. On Jan 15, 2018 5:47 PM, "Albert Astals Cid" wrote: El dimarts, 9 de gener de 2018, a les 20:06:36 CET, Michael Reeves va e

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-28 Thread Michael Reeves
A little confused on where to start with this sponsor thing. On Jan 19, 2018 3:52 PM, "Kevin Funk" wrote: > On Wednesday, 17 January 2018 21:40:49 CET Michael Reeves wrote: > > Yes I use this myself so I won't simply abandon it. That said I work in > > mostly in

kdiff3 status

2018-02-15 Thread Michael Reeves
Just got the code moved to KDE playground. The code builds under kf5/qt 5 without kde4support. Contextual menu plug-in for dolphin functions as expected. Code base has been fully ported but not all features have been tested after conversions. Two way merging is fully operational. Reversed sorti

Re: kdiff3 status

2018-02-23 Thread Michael Reeves
On Sat, Feb 17, 2018 at 4:03 AM, Wolfgang Bauer wrote: > I haven't looked at the code at all, I'll leave that up to others. > > But one thing: > While it builds fine in general, I couldn't get the kfileitemaction plugin > to > build, so that it shows up in dolphin's context menu e.g. > > I'll tak

Re: kdiff3 status

2018-02-23 Thread Michael Reeves
the case. I had the feeling this was likely the case give how long cmake 3.1 and qt 5.6 have been out. On Mon, Feb 19, 2018 at 9:03 PM, Luigi Toscano wrote: > Michael Reeves ha scritto: > > Just got the code moved to KDE playground. The code builds under kf5/qt 5 > > without kde4su

Re: kdiff3 status

2018-02-24 Thread Michael Reeves
Fixed now thanks. On Feb 23, 2018 8:11 AM, "Wolfgang Bauer" wrote: Am Dienstag, 20. Februar 2018, 01:47:26 schrieben Sie: > I'll take a look thanks. Is it given error out out or just not building? I should have been more detailed in the first place, sorry. It is not being built at all. From th

Re: Kde CI setup

2018-06-04 Thread Michael Reeves
I'm sending this again because I've been having issues with this mail ing list I haven't received any response so I don't know if it went through. On Mon, May 14, 2018, 2:19 PM Michael Reeves wrote: > How does one use kde's ci system? Is there a way to test a projec

Kde translation.

2018-06-04 Thread Michael Reeves
How are translations handled as far distribution goes?

Kde CI setup

2018-06-04 Thread Michael Reeves
How does one use kde's ci system? Is there a way to test a projects setup before going live with it?

Re: Kde CI setup

2018-06-09 Thread Michael Reeves
itory? If so, open > a sysadmin ticket to include it on the CI. If not, it might not be > available for your project. > > Regards > > Thomas > > On Montag, 4. Juni 2018 17:20:54 CEST Michael Reeves wrote: > > > I'm sending this again because I've been

Re: Kde translation.

2018-06-09 Thread Michael Reeves
Thanks. On Mon, Jun 4, 2018, 5:23 PM Albert Astals Cid wrote: > El dijous, 26 d’abril de 2018, a les 13:59:18 CEST, Michael Reeves va > escriure: > > How are translations handled as far distribution goes? > > This question is a bit vague. > > Are you asking what we

Kdiff3 release.

2018-07-30 Thread Michael Reeves
> > What would be next step in getting a release setup fir kdiff3? Do we have > documentation on the process?

Re: Kdiff3 release.

2018-08-02 Thread Michael Reeves
That's what I'm looking at doing. The translation need some minor updating. In particular the docs were changed to correct some obsolete information regarding windows and preprocessor command handling. On Tue, Jul 31, 2018, 5:26 AM Luigi Toscano wrote: > Michael Reeves ha scritto:

Kdiff3 in kdereview

2018-08-07 Thread Michael Reeves
Kdiff3 has moved to review in preparation for possible release testing. I am currently working towards having auto testing but the code needs major refactoring to make this possible. Specifically it is not well modularized. The purpose of this review is to get feedback on issues that need to be add

Re: Kdiff3 in kdereview

2018-08-29 Thread Michael Reeves
On Tue, Aug 28, 2018, 5:45 PM Albert Astals Cid wrote: > El divendres, 24 d’agost de 2018, a les 3:20:13 CEST, Michael Reeves va > escriure: > > On Thu, Aug 23, 2018, 6:07 PM Albert Astals Cid wrote: > > > > > El dimarts, 7 d’agost de 2018, a les 14:59:50 CEST, Micha

Re: Kdiff3 in kdereview

2018-08-31 Thread Michael Reeves
On Wed, Aug 29, 2018, 4:34 PM Albert Astals Cid wrote: > El dimecres, 29 d’agost de 2018, a les 1:04:45 CEST, Michael Reeves va > escriure: > > On Tue, Aug 28, 2018, 5:45 PM Albert Astals Cid wrote: > > > > > El divendres, 24 d’agost de 2018, a les 3:20:13 CEST, Micha

Re: Kdiff3 in kdereview

2018-09-03 Thread Michael Reeves
The memory leak should be gone with the latest commit. This also resolve s one source of noise coming from code that is not needed as of QT 5.3.2. Tested up to looking at a two directory diff and opening of the files. All messages seem to be gone. Some unnecessary Windows specific code has been rem

Re: Kdiff3 in kdereview

2018-09-14 Thread Michael Reeves
de setembre de 2018, a les 17:38:35 CEST, Michael Reeves va > escriure: > > The memory leak should be gone with the latest commit. This also resolve > s > > one source of noise coming from code that is not needed as of QT 5.3.2. > > Tested up to looking at a two directory di

Re: Kdiff3 in kdereview

2018-09-20 Thread Michael Reeves
Yes I am going to setup a vm and see if this works. My system is having trouble with this. On Sat, Sep 15, 2018, 10:30 AM Wolfgang Bauer wrote: > Am Freitag, 14. September 2018, 16:36:10 schrieb Michael Reeves: > > Can some do a clean install and see if right clicking on a file

Re: Kdiff3 in kdereview

2018-11-17 Thread Michael Reeves
st of the work. QDir::setCurrent calls have been removed as they introduced an unnecessary point of failure. On Sat, Sep 15, 2018, 12:16 PM Michael Reeves Yes I am going to setup a vm and see if this works. My system is having > trouble with this. > > On Sat, Sep 15, 2018, 10:30 AM Wolfgan

Missing newline check

2018-12-10 Thread Michael Reeves
Why is krazy still checking for newlines at the end of files? Modern tools don't seem to get tripped up by this. http://ebn.kde.org/krazy/reports/kdereview/kdiff3/src/index.html

Re: Missing newline check

2018-12-10 Thread Michael Reeves
ou have devs who're > scratching their heads wondering why their stuff doesn't work when they're > forced to use one old tool that doesn't cover up for this sloppiness... so > the fact that Krazy is complaining loudly about this is a *very good* thing. > > Than

Re: Missing newline check

2018-12-13 Thread Michael Reeves
ensure a newline is present at > the > end so that this all works without human intervention. > > David. > > On lundi 10 décembre 2018 13:47:46 CET Michael Reeves wrote: > > Thanks for the reply in my view not treating endof file as newline is a > > flaw in the standard

Re: Kdiff3 in kdereview

2019-01-22 Thread Michael Reeves
Would there be any objections to moving Kdiff3 to extragear. I looking to do a test release by the end of Feb. On Nov 14, 2018 10:30 AM, "Michael Reeves" wrote: Its been two months now has any found problems that must be resolved. I am currently working my through the code tring to

KDE release

2019-02-18 Thread Michael Reeves
I'm looking to tag for 1.8 at the end of the week. If more time is needed let me know. Binary files are ignored during diff generation due tomorrow assumptions in the under laying code the require a text file. The plan is allow simple is equal comparison with but binaries. However the current compa

KDiff3 craft setup

2019-02-18 Thread Michael Reeves
https://download.kde.org/stable/applications/18.12.1/src/kdiff3-18.12.1.tar.xz Get some one tell me how to change where it's trying to download from. KDiff3 is not part of applications and doesn't follow the same versioning.

Re: KDiff3 craft setup

2019-03-07 Thread Michael Reeves
I have no problem doing self releases for time being. On Tue, Mar 5, 2019, 3:11 PM Albert Astals Cid El dimarts, 19 de febrer de 2019, a les 7:35:58 CET, Kevin Funk va > escriure: > > On Monday, 18 February 2019 17:06:25 CET Michael Reeves wrote: > > > > https://do

KDiff3 1.8 release.

2019-03-10 Thread Michael Reeves
I would like to move forward with a 1.8 release targeting end of Apirl. Could someone please check over the kf5/qt5 changes to make sure there are no major problems? Also there is custom painter that tries to handle left to right text manually what is the proper way to support this? I will be do

Re: KDiff3 1.8 release.

2019-03-13 Thread Michael Reeves
On Sun, Mar 10, 2019, 7:36 PM Friedrich W. H. Kossebau wrote: > Hi Michael, > > Am Samstag, 9. März 2019, 16:53:58 CET schrieb Michael Reeves: > >I would like to move forward with a 1.8 release targeting end of > Apirl. > > Could someone please check over the kf5/

Re: KDiff3 1.8 release.

2019-03-16 Thread Michael Reeves
Fixed now. On Thu, Mar 14, 2019, 4:31 AM Wolfgang Bauer wrote: > The latest change > ( > https://cgit.kde.org/kdiff3.git/commit/?id=638bd5a02893dde4a1927abd0c8a611b3b3ab6a1) > > unfortunately breaks the build here: > > /usr/lib/gcc/i586-suse-linux/8/../../../../i586-suse-linux/bin/ld: > CMakeFil

Re: KDiff3 1.8 release.

2019-03-19 Thread Michael Reeves
E neon dev unstable edition. > > Eike is the Debian packaging managed in a repo somewhere? Are you > interested in making it part of the KDE Qt Debian team? > Yes. > Jonathan > > > > On Sat, 16 Mar 2019 at 14:11, Michael Reeves wrote: > > > > Fixed now

Bug 405506

2019-03-23 Thread Michael Reeves
https://bugs.kde.org/show_bug.cgi?id=405506. Could someone familiar with craft help me with this one. kdiff3 doesn't require any special setup in craft.

KDiff3 1.8 branch freeze.

2019-03-25 Thread Michael Reeves
The kdiff3 1.8 branch is has been created and is now on string/feature freeze. I am targeting late April for release.

Re: CI system maintainability

2019-03-28 Thread Michael Reeves
On Thu, Mar 28, 2019, 6:36 AM Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens: > > Hello, > > > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > > Please note that the commits in this instance were pushed without > > > review, so

Extragear release files

2019-04-13 Thread Michael Reeves
Where do release files go after sys admin moves them? Where would they be downloaded from?

Fwd: Craft missing icon on start menu shortcut

2019-05-09 Thread Michael Reeves
This message has been stuck waiting for approval for three days. Will someone kindly address this? -- Forwarded message - From:Michael Reeves Date: Mon, Apr 29, 2019, 10:54 AM Subject: Craft missing icon on start menu shortcut To: I am trying to get kdiff3's icon to show start

Kdiff3 renovation

2019-05-09 Thread Michael Reeves
Just a heads up kdiff3 is about to go through some major renovation. Currently file processing is extremely in efficient. There are at least three loops through the entirety of the data. Further more thee complete copies are kept in memory. Changing this will require almost a complete rewrite of th

Re: Craft missing icon on start menu shortcut

2019-05-15 Thread Michael Reeves
Yes thanks. On Thu, May 9, 2019, 2:36 PM Ben Cooksley wrote: > On Fri, May 10, 2019 at 3:19 AM Michael Reeves > wrote: > > > > This message has been stuck waiting for approval for three days. Will > someone kindly address this? > > Hi Michael, > > There

Re: Kdiff3 renovation

2019-05-21 Thread Michael Reeves
pps-announce@ list? > https://marc.info/?l=kde-announce-apps&r=1&b=201905&w=2 > > Jonathan > > > On Thu, 9 May 2019 at 16:19, Michael Reeves wrote: > >> >> Just a heads up kdiff3 is about to go through some major renovation. >> Currently file proce

Kdiff3 gitlab move

2019-07-04 Thread Michael Reeves
What would be involved in moving kdiff3 to gitlab?

Kdiff3 KIO handling

2019-07-04 Thread Michael Reeves
I would like someone to audit the way kdiff3 uses KIO on remote files. Specifically I am looking for anyway error/completion signals can be missed causing an indefinite hang until the compare is canceled. Also any extra work being done by kdiff3 that should be handed off to KIO. There should also a

Re: HiDPI issues with KDE applications

2019-09-28 Thread Michael Reeves
While were on this topic https://bugreports.qt.io/browse/QTBUG-75039 It seems qt has a few bugs related to this. Make sure multi monitor setups are tested as well. On Sat, Sep 28, 2019, 11:05 AM Christoph Cullmann wrote: > Hi, > > I just checked again the HIDPI support of Kate/KWrite on Windows

Re: ELF Dissector in kdereview

2019-10-01 Thread Michael Reeves
On Tue, Oct 1, 2019, 7:24 AM Elv1313 . wrote: > Hello, > > This tool looks very useful. I am wondering if the Qt 5.11 requirement > isn't a bit overkill given only 2 lines of code require it (git grep > "horizontalAdvance"; > See kdiff3 for the old name of this method. That will work at least to

Re: Work Branches

2019-10-05 Thread Michael Reeves
On Fri, Oct 4, 2019, 10:11 PM Ben Cooksley wrote: > Hi all, > > Recently we had a discussion (which I think may have ended up spread > over a couple of mailing lists in the end) concerning branches and the > ability to force push to them. > > Current policy forbids force pushing to branches excep

Fwd: [kdiff3] [Bug 412932] New: [KDiff3][v 1.9.70 x64] Missing Icons in Taskbar (Ubuntu)

2019-10-17 Thread Michael Reeves
Could someone with knowledge of plasmas icon them handling please look at this. It appears to be an issue beyond kdiff3's scope. Not sure who to refer it to. Original Message From: bugzilla_nore...@kde.org Sent: October 14, 2019 4:22:32 AM EDT To: reeves...@gmail.com Subject: [

Re: Get Hot New Stuff - Legacy Endpoints and Multiple Requests (Discover?)

2020-02-01 Thread Michael Reeves
There seems to be some sort of ssl certificate issue with autoconfig.kde.org. On kubuntu this triggers a warning as soon as discover starts that may be a contributing factor. On Thu, Jan 30, 2020, 4:20 AM Ben Cooksley wrote: > Hi all, > > While diagnosing an issue this evening with cdn.kde.org,

KDiff3 on macosx

2020-02-25 Thread Michael Reeves
Can someone with a working osx craft setup please look at why KDiff3 is failing on build factory?

Re: KDiff3 on macosx

2020-03-02 Thread Michael Reeves
It case it wasn't clear the first time my issue isn't so much finding the error message itself as determining how to fix it. On Tue, Feb 25, 2020, 2:02 PM Michael Reeves wrote: > > Can someone with a working osx craft setup please look at why KDiff3 is > failing on build factory? >

Re: Manner in which kde-gtk-config development is conducted

2020-03-28 Thread Michael Reeves
On Sat, Mar 21, 2020, 10:27 AM Johan Ouwerkerk wrote: > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > > > Comments welcome. Please note that simply fixing the dependency > > breakage in this case is not enough to resolve this - there are > > underlying issues which need to be addressed

Re: Kup in KDE Review

2020-04-16 Thread Michael Reeves
On Tue, Apr 14, 2020, 5:19 AM Simon Persson wrote: > On 2020-04-07 05:09, Adriaan de Groot wrote: > > On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote: > . > > > > > > > - Uses a handful of deprecated methods; depending on what exactly you > want to > > be compatible with, you might chas

Up coming Kdiff3 1.8.3 Release

2020-05-30 Thread Michael Reeves
I plan on trying to release 1.8.3 in a two week. This should give some time for things to settle down now that the initial move to Gitlab is done.

Flatpak config

2020-06-23 Thread Michael Reeves
How does one specify dependencies in flatpak for binary-factory.kde.org. signature.asc Description: This is a digitally signed message part.

Re: Shift for parts of the CI system to Qt 5.15

2020-06-23 Thread Michael Reeves
Is there a record of the work done so far? It looks like some of the errors look like the result off missing #include *.moc. I only know having run into this myself. Usually in clang/gcc. Not sure why this would show up only in MSVC. I can investigate when I get home. I build kdiff3 for windows so

Re: Can we make api.kde.org search better?

2013-11-04 Thread Michael Reeves
On Nov 2, 2013 3:35 PM, "Albert Astals Cid" wrote: > > El Dissabte, 2 de novembre de 2013, a les 12:59:00, Allen Winter va escriure: > > On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: > > > > A PHP person could fix the attached program so that we can search for > > ".*foo.*"

Re: Can we make api.kde.org search better?

2013-11-08 Thread Michael Reeves
On Nov 5, 2013 6:44 PM, "Albert Astals Cid" wrote: > > > Well Michael Reeves volunteered, no? Allen are you sending him the data? > > Cheers, > Albert > > > > > Aleix > I got the data.

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Michael Reeves
On Monday, November 11, 2013 9:22:57 PM Albert Astals Cid wrote: > El Dilluns, 11 de novembre de 2013, a les 19:36:45, Kevin Krammer va escriure: > Of course one can say that the crash in [1] is a bug that someone will fix, > any taker? > > Cheers, > Albert > > [1] http://pastebin.kde.org/pol

Klook/dolphin

2013-12-25 Thread Michael Reeves
Is anybody still working on Klook? If so I have an updated patch for dolphin integration. signature.asc Description: This is a digitally signed message part.

Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-05-29 Thread Michael Reeves
dde6a49 konqueror/settings/kio/uasproviders/safari517.desktop 34a3a00 konqueror/settings/kio/uasproviders/safari60.desktop 332a758 Diff: https://git.reviewboard.kde.org/r/118407/diff/ Testing --- none as yet. Just made minor string changes in the .desktop files. Thanks, Michael Reeves

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-05-29 Thread Michael Reeves
n the .desktop files. Affects 4.13.x branch as well. Thanks, Michael Reeves

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
----------- On June 2, 2014, 10:22 a.m., Michael Reeves wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118407/ > --

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
none as yet. Just made minor string changes in the .desktop files. Affects 4.13.x branch as well. Thanks, Michael Reeves

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/#review58978 --- On June 2, 2014, 10:22 a.m., Michael Reeves wrote: > > --

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
--- none as yet. Just made minor string changes in the .desktop files. Affects 4.13.x branch as well. Thanks, Michael Reeves

Re: Fwd: PVS-Studio KDE analysis

2014-10-10 Thread Michael Reeves
On Friday, October 03, 2014 4:24:01 AM Christoph Feck wrote: > On Friday 03 October 2014 02:53:37 Boris Egorov wrote: > > On 10/02/2014 04:45 PM, Ben Cooksley wrote: > > > Okay, can you confirm whether we're allowed to publish this > > > publicly or not? > > > > > > Thanks, > > > Ben > > > > Svyato

Re: KDEReview for Kontrast

2020-08-11 Thread Michael Reeves
The odd naming is a flatpac requirement if you want the icon auto extracted. Otherwise flatpac will have to be told explicitly to rename the icon. On Tue, Aug 11, 2020, 3:38 AM Christophe Giboudeaux wrote: > On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > > I added the icon and I

Re: Git merge workflow: reverse it?

2020-08-24 Thread Michael Reeves
"You keep track of your patches (more or less succesfully) and cherry-pick or port them." This sums up what I do with kdiff3. In fact right now trying to merge between stable and master or the other way around would be a nightmare project due to heavy refactoring. On Mon, Aug 24, 2020, 4:07 PM w

MacOS signing issue.

2020-10-22 Thread Michael Reeves
Could someone familiar with the CI and OS X signing machinism look at this. https://bugs.kde.org/show_bug.cgi?id=428062 I have no way to test or fix this issue. Which as far as I know is an issue with the CI on binary factory.

Re: MacOS signing issue.

2020-10-22 Thread Michael Reeves
e submitting the app to apple's > notarization service in the first place. > > On Thu, Oct 22, 2020 at 11:12 AM Ben Cooksley wrote: > >> On Fri, Oct 23, 2020 at 6:08 AM Michael Reeves >> wrote: >> >>> Could someone familiar with the CI and OS X signing

Re: MacOS signing issue.

2020-10-22 Thread Michael Reeves
e putting it into the dmg. That said > iirc signing the app is a requirement before submitting the app to apple's > notarization service in the first place. > > On Thu, Oct 22, 2020 at 11:12 AM Ben Cooksley wrote: > >> On Fri, Oct 23, 2020 at 6:08 AM Michael Reeves >>

Fwd: [sdk/kdiff3] src: Disable problematic clazy warnings

2020-12-21 Thread Michael Reeves
arded message - From: Michael Reeves Date: Fri, Dec 18, 2020, 5:02 PM Subject: [sdk/kdiff3] src: Disable problematic clazy warnings To: Git commit 4b319434a0a0e9c11f3de358bb307dca75750fb7 by Michael Reeves. Committed on 18/12/2020 at 21:58. Pushed by mreeves into branch 'master&

KIO::UDSEntry support in kdiff3

2021-01-14 Thread Michael Reeves
I have added support for KIO::UDSEntry::UDS_LOCAL_PATH in master this will be part of the upcoming 1.9 branch. Also the detection of links via KIO has been fixed. This is fixed in the 1.8 branch official release of 1.8.5 will come late today or tomorrow. Display name support is planned for master

Failing KDiff3 build due to kf5 internal dependency issue

2021-01-15 Thread Michael Reeves
KDiff3 MacOS X build at binary factory is failing with the fallowing error: 16:04:13 CMake Error at /Users/packaging/Craft/BinaryFactory/macos-64-clang/dev-utils/cmake-base/CMake.app/Contents/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message): 16:04:13Could NOT find Qt

CI testing with local files

2021-01-27 Thread Michael Reeves
Is there way to reading and writing small files in the CI? I'm in the process of writing auto tests for kdiff3.

Re: CI testing with local files

2021-01-28 Thread Michael Reeves
Thanks. On Thu, Jan 28, 2021, 2:17 PM Andreas Cord-Landwehr wrote: > On Donnerstag, 28. Januar 2021 10:20:54 CET Konstantin Kharlamov wrote: > > On Wed, 2021-01-27 at 17:36 -0500, Michael Reeves wrote: > > > Is there way to reading and writing small files in the CI? I'm

Re: Koko in KDEReview

2021-05-03 Thread Michael Reeves
Please don't make my life hard with this kind of unilateral decision making if kde aa whole decides to move ro gitlab that's one thing. I am not going to keep dealing with users confusion caused by projects like yours engaging in undiscussed experiments for support. That.comes frim someone who woul

KDiff Bug 436958

2021-05-12 Thread Michael Reeves
Could someone other than myself please have a look at this. https://bugs.kde.org/show_bug.cgi?id=436958 None of these issues affect my system. I strongly suspect a distro specific issue. https://bugs.gentoo.org/show_bug.cgi?id=789330. The offending commit makes no sense as a true root cause. I wo

Re: KDiff Bug 436958

2021-05-12 Thread Michael Reeves
Thanks do we have the text of the assert? On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > On Thu, May 13, 2021 at 1:00 AM Michael Reeves > wrote: > > > > Could someone other than myself please have a look at this. > > > > https://bugs.kde.org/show_bug.cgi?i

Re: KDiff Bug 436958

2021-05-12 Thread Michael Reeves
That's a crash in the implicit default constructor of QTemporaryFile. And that would be a Qt bug if its reproducible. You sure you have the current 1.9 branch and built from that? On Wed, May 12, 2021, 7:30 PM Aleix Pol wrote: > On Thu, May 13, 2021 at 1:00 AM Michael Reeves

Re: KDiff Bug 436958

2021-05-13 Thread Michael Reeves
g. If that fixes the problem then the patch will resolve your case as well. On Thu, May 13, 2021, 3:35 PM Ingo Klöcker wrote: > On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: > > That's a crash in the implicit default constructor of QTemporaryFile. > > I do

Re: KDiff Bug 436958

2021-05-13 Thread Michael Reeves
I was looking at the wrong file then. That very likely is related to bug 436958. On Thu, May 13, 2021, 3:35 PM Ingo Klöcker wrote: > On Donnerstag, 13. Mai 2021 07:53:05 CEST Michael Reeves wrote: > > That's a crash in the implicit default constructor of QTemporaryFile. > &

Re: KDiff Bug 436958

2021-05-13 Thread Michael Reeves
Or maybe not. I'll have another look at this now that emergency fix is addressed. Calling SourceData::readAndPreprocess on a SourceData object flagged as a directory shouldn't be happening. On Thu, May 13, 2021, 3:59 PM Michael Reeves wrote: > I was looking at the wrong file th

Re: Progress is good for us but bad for documentation

2021-06-09 Thread Michael Reeves
One thing the seems entirely missing is any documentation what so ever of craft's runtime confurable options. I'm talking things maintainers can do in their config scripts not the end-user config file which is self documented. On Wed, Jun 9, 2021, 1:27 PM Frederik Schwarzer wrote: > > > On 6/9/2

Re: Gitlab CI - Inbound

2021-09-05 Thread Michael Reeves
How do we get a visual on exactly which lines are covered by auto testing and which aren't?

Re: Announcing General Availability of Gitlab CI for Linux, FreeBSD and Android

2021-12-02 Thread Michael Reeves
Where are the artifacts being uploaded to? They don't seem to show in gitlab. In particular the coverage report is of interest to me. On Sat, Nov 27, 2021 at 1:31 PM Ben Cooksley wrote: > Hi all, > > As mentioned in the subject, i'm happy to announce the general > availability of native Gitlab C

Re: Incoming availability of Windows CI for Gitlab and deprecation of build.kde.org

2022-01-09 Thread Michael Reeves
What is the status for MacOS builds? Jan 9, 2022 4:34:38 AM Ben Cooksley : > Hi all, > > Over the past week substantial work has meant that we now have a successfully > compiling seed job for Frameworks on Windows under Gitlab. > > This is a significant step on the road to announcing general a

KDiff3 Missing translation in craft

2022-01-21 Thread Michael Reeves
This is being cross posted because I am not subscribed to kde-window and replies have not shown up in mail archives when I contacted that list for other issues. The bug in question is here: https://bugs.kde.org/show_bug.cgi?id=442607 As far as I can see the setup for kdiff3 is correct but does no

Re: KDiff3 Missing translation in craft

2022-01-21 Thread Michael Reeves
Thanks. On Fri, Jan 21, 2022 at 2:10 PM Ben Cooksley wrote: > On Sat, Jan 22, 2022 at 7:52 AM Michael Reeves > wrote: > >> This is being cross posted because I am not subscribed to kde-window and >> replies have not shown up in mail archives when I contacted that list for

Re: KDiff3 Missing translation in craft

2022-01-22 Thread Michael Reeves
What would be needed to build from a tar ball on Windows. I have a craft setup locally but it likes to use git. Jan 21, 2022 2:10:19 PM Ben Cooksley : > On Sat, Jan 22, 2022 at 7:52 AM Michael Reeves wrote: >> This is being cross posted because I am not subscribed to kde-window and &

Re: Reviewing the process for giving people commit rights

2022-04-14 Thread Michael Reeves
In all honesty formatting is something that should be dealt with automatically. I use clang-format as part of my IDE just so I don't have to think about formatting in addition to the actual functionality of the code I'm writing. Auto formatting as you type helps a lot in keeping code consistently f

New cmake warning.

2022-05-02 Thread Michael Reeves
Could someone please explain why this warning was add to FindKF5.cmake: CMake Warning (dev) at /usr/share/ECM/modules/ECMFindModuleHelpers.cmake:112 (message): Your project should require at least CMake 3.16.0 to use FindKF5.cmake Call Stack (most recent call first): /usr/share/ECM/find-modul

Re: New cmake warning.

2022-05-03 Thread Michael Reeves
That would only affect people who manually update ECM and in that case the error comes first. So warning isn't much use to projects like kdiff3 which don't encourage ot support this kind of wierdness anyway On Tue, May 3, 2022, 12:26 PM Thomas Friedrichsmeier < thomas.friedrichsme...@kdemail.net>

Re: Git merge workflow: reverse it?

2022-05-10 Thread Michael Reeves
On Tue, May 10, 2022 at 10:48 AM Christoph Cullmann (cullmann.io) < christ...@cullmann.io> wrote: > On 2022-05-10 15:33, Nate Graham wrote: > > On 5/10/22 04:15, Ingo Klöcker wrote: > >>> https://manifesto.kde.org/commitments/ > >> > >> I don't see anything in there that would force the same merge

Re: New cmake warning.

2022-05-16 Thread Michael Reeves
Fair enough but could we at least have a way to turn it off if we know what it's about but still want to keep our dependencies lower than what ever current frameworks happens to decide on. May 16, 2022 2:02:26 PM Christoph Cullmann (cullmann.io) : > On 2022-05-16 19:38, Alexander Neundorf wrot

KDiff3 1.10 branch

2022-07-11 Thread Michael Reeves
The kdiff3 1.10 branch has been created and is now on string/feature freeze.

  1   2   >