Review Request 122573: kio-5.7.0 is required

2015-02-15 Thread Heiko Becker
--- dda83138f9180ca1d54925f78d75ddcf2ca3ec49 introduced the usage of KFileCopyToMenu. This class was added to kio between 5.6.0 and 5.7.0. Diffs - CMakeLists.txt 1eda6db Diff: https://git.reviewboard.kde.org/r/122573/diff/ Testing --- cmake .. && make Thanks, Heiko Becker

Re: Review Request 122573: kio-5.7.0 is required

2015-02-16 Thread Heiko Becker
://git.reviewboard.kde.org/r/122573/diff/ Testing --- cmake .. && make Thanks, Heiko Becker

Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig

2015-04-20 Thread Heiko Becker
https://git.reviewboard.kde.org/r/123437/diff/ Testing --- I built okular and checked that it finds and links against libkexiv2. Thanks, Heiko Becker

Re: Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig

2015-07-16 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123437/#review82589 --- Ping? - Heiko Becker On Juni 13, 2015, 8:27 vorm., Heiko

Re: Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig

2015-07-19 Thread Heiko Becker
marked as submitted. Review request for Build System and kdelibs. Changes --- Submitted with commit 35f85f102d6bd097f2fa45c92339f93570dd31ba by Heiko Becker to branch KDE/4.14. Repository: kdelibs Description --- The latter is deprecated and doesn't respect the PKG_C

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Heiko Becker
fixed by this commit: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b9ec9392da21a3421e48c6961976060d872faffb - Heiko Becker On Aug. 19, 2015, 5:41 nachm., René J.V. Bertin wrote: > > --- > This is an automatically genera

Review Request 125983: Give each htmlhandbook target a unique name

2015-11-07 Thread Heiko Becker
fs - cmake/modules/KDE4Macros.cmake 5b3db07206d8075fdb580fda9f0b1f8d76a80511 Diff: https://git.reviewboard.kde.org/r/125983/diff/ Testing --- Passed -DKDE4_ENABLE_HTMLHANDBOOK:BOOL=TRUE to the build, which succeeded withouth error. Thanks, Heiko Becker

Re: Review Request 125983: Give each htmlhandbook target a unique name

2015-11-08 Thread Heiko Becker
marked as submitted. Review request for Build System and kdelibs. Changes --- Submitted with commit eaf92b8d2f5a058fbf575d733f0924c446eb93ee by Heiko Becker to branch KDE/4.14. Bugs: 351287 http://bugs.kde.org/show_bug.cgi?id=351287 Repository: kdelibs Description --- Since

Re: Review Request 127823: Allow building without strigi on Linux

2016-06-12 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127823/#review96377 --- +1 - Heiko Becker On Mai 3, 2016, 2:06 nachm., Antonio

Review Request 128160: Fix compilation with gcc6

2016-06-12 Thread Heiko Becker
, but at least one error less. Thanks, Heiko Becker

Re: Review Request 128160: Fix compilation with gcc6

2016-06-12 Thread Heiko Becker
from solid. > > > Diffs > - > > solid/solid/backends/shared/cpufeatures.cpp > baa1af21098d7c312d7a9176e216d9d0f8e3a7a6 > > Diff: https://git.reviewboard.kde.org/r/128160/diff/ > > > Testing > --- > > Not enough to successfully compile with gcc-6, but at least one error less. > > > Thanks, > > Heiko Becker > >

Re: Review Request 128160: Fix compilation with gcc6

2016-06-12 Thread Heiko Becker
ted as a C++11 user-defined > string literal, and you need to add a space if you want it interpreted as > `"foo"` compile-time concatenated with the expanded value of the macro `bar`. > > Albert Astals Cid wrote: > Any idea where's the solid commit that Heiko men

Re: Review Request 128160: Fix compilation with gcc6

2016-06-12 Thread Heiko Becker
marked as submitted. Review request for kdelibs. Changes --- Submitted with commit e36051fd7cf46093bf96cb5eb987102a605be52a by Heiko Becker to branch KDE/4.14. Repository: kdelibs Description --- This basically backports 3c38c2bba3dc2313fa95ff99c76aae3870e0a168 from solid. Diffs

Review Request 129366: Use QTEST_GUILESS_MAIN

2016-11-09 Thread Heiko Becker
: keditbookmarks Description --- Allowing the test to pass without a running X server. Diffs - src/kbookmarkmodel/tests/kbookmarkmodeltest.cpp cdbeca6 Diff: https://git.reviewboard.kde.org/r/129366/diff/ Testing --- Builds, test still passes. Thanks, Heiko Becker

Re: Review Request 129366: Use QTEST_GUILESS_MAIN

2016-11-09 Thread Heiko Becker
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit 515c0914afc3041a69b0042030eab03f58c16b80 by Heiko Becker to branch master. Repository: keditbookmarks Description --- Allowing the test to pass without a running X server

Re: Review Request 129340: Make building drkonqi optional

2016-11-10 Thread Heiko Becker
around locally. - Heiko Becker On Nov. 5, 2016, 11:07 vorm., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-12-15 Thread Heiko Becker
> On Dez. 13, 2016, 10:11 nachm., Albert Astals Cid wrote: > > I honestly can't see how this would count as "bugfix". I see it as a security fix, considering that even Qt5Webkit is probably affected by a three digit number of security issues in its old Webkit and that Qt4Webkit is even based o

Review Request 129806: Update the list of KCModules

2017-01-11 Thread Heiko Becker
elibs.git/commit/?id=0ba7b04d006d412524ca7af0604f84c04a921a79 Diffs - src/konqmainwindow.cpp e9e2eb7bf Diff: https://git.reviewboard.kde.org/r/129806/diff/ Testing --- Webshortcut settings appear under Configure Konqueror | Web Browing Thanks, Heiko Becker

Re: Review Request 129806: Update the list of KCModules

2017-01-11 Thread Heiko Becker
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit 7de40923bcf23bf7137722b3e45041deec12716e by Heiko Becker to branch Applications/16.12. Repository: konqueror Description --- * The webshortcuts KCM has been renamed from

Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

2017-01-12 Thread Heiko Becker
selected text, clicking it opens the desired KCM. Thanks, Heiko Becker

Re: Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

2017-01-22 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129810/#review102109 ------- On Jan. 19, 2017, 11:53 nachm., Heiko Becker wrote: > > --

Re: Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

2017-01-22 Thread Heiko Becker
://git.reviewboard.kde.org/r/129810/diff/ Testing --- Builds, popup entry appears for selected text, clicking it opens the desired KCM. Thanks, Heiko Becker

Re: Review Request 129810: Add popup menu entry to invoke webshortcuts KCM

2017-01-22 Thread Heiko Becker
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit ffd6009d0594e0c9552daec0663f39829fbe219f by Heiko Becker to branch master. Repository: konqueror Description --- ...to quickly add another webshortcut provider. Diffs

Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Heiko Becker
556 Diff: https://git.reviewboard.kde.org/r/130193/diff/ Testing --- Builds fine with cmake-3.9.0. Thanks, Heiko Becker

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Heiko Becker
match the surrounding lines. Diffs - kdeui/CMakeLists.txt d6ec8b47e9af686441ab5ab761be9ff424cbb556 Diff: https://git.reviewboard.kde.org/r/130193/diff/ Testing --- Builds fine with cmake-3.9.0. Thanks, Heiko Becker

krename in kdereview

2017-11-28 Thread Heiko Becker
Hello, thanks to the KDE Sysadmins krename was moved to kdereview today. It's a batch renamer started outside of KDE and its infrastructure but it was kind of abandoned and I got the ok the from the original author to move it to git.kde.org. The code can be found at kde:krename. The intended ta

Re: krename in kdereview

2017-12-05 Thread Heiko Becker
On 12/03/17 23:39, Albert Astals Cid wrote: >> It's a batch renamer started outside of KDE and its infrastructure but >> it was kind of abandoned and I got the ok the from the original author >> to move it to git.kde.org. >> >> The code can be found at kde:krename. >> >> [..] > > Maybe you want t

Review Request 117399: kreadconfig: adapt to moving to kde-cli-tools out of the top level directory

2014-04-06 Thread Heiko Becker
e91241a3bc8925024fbf26ec82df021a28889846 Diff: https://git.reviewboard.kde.org/r/117399/diff/ Testing --- Successfully ran cmake, make and make install. Thanks, Heiko Becker

Re: Review Request 117399: kreadconfig: adapt to moving to kde-cli-tools out of the top level directory

2014-04-07 Thread Heiko Becker
- CMakeLists.txt 7cbdf2108bd76209a74dfe60ae673a78f6832bc4 kde-cli-tools/CMakeLists.txt e91241a3bc8925024fbf26ec82df021a28889846 Diff: https://git.reviewboard.kde.org/r/117399/diff/ Testing --- Successfully ran cmake, make and make install. Thanks, Heiko Becker

Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-08-02 Thread Heiko Becker
ssage(..) and clearMessage(). Diffs (updated) - src/part/part.cpp e63c852151c54018dc5dee448b0bc1367d6ee149 Diff: https://git.reviewboard.kde.org/r/119572/diff/ Testing --- Warning message is gone when running and file names start appearing in the status bar. Thanks, Heiko Becker

Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-08-05 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119572/#review63769 --- On Aug. 2, 2014, 10:19 vorm., Heiko Becker wrote: > >

Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-09-12 Thread Heiko Becker
e63c852151c54018dc5dee448b0bc1367d6ee149 Diff: https://git.reviewboard.kde.org/r/119572/diff/ Testing --- Warning message is gone when running and file names start appearing in the status bar. Thanks, Heiko Becker

Re: KDE's Official Standlaone application packages are missing translations for some basic buttons

2021-06-17 Thread Heiko Becker
On Wednesday, 16 June 2021 11:55:32 CEST, Luigi Toscano wrote: Generally speaking: 1) It only affects DIALOGUES' basic buttons like "OK", "Cancel", "Help" and so on. 2) It affects all languages. 3) It happens only on KDE's official, standalone builds. Packages provided by Linux distros are un

Re: Request to relicense all CC0-1.0 code to MIT (or similar permissive license)

2023-01-22 Thread Heiko Becker
On Sunday, 22 January 2023 18:01:35 CET, Albert Astals Cid wrote: El diumenge, 22 de gener de 2023, a les 14:12:32 (CET), Neal Gompa va escriure: During a review for flatpak-kcm for inclusion in Fedora, I discovered that KDE currently licenses its CI scripts under the CC0 (SPDX: CC0-1.0) license

Usage of KF5/KF6 in targets and CMake config files outside of Frameworks

2023-03-09 Thread Heiko Becker
Hi, while looking at a MR for libkcddb (part of Gear) I wondered if the transition from Qt5/KF5 to Qt6/KF6 could be used to get rid of the KF5/6 prefix in target names and CMake config files for libraries that aren't acutally part of Frameworks. It always seemed a bit illogical and possibly

Re: Request to become the maintainer of Trojitá

2024-09-23 Thread Heiko Becker
On Monday, 23 September 2024 21:52:38 CEST, Kevin Kofler wrote: Hi, I would like to request unarchiving the Trojitá project and assigning maintainership to me. I like to get it back, too. By the way is there a process to archive repos? Considering read-only repos are obviously hard to work

Re: Request to become the maintainer of Trojitá

2024-09-24 Thread Heiko Becker
On Monday, 23 September 2024 22:08:00 CEST, Kevin Kofler wrote: Heiko Becker wrote: I like to get it back, too. Are you willing to maintain it together with me? I am fine with any helping hands (at least trusted KDE contributors who I can trust to not attempt to plant backdoors