DBus-activated applications

or dbus-activatable unique apps. Please help renaming all the .desktop file :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: DBus-activated applications

On Saturday 05 April 2014 09:25:16 Thiago Macieira wrote: > Em sex 04 abr 2014, às 20:32:55, David Faure escreveu: > > The new idea, as a result of last year's freedesktop summit, is to improve > > upon this and generalize it : even the first instance can be started with &g

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117345/#review55040 --- Did you try running the unittests in kio/tests ? - David

Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

on with DesktopNames=TEST --> echo $XDG_CURRENT_DESKTOP says TEST. Thanks, David Faure

Re: Review Request 113969: Do not assume every items have the same height

ak" (which results in return QModelIndex() at the end) and some other code paths (e.g. line 776) do "return QModelIndex()" directly. Any reason for the inconsistency? - David Faure On Nov. 20, 2013, 9:47 p.m., Yichao Yu wrote: > >

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

> On April 5, 2014, 9:16 p.m., David Faure wrote: > > Did you try running the unittests in kio/tests ? > > Simeon Bird wrote: > The kdelibs 4 tests all pass. I don't have a working 5 setup, so I didn't > test the 5 tests, if they are different. The KF5 tests

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117400/#review55089 --- On April 6, 2014, 11:10 a.m., David Faure wrote: > >

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

session with DesktopNames=TEST --> echo $XDG_CURRENT_DESKTOP says TEST. Thanks, David Faure

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

ogged into a session with DesktopNames=TEST --> echo $XDG_CURRENT_DESKTOP says TEST. Thanks, David Faure

Re: Configuration files transfer

On Sunday 06 April 2014 19:29:43 Ivan Čukić wrote: > On Friday 04 Apr 2014 21:36:11 Luca Beltrame wrote: > > David Faure wrote: > > > Kevin Krammer had thoughts on the topic - iirc along the lines of "every > > > application should take care of migrating the rele

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

automounted partition types, though... like "subfs" at least, if I believe kmountpoint.cpp. Another solution is the one from kfileitem.cpp isDirectoryMounted() - identifying unmounted dirs by the fact that they have a size of 0. - David Faure On March 25, 2014, 7:17 a.m., Tomáš T

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

tps://git.reviewboard.kde.org/r/116951/#comment38613> This would hide the error from the debug string, if the caller didn't specify an error pointer. Better use a local var (say localError) and then if (error) *error = localError; - David Faure On March 21, 2014, 3:10 p.m., David J

Re: Configuration files transfer

g the KDE4 data. Plus it's kind of overkill since it handles many levels for many resources while all we need is the local config and data dirs. My suggestion is this instead: https://git.reviewboard.kde.org/r/117511/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55824 --- Ship it! Ship It! - David Faure On April 14, 2014, 11:48

Freedesktop summit 2014

After the meeting, work continues on publishing updated specifications and writing implementations. The meeting is expected to happen again, in 2015. " (Written by Ryan Lortie, from glib/gnome, reviewed by all participants) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Freedesktop summit 2014

On Saturday 19 April 2014 12:33:47 Jos Poortvliet wrote: > On Saturday 19 April 2014 12:30:01 Jos Poortvliet wrote: > > On Thursday 17 April 2014 23:59:48 Albert Astals Cid wrote: > > > El Dijous, 17 d'abril de 2014, a les 20:17:38, David Faure va escriure: > > >

Re: KDE Frameworks Release Cycle

something better. Monthly small increments. Never "big" changes that break things, they get cut into small increments too. So no reason to buffer changes for 6 months. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review57617 --- Ship it! Ship It! - David Faure On April 22, 2014, 10:13

Re: Kronometer now in KDE Review

eporter, to measure the time taken by a slow application to perform a given task. So this isn't just about sports (if one ignores the "lap" feature). -> I think it belongs to KDE SC (kdeutils). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118313/ > --- > > (Updated May 25, 2014, 1:27 p.m.) > > > Review request for KDE

Re: Review Request 118450: Add null-pointer safety check to KonqOperations::pasteInfo(const KUrl&) (to fix a crash on Wayland)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118450/#review58886 --- Ship it! Ship It! - David Faure On June 1, 2014, 12:32

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

ubGroups anymore, but deleteGroupImpl does. Are you sure that it's unaffected by this change? kdecore/config/kconfig.cpp <https://git.reviewboard.kde.org/r/118586/#comment41339> that one is a no-brainer (could be submitted separately right away) - David Faure On June 6, 201

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

repeated keys? Memory (the hash) and CPU (inserting and looking up into the hash), right? I have a hard time being sure that the tradeoff is always in our favour. - David Faure On June 6, 2014, 9:31 a.m., Milian Wolff wrote: > >

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

tps://git.reviewboard.kde.org/r/118587/#comment41376> You could just declare as a friend the qHash function from within KConfigIniBackend, no? - David Faure On June 6, 2014, 9:31 a.m., Milian Wolff wrote: > > --- > This is an automatically g

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

work well with relative urls. Maybe locationEditCurrentTextList should be changed into a qstringlist rather than a url list... It would also be interesting to check if this works in the KIO framework (Qt5), where I ported it to QUrl... - David Faure On June 7, 2014, 4:43 p.m., Vic

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

/src/konqmainwindow.cpp <https://git.reviewboard.kde.org/r/118749/#comment41903> no, this should be mainWindow->comboEdit() - David Faure On June 14, 2014, 11:01 p.m., Dawit Alemayehu wrote: > > --- > This is an automat

Re: Kronometer now in KDE Review

automatically as part of the KDE SC, or do you want to make your own releases (more work for you, but you control when it's released). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Kronometer now in KDE Review

On Thursday 19 June 2014 17:07:49 Elvis Angelaccio wrote: > 2014-06-18 18:50 GMT+02:00 David Faure : > > On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > > > Hello, > > > in the last two months this thread has not been updated, so I assume > > >

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

reviewboard.kde.org/r/118954/ > --- > > (Updated June 26, 2014, 12:15 p.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 142597 > http://bugs.kde.org/show_bug.cgi?id=142597 > > > Repository: kdelibs > > > Description > --- > &

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

954/#comment42568> now this line is going to be called if urls is empty, even with an empty service.path() . This should be: if !service.path.isEmpty use that else if !urls.isEmpty use first url - David Faure On June 28, 2014, 2:09 a.m.,

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

tps://git.reviewboard.kde.org/r/118954/#comment42621> remove the space before '(' - David Faure On June 28, 2014, 11:32 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

g/r/118954/#comment42724> Wait, what if url isn't a local file, but a remote one? This is missing a if (url.isLocalFile()) check. (same in krun, same in the forwardports to framework) - David Faure On June 29, 2014, 4:06 p.m., Dawit Alem

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

during the port. - David Faure On July 5, 2014, 1:26 p.m., Eike Hein wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: code guideline

avoid the use of exception handling. I hate debugging uncaught exceptions, no way to get a backtrace of where the exception was thrown. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

d shows red - please fix) - David Faure On June 29, 2014, 3:04 p.m., Simon Bachmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: code guideline

On Wednesday 09 July 2014 10:23:59 Kevin Ottens wrote: > On Wednesday 09 July 2014 10:15:03 David Faure wrote: > > On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > > > Dear all, is there any code guideline that recommends developers to > > > avoid > >

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

er of taste (-1 looks hackish to me -- but indeed it's documented as a way to ensure no current index). So, no veto. - David Faure On July 6, 2014, 10:28 a.m., Andrea Iacovitti wrote: > > --- > This is an automatically generat

Re: Review Request 114484: Fix KMainWindow size management, esp. on asymmetric multiscreens

key. - David Faure On Dec. 16, 2013, 1:57 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: QDialog on stack+exec and dbus quit crash is no more

On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: >

Re: Review Request 119211: Queue CMD_REPARSECONFIGRATION requests for suspended ioslaves

on hold, will anything else get through? IOW should the test just be extended with "|| suspended", no test on cmd? - David Faure On July 10, 2014, 12:04 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically g

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

frameworks/kwindowsystem/src/kwindowinfo_mac.cpp - David Faure On July 12, 2014, 6:17 p.m., Marko Käning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

instead: m_startDir = newUrl; m_startDir.setPath(m_startDir.directory()); and when you later port this to Qt5/KF5: m_startDir = newUrl.adjusted(QUrl::RemoveFilename); - David Faure On June 29, 2014, 3:04 p.m., Simon Bachmann wrote: > > --

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

> On July 9, 2014, 8:40 a.m., David Faure wrote: > > Looks good, but I'd feel safer if the unittest > > (kio/tests/kurlrequestertest.cpp) was: > > 1) checked for no regressions, and > > 2) extended to cover the case of relative paths, and other things this

Re: Review Request 119221: Don't rewrite mailto: URLs als mailto://

= 0 in KUrl::url(). - David Faure On July 14, 2014, 4:47 p.m., Felix Geyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 28, 2014, 12:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been teste

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

ey will communicate. See kdeui/util/kcrash.cpp line > > 637. There must be a better way to program this... > > > > That is why I would like to see some KDE core developers reviewing this > > code. I am not a KDE core developer. > > David Faure wrote: >

Re: Proposal to improving KDE Software Repository Organization

vison concept won't work out well if we can't find proper names for the "divisions", because then people will keep getting confused about what's in them. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Proposal to improving KDE Software Repository Organization

sma5. This makes a lot more sense, and leads to understandable naming, I like it :) I assume a future kdesrc-buildrc will look like a selection of *one or many* divisions, with a track for each one, then. All sounds very good, +1. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 119868: KConfig add DirectoryType support

/kdesktopfile.h <https://git.reviewboard.kde.org/r/119868/#comment45381> wheter -> whether an -> a src/core/kdesktopfile.h <https://git.reviewboard.kde.org/r/119868/#comment45382> @since 5.2 - David Faure On Aug. 20, 2014, 1

Re: Review Request 119869: KIO: Correctly handle .directory files

tps://git.reviewboard.kde.org/r/119869/#comment45428> QLatin1String is sufficient, for comparisons - David Faure On Aug. 21, 2014, 1:15 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply,

KDE Frameworks 5.2.0 release

for relative libexec dir. ### Frameworkintegration * the file dialog now remembers its size correctly, and works better with remote URLs. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

workaround for something that should be fixed anyway, but I have no objections to this going in; one step at a time. - David Faure On Sept. 15, 2014, 1:59 a.m., Ian Wadham wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

http://www.davidfaure.fr/2014/copyjob.cpp.diff - David Faure On Sept. 13, 2014, 12:38 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

|| itemInfo.isWritable()) { ... Does this work? In that case, feel free to ship it :-) lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment46335> not path(), but toLocalFile() - David Faure On July 22, 2

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

get rid of the fsType checks? - David Faure On Sept. 17, 2014, 12:55 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

> On Sept. 17, 2014, 7:39 p.m., David Faure wrote: > > Interesting, didn't know about this posix restriction (a bit inconsistent > > imho, the readonly dir vs readonly file difference). > > Thomas Lübking wrote: > The ro flag only guarantees integrity, not pres

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review67082 --- Ship it! Ship It! - David Faure On Sept. 19, 2014, 11:56

Re: Review Request 120341: [kde-baseapps] Fix knewmenu ? knewfilemenu include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120341/#review67316 --- Ship it! Ship It! - David Faure On Sept. 23, 2014, 8:48

KF 5.3.0 changelog

kintegration * Fixed for compilation with Qt 5.4 * Fixed a few standard shortcuts -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF 5.3.0 changelog

n number, and inserts the changelog in the middle. > What do you think about the working we use in 4.x ? I now improved the announcement page, see https://www.kde.org/announcements/kde-frameworks-5.3.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

pp <https://git.reviewboard.kde.org/r/120573/#comment47684> same kioslave/trash/trashimpl.cpp <https://git.reviewboard.kde.org/r/120573/#comment47685> such a debug statement is more useful if it prints out the input to the method, i.e. "topdir". - David Faure On Oct. 1

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

gt; This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120573/ > --- > > (Updated Oct. 14, 2014, 11:59 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Runtime and David Faure. > > > Repository: kde-runtime > > >

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 9:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 854 > > <https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line854> > > > > deleteEmptyTrashInfraStructure is implemented on all OSes, but only >

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

/trashimpl.cpp <https://git.reviewboard.kde.org/r/120573/#comment47851> Eek, a C cast. My eyes bleed. Anyhow you can remove completely, with my above suggestion. kioslave/trash/trashimpl.cpp <https://git.reviewboard.kde.org/r/120573/#comment47854> Why not QFileInfo(trashDir

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

). Is that because it moved to another module? Makes reviewing a bit harder (though not impossible). - David Faure On Oct. 13, 2014, 1:35 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On oct. 18, 2014, 9:28 matin, David Faure wrote: > > Almost there :-) > > > > Re your earlier comments: > > - trashimpl.h is completely internal to the kioslave, adding methods there > > is no problem > > - trashForMountPoint is called when

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

ard.kde.org/r/120573/#comment47872> You can't do that. I'm surprised it doesn't crash for you, actually. encodeName returns a QByteArray. If you only store a char*, the bytearray goes out of scope and you're looking at deleted memor

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

by changes made meanwhile in libkonq). Sorry about this - between the todos, the unittest failures, and the evolving underlying code base, this fell through. - David Faure On June 17, 2014, 4 p.m., Emmanuel Pescosta wrote: > > ---

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

I'll commit this. - David Faure On Aug. 1, 2014, 7:39 p.m., Simon Bachmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

r and update startdir for autocompletion" code path for the case of the directory-selection dialog (KUrlRequester::KUrlRequesterPrivate::_k_slotOpenDialog, see emit m_parent->urlSelected line, just like the other one where you added code -> that code should be factorized) - David Fa

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

robably be not too bad. Alternatively, move the QFile+QTextStream code to a helper function and call it in each of the two cases (local or remote) separately. Would be better for performance. - David Faure On Oct. 13, 2014, 1:35 p.m., Emmanuel Pescosta wrote: > > --

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

> On Oct. 19, 2014, 11:28 p.m., David Faure wrote: > > filenamesearch/kio_filenamesearch.cpp, line 135 > > <https://git.reviewboard.kde.org/r/120460/diff/1/?file=316056#file316056line135> > > > > Wow, won't this be really slow? which "remote&quo

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/#review68746 --- Ship it! Ship It! - David Faure On Oct. 20, 2014, 8:35

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

ogle.com But I agree that for other types of apps it might not. > It sends > mistyped file names out as DNS lookups, which can even be argued to be a > security issue. The usual security vs convenience debate > I definitely recommend passing the third QUrl::AssumeLocalFile a

Re: Review Request 115250: Try PASV mode when using Socks proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115250/#review69217 --- Why wasn't this committed? - David Faure On Jan. 23,

Re: Review Request 101850: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

? - David Faure On July 4, 2011, 11:44 p.m., Marcel Partap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115250: Try PASV mode when using Socks proxy

> On Oct. 27, 2014, 8:42 p.m., David Faure wrote: > > Why wasn't this committed? > > Emil Sedgh wrote: > I would commit it now, but I'm not sure where should I commit this. > Is kdelibs/master frozen? Should I commit this to KIO framework now? You can

Re: Review Request 120782: Allow stand-alone build of konqueror

g/r/120782/#comment48390> forgot to git add that file? - David Faure On Oct. 24, 2014, 3:12 p.m., Dan Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: KIO slaves: fuse moutned remote filesystems treated as local filesystems.

do that, hence the problem you're seeing. Solution: ideally, this should be done delayed too. For instance by moving the feature to KFileItem so that it's also done delayed when m_delayedMimeTypes is true. Problem (ii) is solved (well improved) in Qt5 where "magic determination" only reads the first 16 KB of the file. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 103815: Add yet another code generation option for having invokable methods

adding a unittest? The unittest framework is in place, so this should be very easy... - David Faure On Jan. 28, 2012, 8:39 p.m., Laszlo Papp wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Ksshaskpass ?

on other platforms besides plasma, but it > saves passwords in kwallet, so may make the most sense there. Yep, sounds like a workspace component to me. It doesn't make sense when using a single KDE app in e.g. gnome, which surely has another GUI for ssh-add. -- David Faure, fa...@kde.or

KDE Frameworks 5.4.0 released

ol and ecm_add_qtwayland_server_protocol Frameworkintegration implement support for setting custom labels in file dialogs http://kde.org/announcements/kde-frameworks-5.4.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

y both see the QList (whose toSet method requires a qHash implementation) lib/konq/src/konq_historyentry.h <https://git.reviewboard.kde.org/r/121080/#comment49092> const ref, no? - David Faure On Nov. 8, 2014, 10:26 p.m., Andrius da

Re: Review Request 121134: make KGlobal reference counting threadsafe

Would s_allowQuit.load() compile? I forgot the Qt4 API since it changed in Qt5. It would be slightly better imho, for readability. - David Faure On Nov. 16, 2014, 8:22 p.m., René J.V. Bertin wrote: > > --- > This

Re: Review Request 121134: make KGlobal reference counting threadsafe

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121134/ > --- > > (Updated Nov. 16, 2014, 8:22 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs and David

Re: Review Request 121134: make KGlobal reference counting threadsafe

a local mutex - or define who's in position to write this ("the one > deciding whether or not it can be quit by the reference counter") > > David Faure wrote: > A local mutex around that one line would be completely pointless. The > effect will be exactly the same: n

Re: Review Request 121134: make KGlobal reference counting threadsafe

a local mutex - or define who's in position to write this ("the one > deciding whether or not it can be quit by the reference counter") > > David Faure wrote: > A local mutex around that one line would be completely pointless. The > effect will be exactly the same: n

Re: Review Request 120154: Equal entries implies existing directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120154/#review70819 --- Ship it! Ship It! - David Faure On Sept. 12, 2014, 7:25

Re: Review Request 120154: Equal entries implies existing directory

m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > --- > > Equal entries implies existing directory > > > Diffs > - > > kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/#review71449 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:18

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121248/#review72235 --- Ship it! Ship It! - David Faure On Dec. 12, 2014, 12:17

Re: Review Request 121079: Fix building dolphin tests on MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review72341 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:26

Re: Review Request 121081: QT_WA

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/#review72633 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:27

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could

Re: Review Request 121746: avoid wrong trash size calculation when removing file from trash and cached size info is wrong

ranch Applications/14.12 has my rewrite of this code to use the cache as per the trash spec v1.0, replacing the KConfig-based code. It solves that issue. See commit 591acfe8f5e281f416ee925e1ff160c0aac81163 in kde-runtime.git. - David Faure On Dec. 29, 2014, 10:43 p.m., Martin Koller

Re: Review Request 121746: avoid wrong trash size calculation when removing file from trash and cached size info is wrong

> On Dec. 29, 2014, 10:49 p.m., David Faure wrote: > > I'm confused. Are you patching old code? > > > > kde-runtime branch Applications/14.12 has my rewrite of this code to use > > the cache as per the trash spec v1.0, replacing the KConfig-based code. > &

KDE Frameworks 5.6.0 released

hing for version 1 of a library doesn't give you version 2, for example. Fix ECMQueryQmake when Qt5Core is missing. Frameworkintegration Fix handling of palette change events (bug 336813) http://kde.org/announcements/kde-frameworks-5.6.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 19, 2014, 8:25 a.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 870 > > <https://git.reviewboard.kde.org/r/120573/diff/9/?file=320645#file320645line870> > > > > Should be const QString &mountPoint, you're not modifying it. &g

<    1   2   3   4   5   6   7   8   9   10   >