Re: Review Request 111238: Remove .end() calls from iteration loops in KDirLister

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111238/#review35049 --- patch missing? - David Faure On June 25, 2013, 12:25 p.m

Re: startkde modifies PATH to add qt4 bin dir to the front

Le mardi 25 juin 2013 20:25:10 Albert Astals Cid a écrit : > El Dimarts, 18 de juny de 2013, a les 19:19:24, Albert Astals Cid va escriure: > > El Dimarts, 18 de juny de 2013, a les 09:55:23, David Faure va escriure: > > > Le lundi 17 juin 2013 20:15:23 Albert Astals Cid a écr

Re: Review Request 111238: Remove .end() calls from iteration loops in KDirLister

gigantic merge conflict for me in frameworks... is that really worth it? I think it would be better to make such cleanups in frameworks directly. - David Faure On June 26, 2013, 4:44 a.m., Dawit Alemayehu wrote: > > --- > T

Re: Review Request 110459: Klipper: Allow to keep items in clipboard history

> On June 26, 2013, 7:55 p.m., Lamarque Souza wrote: > > klipper/historyitem.h, line 69 > > > > > > add const before "bool", like this: > > > > setKeep(const bool keep) That's rather unusual (check all of

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

es to avoid calling kio_file Ouch, that might kill this idea completely, in fact]. Well, food for thought, then. - David Faure On June 28, 2013, 9:28 a.m., Róbert Szókovács wrote: > > --- > This is an automatically generated e-

Re: Review Request 111050: Fast mime detection speedup.

estion is whether it is, indeed, without regressions. - David Faure On June 23, 2013, 9:21 p.m., Mark Gaiser wrote: > > --- > This is an automatically generated e-mail. To reply

Re: kentrymaptest broken in master

estRepor > t/%28root%29/TestSuite/kentrymaptest/ > > Can anyone have a look at if we either have to fix the test or the code? Fixed, thanks for the notification. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

e can "kmail %U" (directly or via a .desktop file), or we can't, but we certainly shouldn't take any existing .desktop file with any sort of stuff in the Exec line. - David Faure On June 27, 2013, 1:05 p.m., Dawit Alemayehu wrote: > > ---

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

penwithdialog.cpp <http://git.reviewboard.kde.org/r/111272/#comment25944> this comment should move with the code that it affected - David Faure On July 2, 2013, 2:41 a.m., Dawit Alemayehu wrote: > > --- >

Re: Review Request 111345: KParts::StatusBarExtension: Remember activated state

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/#review35426 --- Ship it! Makes sense. - David Faure On July 1, 2013, 4:01

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/#review35490 --- Ship it! - David Faure On July 3, 2013, 2:22 a.m., Dawit

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

> On July 2, 2013, 7:48 a.m., David Faure wrote: > > kdecore/services/kservice.h, line 82 > > <http://git.reviewboard.kde.org/r/111272/diff/2/?file=167013#file167013line82> > > > > How about a setExec() method rather than a special constructor? This >

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

oard.kde.org/r/111335/#comment26146> Please don't put this code in scheduler.cpp I'm trying to properly split core and gui aspects of KIO in frameworks, and scheduler is definitely core, while kmessagebox is definitely not. Please find a way to separate the two.

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

x27;t catch the error with ~ or ~user. (I don't mean testing the case where the home dir is empty, I only mean the normal case, which you say was going into an error path). - David Faure On July 4, 2013, 6:32 p.m., Jonathan Ma

Re: Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

0", that's for sure :) - David Faure On July 5, 2013, 2:59 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

org/r/71/#comment26153> Did you mean ::Window, or something rather related to text? The line before seems wrong too ("window background"). kdeui/util/kglobalsettings.h <http://git.reviewboard.kde.org/r/71/#comment26152> s/background/text/ ? - David Faur

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

quot;active" in the docu to differenciate the two. - David Faure On July 5, 2013, 4:46 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > <http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766> > > > > Please don't put this code in scheduler.cpp > > > > I&

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

> On July 5, 2013, 2:27 p.m., David Faure wrote: > > Sounds like the unittest is incomplete then, if it didn't catch the error > > with ~ or ~user. > > > > > > (I don't mean testing the case where the home dir is empty, I only mean the > > n

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > <http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766> > > > > Please don't put this code in scheduler.cpp > > > > I&

Re: Review Request 111419: Use case-insensitive URL scheme comparisons in KUrl::isLocalFile

this too), so I'll revert this after merging to frameworks. - David Faure On July 6, 2013, 4:55 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > <http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766> > > > > Please don't put this code in scheduler.cpp > > > > I&

Re: kdeinit vs. link order

se other processes than kwin shouldn't get this env var? Then the alternative is to add that to ksmserver, it's the one that starts kwin actually (startkde -> ksmserver -> kwin, where "->" means "starts (via kdeinit)") -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111462: Prevent a flood of file dirty signals from causing tons of stat calls in KDirLister

notified anymore that his download is going well and the local file is growing? I don't think this is a good compromise at all. How is 2 stat calls per second "a flood" ? (I'm thinking of the use case of downloading one very big file; copying tons of small files is a different i

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

a method that does nothing. - David Faure On July 1, 2013, 10:55 a.m., Róbert Szókovács wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > <http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766> > > > > Please don't put this code in scheduler.cpp > > > > I&

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

about moving the method from SimpleJob to SimpleJobPrivate? And marking the job uidelegate one as internal? - David Faure On July 11, 2013, 11:37 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

e all-inline in the header. Why not put the implementation in the .cpp file, where people will be looking for it? kio/kio/slaveinterface.h <http://git.reviewboard.kde.org/r/111335/#comment26581> const int -> int - David Faure On July 13

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/#review35913 --- Ship it! Perfect, thanks :-) - David Faure On July 13

Re: KDE/4.11 branched what to do with kde-workspace?

ly ones who have to switch to another branch is the people switching to a qt5/frameworks based development, and these people have a lot more setup to do anyway, the "git checkout frameworks" is 1% of it all. Please, pretty please, minimize disruption. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Releases in 3 months

arguments from the same person in both threads ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

just sitting there that you can’t touch which causes even > more confusion than the alternatives; not even rebasing could help us even > if git.kde.org allowed it. If you don't want to merge, then a forced push would still be a better alternative IMHO, in the future when we want to switch 'master' to mean qt5/kf5 everywhere. Disruption on one particular day only for all of KDE SC, rather than progressive disruption in one module after the other, month after month, for the next 2 years. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

ically change the meaning of "master" (especially when there seems to be consensus on "master should be stable" (i.e. useable for daily work)). I think this is less optimal, but I'm willing to accept it as a compromise. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Proposal for branching policy towards KF5

4.11.x with increasing values of x. Maintainance mode, much like KDE 3.5.x went. If everything works ok, we could switch kdelibs to that too, as was originally the plan. (*) kde-workspace, plasma-frameworks, please complete this list if there are more. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

t, but I don't know what UpdateContent does yet :). - David Faure On July 19, 2013, 1:17 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

> http://git.reviewboard.kde.org/r/111585/ > --- > > (Updated July 20, 2013, 2:06 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > --- > > The attached patch fixes a bug where the contents of the clipboard are > prematurely updated dur

Re: Supported Compilers / C++11 Support in KF5

time check and then just define > override to empty. Not needed. Q_DECL_OVERRIDE already does the right thing. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

could change the clipboard, and then if it's totally unrelated, KIO shouldn't touch it. Got it. Thanks for your patience :-) - David Faure On July 21, 2013, 6:05 a.m., Dawit Alemayehu wrote: > > --- > This is an automa

Re: Review Request 111462: Avoid unnecessary stat of destination directory during copy/move in KDirWatch

ole function? I think you'll have to save the old value before the e->dirty=true statement, and test it near your new code. Looks good otherwise. - David Faure On July 14, 2013, 11:57 p.m., Dawit Alemayehu wrote: > > ---

Re: Review Request 111462: Avoid unnecessary stat of destination directory during copy/move in KDirWatch

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111462/#review36335 --- Ship it! Ship It! - David Faure On July 23, 2013, 3:47 a.m

Re: Proposal for branching policy towards KF5

sadmins to add that). I didn't understand that. To add what? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: release schedule BoF

> tsdgeos: > can someone please kick kdelibs people to fix the tests Hmm? http://build.kde.org/job/kdelibs_stable/ is very green. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

kdelibs unittests

On Tuesday 23 July 2013 17:48:25 Vadim Zhukov wrote: > 2013/7/23 David Faure : > >> tsdgeos: > >> can someone please kick kdelibs people to fix the tests > > > > Hmm? > > http://build.kde.org/job/kdelibs_stable/ is very green. > > Altough this g

Re: Proposal for branching policy towards KF5

On Saturday 20 July 2013 13:28:47 Ben Cooksley wrote: > I'd also be inclined to think of kde-runtime as part of kdelibs, > rather than the workspace Yes, that is very true. Especially since the plan for most of kde-runtime is to fold it into the relevant frameworks, IIRC. -- Davi

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

.kde.org/r/111585/#comment26797> Try with QVERIFY(job->exec()), while you're here. synchronousRun is older and should be deprecated at some point, I think. - David Faure On July 19, 2013, 11:56 p.m., Dawit Alemayehu wrote: > > --

Re: Proposal for branching policy towards KF5

On Wednesday 24 July 2013 10:23:46 Michael Pyne wrote: > On Tue, July 23, 2013 14:20:39 David Faure wrote: > > On Saturday 20 July 2013 23:04:10 Michael Pyne wrote: > > > This is a labor-intensive task, but it's easy to centrally-manage > > > without > > >

Re: KDirWatch bug and the analysis. Help is welcome!

x this by filtering out hidden files ("dot files") in the KDirWatch inotify event handling, optionally. (since this depends on whether the kdirlister is showing hidden files or not). But with care in case multiple kdirwatch clients specify a different value for the "notify for h

Re: KDirWatch bug and the analysis. Help is welcome!

On Thursday 01 August 2013 15:06:05 Mark wrote: > On Thu, Aug 1, 2013 at 10:41 AM, David Faure wrote: > > On Thursday 01 August 2013 01:30:08 Mark wrote: > >> However, we have been given the power of inotify which gives more > >> detailed > >> signals an

Re: KDirWatch bug and the analysis. Help is welcome!

On Thursday 01 August 2013 21:24:19 Rolf Eike Beer wrote: > David Faure wrote: > > On Thursday 01 August 2013 01:30:08 Mark wrote: > > > However, we have been given the power of inotify which gives more > > > detailed > > > signals and lets us know which fi

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

d.kde.org/r/111776/#comment27285> QVERIFY(a == b) should always be QCOMPARE(a, b) instead, so that the value of "a" can be seen in case of a failure - David Faure On Aug. 2, 2013, 12:37 p.m., Dawit Alemayehu wrote: > > --- &g

Re: KDirWatch bug and the analysis. Help is welcome!

the inotify events, but that's not what we do anyway. > This will obviously not prevent every case. If a file got added or > removed just after the 100ms trigger then you'd end up with the same > signals as in the above example. But it has the potential to prevent > signals from being send for small file changes. This isn't about a recurring timer, but a single-shot timer after the first event. So as long as the overall operation takes less 100ms the compression will happen. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

> On Aug. 2, 2013, 12:53 p.m., David Faure wrote: > > kio/kio/clipboardupdater.cpp, line 108 > > <http://git.reviewboard.kde.org/r/111776/diff/2/?file=175012#file175012line108> > > > > The name sounds like it will clear the clipboard. > > > >

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

urn comment(). kdecore/services/kmimetype.cpp <http://git.reviewboard.kde.org/r/111852/#comment27333> So this should just be return patterns(); instead. - David Faure On Aug. 3, 2013, 11:31 a.m., David Narváez wrote: > >

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

u copied the way comment() works, but it's different because there's a KServiceTypePrivate::comment(). - David Faure On Aug. 5, 2013, 1:38 a.m., David Narváez wrote: > > --- > This is an automatically genera

Re: Review Request 111883: Fix runtime regression caused by the fix for #134960

GUI changes to the unittests. - David Faure On Aug. 5, 2013, 6:46 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.k

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

ttp://git.reviewboard.kde.org/r/111852/#comment27490> Ah, I see. OK. But then remove the "virtual", this method has no reason to be virtual. Then you can commit. Thanks! - David Faure On Aug. 5, 2013, 1:38 a.m., David Narváez wrote: > > ---

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

of an output parameter... this makes for a pretty weird API. How about moving this to a different method instead, and calling that other method only from the inotify code? That would be much more readable than trying to fit a square peg into a round hole :) - David Faure On

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37241 --- Ship it! Ship It! - David Faure On Aug. 6, 2013, 7:46 p.m

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

> On Aug. 6, 2013, 10:01 p.m., David Faure wrote: > > Ship It! > > Mark Gaiser wrote: > Thank you very much for the ship it! Since the release is _very_ close i > will ask the release team for permission on this one as well. Otherwise i > probably push it after th

Re: Review Request 112042: Fix for Konqueror crash when adding/importing bookmarks

d, at least? - David Faure On Aug. 16, 2013, 1:06 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

sure. Please investigate porting some kde4 apps from createGUI to setupGUI to see what's actually involved in that. - David Faure On Aug. 18, 2013, 2:15 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generat

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

> On Aug. 19, 2013, 5:06 p.m., David Faure wrote: > > This patch looks OK. > > > > Deprecating it, I'm not sure. Please investigate porting some kde4 apps > > from createGUI to setupGUI to see what's actually involved in that. > > Albert Astals Cid

Re: Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

you know that isFile() returned false already. IMHO just else if (S_ISDIR(buff.st_mode)) would be simpler and easier to read. (and folding isFile, too) But anyway, QFileInfo can do the job just fine IMHO. - David Faure On Aug. 20, 2013, 1:22 p.m.,

Re: Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

much prefer the second version of the patch. Many thanks for your bugfixes! - David Faure On Aug. 21, 2013, 5:20 a.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: kio and KDirNotify for remote protocols

> URL bar, the view will not be reloaded. I don't really follow this one. The URLs have to match as you noted. Maybe your kioslaves can register the URLs being used, so that the kdirnotify signals use the right URLs? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Update on git repository "logical" branch module groups

de repo but I think I'm asking for the impossible, since the above definition cannot be related to kde_projects.xml modules, right? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: kio and KDirNotify for remote protocols

On Wednesday 21 August 2013 22:47:58 Sven Brauch wrote: > Hi! > > On Wednesday 21 August 2013 22:37:31 David Faure wrote: > > No, which is why people typically create a kded module for the purpose of > > such always-running watching and notifying. > > Ok, then this is

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

must be a typo. I assume the unittest from commit 8718a still works with this fix? It would be good to unittest this fix too, to ensure no regressions. I see that kde-runtime/keditfiletype/tests/ still passes, so if I broke something, we need to extend that test... - David Faure On Aug. 9

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

org/r/111951/#comment28322> If there's no need for the method, the patch should remove it (it was only called from here, as one can see in 8718) - David Faure On Aug. 9, 2013, 12:22 p.m., Mathias Tillman wrote: > > ---

<    7   8   9   10   11   12