Re: Review Request 108471: return icon for helper type protocol

, for future maintainance. Let's extract it. Can you test if this works for you? http://www.davidfaure.fr/2013/kprotocolinfo.diff - David Faure On Jan. 18, 2013, 1:29 p.m., Reza Shah wrote: > > --- > This is an automatically g

[kdelibs] kdeui/widgets: Performance improvement when inserting 8000 rows into a completion box.

Git commit aa5d8906e121b9aeee6310177e1e941f8f2a44d2 by David Faure. Committed on 25/01/2013 at 16:10. Pushed by dfaure into branch 'master'. Performance improvement when inserting 8000 rows into a completion box. I'm not aware of any KDE app with non-uniform heights in the compl

Re: Review Request 108541: KBugReport should open enter_bug.cgi directly instead of wizard.cgi on bugs.kde.org

978> optinal -> optional - David Faure On Jan. 22, 2013, 11:09 a.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request 108592: Added some more operations in analitza

at the word "analyze" is forbidden because of its first 4 letters? That's a bit of a stretch. Unless "itza" makes for a particularly interesting pun I'm not realizing, I don't see an issue here. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

in slotResult, but would again attempt to remove themselves upon deletion). One could argue that if an app calls kill(Quietly) on a subjob then "it knows what it's doing" and it will make sure that the parent job terminates somewhen ... but then it could also call removeSubjob

Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

code. - David Faure On Feb. 3, 2013, 4:30 a.m., Kevin Kofler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

Q_ASSERT, and then you can even combine the two lines: QVERIFY(compositeJob->addSubjob(job)); - David Faure On Feb. 5, 2013, 3:39 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 108875: Port Sonnet to QPluginLoader

plugins/enchant/CMakeLists.txt <http://git.reviewboard.kde.org/r/108875/#comment20428> you can remove this now, right? - David Faure On Feb. 9, 2013, 5:02 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > T

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107678/#review27083 --- Ship it! +1 for consistency. - David Faure On Dec. 12

Re: Review Request 108875: Port Sonnet to QPluginLoader

<http://git.reviewboard.kde.org/r/108875/#comment20434> remove comment about kservice, or remove kconfig dependency altogether if now unused - David Faure On Feb. 9, 2013, 6:30 p.m., Martin Tobias Holmedahl Sandsmark

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

ttp://git.reviewboard.kde.org/r/108889/#comment20443> For an install prefix in /usr, this would make it /usr/qml ... is this really wanted? Shouldn't this be QT_PLUGIN_INSTALL_DIR/qml, i.e. /usr/lib/plugins/qml ? - David Faure On Feb. 10, 2013, 3:37 p.m., Sebastian K

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

> On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 136 > > <http://git.reviewboard.kde.org/r/108889/diff/1/?file=113440#file113440line136> > > > > For an install prefix in /usr, this would make it /usr/q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

/Frameworks/Building#Runtime_setup But yes, once there's a KDE workspace based on that stuff, we can just set these env vars in startkde. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by BlueSystems and KDAB to work on KDE Frameworks

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27273 --- Ship it! Ship It! - David Faure On Feb. 12, 2013, 4 a.m

Re: Review Request 106771: Make sure KPropertiesDialog inherits all the propertied from the original desktop file when creating a local copy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106771/#review27548 --- Ship it! Ship It! - David Faure On Feb. 12, 2013, 12:43

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

/imload/decoders/gifloader.cpp <http://git.reviewboard.kde.org/r/109478/#comment21779> What's "e" ? an error code? Please rename the variable then, for more readability. - David Faure On March 14, 2013, 8:11 a.m., R

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29177 --- Ship it! As I said, ship it :-) - David Faure On March 14

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

nnet/src/plugins/aspell/kspell_aspellclient.cpp <http://git.reviewboard.kde.org/r/109531/#comment21945> Doesn't the .json file need to exist? Alternatively I think the FILE argument can be empty, iirc. - David Faure On March 16, 2013, 11:16 p.m., Martin Tobia

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

> On March 17, 2013, 11:51 a.m., David Faure wrote: > > staging/sonnet/src/core/client_p.h, line 78 > > <http://git.reviewboard.kde.org/r/109531/diff/1/?file=120139#file120139line78> > > > > Is this used anywhere? Funnily enough, the qobject_cast in

Re: Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

ard.kde.org/r/109233/#comment22093> No, use KGlobal::config() instead, much faster than parsing kdeglobals everytime! - David Faure On March 1, 2013, 5:20 p.m., Pierre Sauter wrote: > > --- > This is an automatically g

Re: KSaveFile, QSaveFile, QFile

ution, this is a WONTFIX for me, unfortunately. [Gotta go, I'll need to look at the other issues later] -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

@SHARE_INSTALL_PREFIX@ instead of `kde4-config --prefix` (including in the existing line of code). startkde.cmake is already pre-processed to replace such vars with their value, which makes this faster at runtime, and removes a dependency on kde4-config (in preparation for KF5). - David Faure On March 23, 2013

Re: KSaveFile, QSaveFile, QFile

On Thursday 21 March 2013 19:02:13 David Faure wrote: > I'm afraid it's one or the other: > * safe code, always a working file available, but hardlinks get splitted up > * possibility to corrupt the existing file, but a backup exists; hardlinks > are kept. OK, bug numbe

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29831 --- Ship it! Ship It! - David Faure On March 24, 2013, 4:31

Re: Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109233/ --- (Updated March 29, 2013, 9:01 a.m.) Status -- This change has been di

Re: Review Request 109923: Make kded use KDE_VERSION_STRING instead of the mysterisou "$Id$" as version.

. With the move to Git, $Id$ should obviously be removed everywhere. - David Faure On April 9, 2013, 2:08 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Results of the freedesktop summit

lly revive the usefulness of the xdg list as the primary point of communication between desktops. Ryan Lortie (Gnome) David Faure (KDE) What it means for KDE Table of contents: 1) Standardized and implemented fdo.Application spec for "unique" applications. 2) Update deskto

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

ore/applicationmodel.cpp <http://git.reviewboard.kde.org/r/109611/#comment23184> Space before and after operators (here and on many other lines). plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <http://git.reviewboard.kde.org/r/109611/#comment23182> Please open your own

desktop file cache (Re: Results of the freedesktop summit)

On Tuesday 16 April 2013 20:12:31 Kevin Krammer wrote: > On Tuesday, 2013-04-16, David Faure wrote: > > 4) Defined standard for .desktop file cache > > > > This is something that I've been wanting for quite some time already: > > replacing the ksycoca cache wit

Re: First draft of a KHumanDateTimeParser class

posite functionality: in the message list it shows "Yesterday", "Monday"... Very simple. No "last" / "next" business :) But well that's easy because it's always only about the past. IMHO KHumanDateTimeParser should avoid "next tuesday" stuff. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 109841: Use https for web shortcuts

to make. So I would suggest reducing the patch to just changing the untranslated key, and letting the rest happen over time. - David Faure On April 3, 2013, 2:59 p.m., Maarten De Meyer wrote: > > --- > This is an automatical

Re: Review Request 110084: Make ftp error messages prettier

good at german (and your "before" screenshot is in german) :-P More seriously I'm not sure this will always work... what if the error message is much longer? Shouldn't it start on its own line so we don't confuse it with the kio_ftp-provided sentence, in general? - D

Re: Review Request 109841: Use https for web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109841/#review31470 --- Ship it! Ship It! - David Faure On April 22, 2013, 7:10

Re: Quotes around the application name in .desktop files

e. the standard way), even when the caption has a space in it, then I'd be glad to see a patch removing all double-quotes from .desktop files. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

untpoint.cpp <http://git.reviewboard.kde.org/r/110225/#comment23609> How can we be sure of that? We could have a mountpoint for /usr and one for /usr/local, so if the path is /usr we could end up here with child=/usr and parent=/usr/local, and the assert will fire. - David Fau

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

in my head. This patch looks good - except that the comment is buggy :) kdecore/io/kmountpoint.cpp <http://git.reviewboard.kde.org/r/110225/#comment23622> Strange comment - it's not. Did you mean "/books" is a child of "/books/", rather? - David Fa

Re: Review Request 109828: Separate configuration from history in Klipper's popup menu

org/r/109828/#comment23724> Remove default value from the implementation (some compilers won't even accept this). klipper/tray.cpp <http://git.reviewboard.kde.org/r/109828/#comment23725> What are the arguments for, if the slot ignores them? - David F

Re: Review Request 110247: New web shortcut. Copy link from clipboard

board is the default value. - David Faure On April 30, 2013, 11:46 a.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request 110259: Fix kurifiltertest to use the new google query

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110259/#review31904 --- Ship it! Ship It! - David Faure On May 1, 2013, 6:41 p.m

Re: Proposed web shortcut changes

mber of KDE users going to DuckDuckGo, KDE e.V. gets between $1 and $2 per month from them :-) But anyway, to set up revenue sharing you'll need to talk to kde-ev-bo...@kde.org, at least to get the banking information where the money should be sent. -- David Faure, fa...@kde.org,

Re: Quotes around the application name in .desktop files

On Wednesday 24 April 2013 09:37:16 Michael Spencer wrote: > On Wednesday, April 24, 2013 09:21:57 AM David Faure wrote: > > If you can test that removing the double-quotes works (including when > > launching from KRun/klauncher, i.e. the standard way), even when the > > capt

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 5, 2013, 8:13 a.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

ttp://git.reviewboard.kde.org/r/108802/#comment23912> There are other ways to bring the context menu than the right button. There's the context key, too. So better watch for the QEvent::ContextMenu event instead of hardcoding "release of right button", if it really has to be

Re: Review Request 110392: Do not overwrite directories inside a tar archive

for it, which I'll commit next. - David Faure On May 11, 2013, 8:43 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: GetHotNewStuff for shortcut schemes

cut scheme that makes it shortcut-compatible with QtCreator (I set it up locally like that), and that shouldn't affect shortcuts in other KDE applications. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

set by the collection when adding the action into it -- which allows for configurable shortcuts. So object names shouldn't change (see also our recent discussion on the viewmode actions in konqueror). - David Faure On May 13, 2013, 1:38 a.m., Dawit Alemayehu wrote: > > ---

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

d. So the QPointer doesn't seem useful to me. - David Faure On May 13, 2013, 1:02 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 110421: Fix Konqueror's midnight commander profile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/#review32492 --- Ship it! Ship It! - David Faure On May 14, 2013, 2:08 a.m

Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

even need reviewing :). I suppose the error was "no write permissions in the directory", it's the most likely one. (partition full would be the other one I can think of) - David Faure On May 18, 2013, 7:43 p.m., Sergio Luis Martins wrote: > > --

Re: Review Request 103555: Fix for stale permissions information in properties dialog

QCOMPARE() so that failures are easier to debug. - David Faure On May 18, 2013, 11:20 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 103555: Fix for stale permissions information in properties dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review32785 --- Ship it! Ship It! - David Faure On May 19, 2013, 2:53 p.m

Re: Review Request 110529: more error handling in KIdleTime

me.cpp <http://git.reviewboard.kde.org/r/110529/#comment24355> space after if (and there's more below) - David Faure On May 20, 2013, 3:25 a.m., Ian Monroe wrote: > > --- > This is an automatically generated

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

model.cpp <http://git.reviewboard.kde.org/r/109611/#comment24597> missing space after "if" plasma/desktop/applets/kickoff/core/applicationmodel.cpp <http://git.reviewboard.kde.org/r/109611/#comment24598> no space between ) and ). - David Faure On May 19,

Re: Review Request 110084: Make ftp error messages prettier

the bug was kind of there already :-) - David Faure On May 7, 2013, 7:48 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109611/#review33281 --- Ship it! Ship It! - David Faure On May 28, 2013, 10:31 a.m

KF5 Update Meeting Minutes 2013-w22

elibs (issue with the cmake file) Next meeting will be Tuesday 4 June. Exact time to be announced later (I won't be available at the usual 4pm CEST). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109611/ --- (Updated May 30, 2013, 9:12 a.m.) Status -- This change has been mark

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109611/ --- (Updated May 30, 2013, 9:12 a.m.) Status -- This change has been mark

Re: Review Request 110785: Changed the kde-open command line help to reflect correct behavior

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110785/#review33624 --- Ship it! Ship It! - David Faure On June 2, 2013, 4:19 p.m

Re: KF5 Update Meeting 2013-w20

d start using ECM, for shared find modules. I wonder how you plan to handle the conflicts between ECM and kdelibs4's cmake modules, though... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Phonon4Qt5 & Phonon5 Branches

t; provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:7 (find_package) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 110799: Remove translation via babelfish - service is no longer avaibable - use google as default

<http://git.reviewboard.kde.org/r/110799/#comment24888> Heh, this .desktop file should probably be renamed, then? - David Faure On June 3, 2013, 3:12 p.m., Burkhard Lück wrote: > > --- > This is an automatically gener

KF5 Update Meeting Minutes 2013-w2

e Tuesday 11 June, 4pm CEST. PS: thanks for changing the title when replying to a specific point. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

ill just grow and grow and grow, in a given process, since you're not removing from it when we navigate away from the directory. Please switch to QCache, so that the size doesn't keep growing indefinitely, but instead the oldest items will be removed when it reaches a certa

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

r_p.h <http://git.reviewboard.kde.org/r/110834/#comment24959> The name gives me another idea, why not store this in DirItem directly? Maybe the info is already there, even. - David Faure On June 7, 2013, 5:03 a.m., Dawit Alemayehu wrote: > > -

Re: Review Request 103168: KConfig: properly implement revertToDefault().

042072a kdecore/config/kconfigini.cpp 6e2021c1d79f14862e1ddbe1cccda6fa6e2121f7 kdecore/tests/kconfigtest.h 3b01c66fd49cda833044dfcb5f2b51c24da7f18b kdecore/tests/kconfigtest.cpp e5d2e80da0685615a0028ccd7254487664ffc6b0 Diff: http://git.reviewboard.kde.org/r/103168/diff/ Testing --- Thanks, David Faure

Re: Review Request 103168: KConfig: properly implement revertToDefault().

8ccd7254487664ffc6b0 Diff: http://git.reviewboard.kde.org/r/103168/diff/ Testing --- Thanks, David Faure

Re: Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

the real-world setup which triggered this bug in the first place (copies of kcmodules in an overlay directory defined in /etc/kde4rc), and translations not appearing in systemsettings when doing that. Thanks, David Faure

Re: Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

sured existing ones pass. Also tested the real-world setup which triggered this bug in the first place (copies of kcmodules in an overlay directory defined in /etc/kde4rc), and translations not appearing in systemsettings when doing that. Thanks, David Faure

Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

d this bug in the first place (copies of kcmodules in an overlay directory defined in /etc/kde4rc), and translations not appearing in systemsettings when doing that. Thanks, David Faure

Re: Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

"trailing spaces" instead of "trailing slash". - David Faure On June 9, 2013, 10:46 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

s better. lib/konq/konq_operations.h <http://git.reviewboard.kde.org/r/110922/#comment25032> This change is BIC. Add the new flag at the end of the list. - David Faure On June 9, 2013, 10 p.m., Emmanuel Pescosta wrote: > >

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

the cache, there's no point in caching it again. itemForUrl(url).isDir()/isFile() should tell you whether a cached item (in itemsInUse or itemsCached) is a directory or a file (or isn't available if both are false due to the item being null). - David Faure On June 8, 2013, 4:16 p

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

> On June 10, 2013, 8:26 a.m., David Faure wrote: > > I don't like the duplication very much (can't the old method call the V2 > > method, if the only difference is the return value, which the old method > > would then ignore?). > > > > Otherwise OK

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/#review34031 --- Ship it! - David Faure On June 10, 2013, 9:22 a.m

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review34065 --- Ship it! Woohoo, much simpler. - David Faure On June 10

Re: Review Request 110944: Send "modified" metaData when moving files through copy()

944/#comment25044> Shouldn't that be m_moveJob? - David Faure On June 10, 2013, 7:45 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 110944: Send "modified" metaData when moving files through copy()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110944/#review34106 --- Ship it! Thanks for the patch! - David Faure On June 10

Re: Review Request 110947: Set the mtime when moving files through sftpCopyGet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110947/#review34109 --- Ship it! - David Faure On June 10, 2013, 10:07 p.m., Dawit

Re: Review Request 110944: Send "modified" metaData when moving files through copy()

d bug 55804 talks about copying too. This is useful when archiving files to SFTP for instance. - David Faure On June 10, 2013, 9:41 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 110964: kioclient: error messages do not identify their source

ttp://git.reviewboard.kde.org/r/110964/#comment25143> The %2/%1 order is a bit surprising, but ok, why not :-) - David Faure On June 12, 2013, 12:15 p.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 111016: Set modified timestamp when moving resource from ftp -> file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111016/#review34338 --- Ship it! Ship It! - David Faure On June 14, 2013, 5:04 a.m

Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

/git.reviewboard.kde.org/r/111000/#comment25272> extra-qualification will break some compilers. This should just be AutoHideMode, no? - David Faure On June 15, 2013, 6:18 p.m., Dominik Haumann wrote: > > --- > This is a

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

I'm not sure why you splitted this into two lines. With QStringBuilder, I assume a+b is faster nowadays. konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/111048/#comment25304> m_autoSavedSessionConfig is unused now, right? Did you forget to remove its d

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

once anyway). kdecore/services/kmimetyperepository.cpp <http://git.reviewboard.kde.org/r/111050/#comment25313> Basically the same as defaultMimeTypePtr(), but with race conditions for lack of the mutex, and without error handling in case the mimetype definitions are not found? For code

Re: startkde modifies PATH to add qt4 bin dir to the front

on. I would agree that setting a correct path for the command line is up to the shell, not to startkde. The question however, is whether any KDE app relies on the PATH containing the Qt-provided executables. David (Jarvie), can you explain if your change was about improving the command line se

Re: Should fast mime detection use a stat call?

ileItem" which knows more about a file instead of a KUrl (QUrl in > kde frameworks). But then again, that requires app side changes... No, just ensure that the calls to KMimeType that you're looking at, get the mode_t from the KFileItem. I.e. don't change KMimeType itself (for that particular issue), change the callers to provide more information, and get more speed out of it. This way, other callers won't break. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Should fast mime detection use a stat call?

ed things up *without* regressions, I see no problems with having it in a 4.11.x bugfix release. But the current patch doesn't really seem to be in that category If there's no way to speed things up without regressions, then yes, it should be discarded. -- David Faure, fa...@kde.

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/#review34548 --- Ship it! Ship It! - David Faure On June 17, 2013, 1:07 p.m

Re: startkde modifies PATH to add qt4 bin dir to the front

e's also a check that the dbus session is available, but surely we'll error out soon enough if this isn't the case? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111145: Execute initModules on recreateDone

f you haven't done so already. - David Faure On June 19, 2013, 10:04 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 110951: Save icon size in the same place other settings are saved

code very much) - David Faure On June 11, 2013, 1:36 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111145: Execute initModules on recreateDone

> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps

Re: Review Request 111145: Execute initModules on recreateDone

> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps

Re: KF5 Update Meeting Minutes 2013-w25

starts his merge > *NOW*, please don't push anything to kdelibs frameworks branch until he > sends a follow up email to notify he's done. Merge done, kdelibs-frameworks is open for business again. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 111115: Handle ramfs mounts correctly so copying files to them works

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/15/#review34806 --- Ship it! Ship It! - David Faure On June 21, 2013, 1:21 a.m

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

happy, go for it :) (yes, make the function file-static first) - David Faure On June 21, 2013, 6:55 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review34949 --- No objections. - David Faure On June 24, 2013, 5:58 a.m

Re: Review Request 111050: Fast mime detection speedup.

x27;t possibly be a speedup :-) In fact I don't see what the parsing of the globs file has to do with checking that the essential mimetypes exist (they typically don't have globs, even). - David Faure On June 2

<    6   7   8   9   10   11   12   >