---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review76201
---
Ship it!
- David Edmundson
On Feb. 15, 2015, 4:35 p.m
>
> Moreover we can't build debugging symbols on most archs due to the enormous
> amount of RAM+swap it involves in the linking process (more than 8GB last
> time
> I checked). This is at least the same as QtWebKit, but seems to be getting
> worse.
>
gold linker seems to handle this a /lot/ better
> We've had it marked as hard requirement for a long time in
> https://techbase.kde.org/Policies/Application_Lifecycle
>
> But it's true that Plasma has been specially good in not following the
> rule.
>
> Plasma is not an application.
David
https://bugs.kde.org/buglist.cgi?list_id=1303835&product=Spectacle
Done.
Repo contains GTK 2 and GTK 3 themes which are similar to Breeze.
The target is to move to kde/workspace for Plasma 5.5.
Full discussion here:
https://forum.kde.org/viewtopic.php?f=285&t=125246&start=60
Most work done by ScionicSpectre and dirruk1.
Things I'm not sure of:
i18n - I've not se
/127073/ ?
- David Edmundson
On Feb. 17, 2016, 4:23 p.m., Daniel Faust wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
(line 554)
<https://git.reviewboard.kde.org/r/127102/#comment63073>
rather than looping, can we use FontMetric's maximumCharacterWidth
* numChars.
Then we could kill sizeHelper competely (FontMetric's didn't exist when
this was written)
- David Edmunds
QtWebkit isn't being developed, but it does still build and work. There's
even a qt5.6 tag in the qtwebkit repo.
>From the Qt5 output
https://build.kde.org/job/qt5%205.6%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/consoleText
it looks like we're not building qtwebkit.
I guess it's no longer
Sorry, I meant we should change the config that calls init-repository, not
init-repository itself.
It's in ci-builder-tools, I've made a patch.
David
From 3cc4c72b70d79b9132e4d7e31b09d5e14d916824 Mon Sep 17 00:00:00 2001
From: David Edmundson
Date: Thu, 21 Apr 2016 17:29:30 +01
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99427
---
Ship it!
Do you have commit access?
- David Edmundson
it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On Jan. 16, 2013, 2:37 p.m., Yichao Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On July 19, 2014, 6:43 p.m., Vadim Zhukov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102571
---
Ship it!
Ship It!
- David Edmundson
On Feb. 7, 2017
Following up from Ben's email where we won't have master of frameworks in
buidling master of Plasma.
> If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines
Hey all,
We'd like to add project plasma-browser-integration into KDE[0].
The goal is to make chrome and firefox integrate better into a Plasma
desktop environment through browser extensions.
How?:
Firefox and chrome (and potentially others) allow plugins to talk to a
native binary host [1]. Thi
>
> What options are possible to distribute extensions via distro packaging?
>
For chrome see https://developer.chrome.com/extensions/external_extensions.
For firefox I was under the impression you can't, but I haven't extensively
looked.
But the easiest thing to do is see how chrome-gnome-shell
Install the host part with the normal cmake && make.
The bit that tries to install into /etc/ does need to go into /etc
Easiest thing then is to then install the extension part from one of the
links in my original email.
>StaticMessages.sh
Didn't know about that, thanks.
I've implemented it, but can only test so much. Can you send me scripty
logs if it fails.
David
> What do you need kdelibs4support for in the qt5 code?
Nothing that couldn't be ported long term, but it does currently use
KMimeData, KStandardDirs and KFileDialog.
On Mon, Jun 19, 2017 at 11:42 PM, Albert Astals Cid wrote:
> El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va
> escriure:
> > QtCurve is now in kdereview with the intention of being in extragear/base
>
> By default it assumes i want a Qt4 build and then fails because i don't
>
-- Forwarded message --
From: "David Edmundson"
Date: 4 Jul 2017 08:23
Subject: Re: kdereview - qtcurve
To: "Albert Astals Cid"
Cc:
> Not fixed for me https://paste.kde.org/pzgvpred2
>
>
Thanks, that was something else.
I've fixed that.
David
Do you know if you can me it be a bit more quiet and only output errors on
> failure?
>
I changed that a few weeks ago, I assume it's fine now?
If there are no complaints I'll move this to Plasma.
On Wed, Jun 21, 2017 at 5:06 PM, Jonathan Riddell wrote:
> On 16 June 2017 at 16:07, Yichao Yu wrote:
> > QtCurve is now in kdereview with the intention of being in extragear/base
>
> You should set the stable branch to 1.9 in repo-metadata and ask
> translator admins to make a stable branch for
> For the record, I also asked Yichao to have a look at a comment one of
our
This issue has been resolved.
At which point, I think we're good to move? Any final objections?
What's the intended destination after review?
David
What would be the situation for releases?
On Sat, Sep 28, 2019 at 3:04 PM Christoph Cullmann
wrote:
>
> Hi,
>
> I just checked again the HIDPI support of Kate/KWrite on Windows and it
> "sucked".
>
> It seems we never properly did setup the stuff to auto-scale, e.g. the
>
> QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, tru
> 2) Protect all branches, aside from a given prefix (proposed to be work/)
Works for me.
Would protection here also cover deletion? If so we need some heads up
notice in Plasma to do a mass move of people's forks.
As a note for reviewers, there are some /very significant/ patches
that are in the merge requests section of that repo. One should review
kio-fuse assuming those are applied.
--
The current bugzilla product says:
"kiofuse: A bridge between KIO and FUSE [Unmaintained]"
It only has one open bug wh
Approved in general, but we will cover that and any ported applets
effectively ported from KDeclarative::Plotter in relevant separate
review processes.
David
> If one restricts oneself to use only libraries part of KDE Frameworks, but not
> from the "Extragear" domain, one should reconsider it, this does not make much
> sense as long one also uses non-KDE-party libraries (which also do not follow
> KF rules).
Plasma effectively has such a rule.
Treati
I updated:
https://community.kde.org/Policies/API_to_Avoid
Which had no mention of this.
David
No, no. Please go the other way round and update the wiki to whatever
working code you have.
David
You're absolutely right that mistakes were made and have reason to be
frustrated.
kde-gtk-config is now maintained by new developers.
Plasma has a new influx of new people which is good to see and
something we need to foster carefully.
Overall these new devs are doing a super job and we want to e
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112326/#review38791
---
Ship it!
Ship It!
- David Edmundson
On Aug. 28, 2013, 11
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112367/#review38893
---
Looks good to me, but someone else should approve.
- David
ere is a new replacement
that it should be ported to.
see
http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat
i.e
#define TRANSLATION_DOMAIN "ksgrd"
#include
- David Edmundson
On Oct. 3, 2013, 5:50 a.
This has been in kdereview for over 3 months now. It is probably safe
to move, though I would still like a reply to my comments
We should not be recommending to packagers to ship code that is in
playground, it defeats the point of the playground separation where a
lot of code is not ship-abble.
D
The whole discussion of whether gnome excludes apps without app-data
will improve the quality of those listed is sort of a moot topic.
We could do with this having this sort of metadata available for all KDE apps;
and in fact we already maintain this sort of data to build the pages
at http://kde.
Spec comments:
- The spec says to link to a .desktop file for the application.
This is typically installed with the application (or it is in KDE apps
anyway), I'm confused as to how this is intended to work.
- I would include project icon and project license in the file format.
Maybe this is link
Attached is an appdata xml file for every kde project.
http://static.davidedmundson.co.uk/kde_appdata.zip (note, I have not
tested these in anything)
and the script to generate it
http://static.davidedmundson.co.uk/appdata_generator.txt
(requires an "svn checkout
svn://anonsvn.kde.org/home/kde/
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114123/#review45305
---
Ship it!
Ship It!
- David Edmundson
On Nov. 25, 2013, 8:45
On 24 Dec 2013 18:57, "Thomas Lübking" wrote:
>
> On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote:
>>
>> On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:
>>>
>>> How does Baloo cooperate with Nepomuk? Note that we have ABI
>>> guarantees, so if the metadata is not shared bet
On Tue, Dec 24, 2013 at 11:32 PM, Thomas Lübking
wrote:
> On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote:
>>
>> On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote:
>
>
> The point is, that you virtually cannot make a release that breaks half the
> former nepomuk clients.
> You
Vishesh,
Review of the folder "core"
itemtype.h is useless.
- it is not namespaced and it doesn't do anything.
datastore.h
- it's public, so should use a d-pointer.
query.cpp
- you don't delete d ?
- there's a few things still TODO
result.h
does it make sense to use Baloo::Item::Id inste
On Wed, Dec 25, 2013 at 10:15 PM, Thomas Lübking
wrote:
> On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote:
>
>> With the planned slow transition of apps from kdelibs4 to frameworks
>> we are going to have a point where we have apps on either side.
>>
On Fri, Jan 10, 2014 at 1:22 PM, Jan Kundrát wrote:
> On Friday, 10 January 2014 11:02:22 CEST, Mario Fux KDE ML wrote:
>>
>> - KPhotoalbum
>
>
> The only reason why KPhotoAlbum links with Nepomuk is because of the rating
> widget ("the five stars in a row") which lives in a Nepomuk-provided
> lib
Code Review of baloo/file/lib
==file.cpp
Should it override type() from Item and set it to "File" ?
==filemodifyjob.cpp.
The code won't unset a rating, comments or tags on multiple files.
You update Xapian ok, but you're not calling fsetxattr().
The d pointer leaks?
==DB.cpp
SQLITE3-> SQLIT
This doesn't need to be be in the first release but I would like an
exposed Qt interface to fsetxattrs and xgetxattrs.
Ideally this would be exposed in the File object, maybe with some sort
of QVariantMap userProperties() method.
FileFetchJob would then load all the properties in the same way
rat
Add COPYING file
ExtractorPluginManager::fetchExtractors seems odd to me.
If it can't find any plugins it searches for all plugins that start
the same prefix.
I assume it's designed so I can have a plugin with the mimetype audio/
that will still match the file mimetype audio/mp3
But this mean
<https://git.reviewboard.kde.org/r/115260/#comment34078>
Use units
plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml
<https://git.reviewboard.kde.org/r/115260/#comment34079>
use parent.height instead of writing 200 again, otherwise it will break
when you update i
There is an existing page about slitting runtime here:
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
linked to from http://community.kde.org/Frameworks/Epics
Alex's wiki page looks far more populated.
We should make sure we avoid wiki duplication.
David
.
The goal is to have a second keyboard that locks the screen. Applications that
monitor activeChanged will be able to tell if the screen was locked
specifically because this second shortcut was pressed as opposed to any other
lock cause.
- David Edmundson
On Jan. 24, 2014, 9:08 a.m., James
typo in your commit message.
Deafult -> Default
Execute the wallet -> Execute the walletManager
- David Edmundson
On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115728/#review49756
---
Ship it!
Ship It!
- David Edmundson
On Feb. 13, 2014, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115726/#review50061
---
Ship it!
- David Edmundson
On Feb. 13, 2014, 5:13 p.m
-desktop.defaultPanel/contents/layout.js
<https://git.reviewboard.kde.org/r/116117/#comment36210>
numberOfPanelsOnScreen might be a clearer variable name, as the number of
panels is clearly panelIds.length
- David Edmundson
On March 1, 2014, 11:47 a.m., Jan Grulich
We can add a CC list to the bugzilla product.
>Pardon my ignorance, but does Gtk impose CSD on all apps, or just
>those apps that opt-in to using it?
GTK apps can opt out (by not using a GTKHeader widget)
I can't imagine the Gimp adopting that design anytime soon. They're
already quite far from Gnome HIG.
I patched GTK here:
https://bugzilla
keeps the URL
scheme.
- David Edmundson
On June 7, 2014, 4:43 p.m., Victor Dodon wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
n 5.x?
- David Edmundson
On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
can't do much without
it. Sorry.
- David Edmundson
On July 29, 2014, 9:43 a.m., TOM Harrison wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
On 12 Sep 2014 22:53, "Marco Martin" wrote:
> On Tuesday, September 9, 2014, Jan Kundrát wrote:
> >
> > If you would like all plasma to go, just give me a list of repos and I
> can make it happen.
>
> No, definitely not yet
>
> >
> > In my opinion, the purpose of this test is not to verify that
http://qt-project.org/doc/qt-5/qwidget.html#windowModified-prop
And then digikam will stop using their own copy?
If so this change makes complete sense to me.
You could also consider making it a framework in the future if you think it
would have wider usage outside kdegraphics apps.
Please make sure to add license headers on all files in libkface before
release. There seem to be a lot missing.
On Sat, Sep 27, 2014 at 1:39 PM, Gilles Caulier
wrote:
> 2014-09-27 12:59 GMT+02:00 David Edmundson :
> > Please make sure to add license headers on all files in libkface before
> > release. There seem to be a lot missing.
>
> Hum, which one ?
>
My bad, the script licens
On Tue, Sep 30, 2014 at 11:38 AM, Gilles Caulier
wrote:
> 2014-09-30 11:28 GMT+02:00 Martin Klapetek :
> > On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier <
> caulier.gil...@gmail.com>
> > wrote:
> >>
> >> 2014-09-30 3:06 GMT+02:00 Vishesh Handa :
> >> > Hey Tobias
> >> >
> >> > Some comments abo
Hey all,
I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now
starting the mandatory review period.
It's a config module for configuring SDDM, the Display Manager. Mostly
themes and autologin, plus some misc options.
The final destination will be workspace.
Application histor
I've fixed almost all the review comments, with the exception of unit
tests as I can't fake getting the list of users, and if I did fake it that
would remove the entire point of what I'm testing.
David
On Thu, Oct 9, 2014 at 12:56 AM, Jeremy Whiting wrote:
> David,
>
> I cloned the git repo here, and built it and installed it next to my
> other kf5 stuff. (The README still mentions kde4-config, that probably
> should be updated btw).
> It runs ok here, but doesn't work :) Maybe I need to symlin
, frankly his opinion outranks everyone
else combined.
- David Edmundson
On Nov. 6, 2014, 9:06 p.m., Thomas Lübking wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.rev
http://projects.bitergia.com/kde/browser/ has stats on regular contributors
vs casual.
I'm not quite sure what those terms actually mean, but it seems very much
like what you might want?
David
I meant to send this message to kde-core-devel, forwarding here.
Sorry if you see this as a duplicate
-- Forwarded message --
From: David Edmundson
Date: Fri, Nov 28, 2014 at 3:19 PM
Subject: Moving polkit-kde-agent-1 to kde/workspace
To: kde-de...@kde.org
Polkit-kde-agent is a
The binary is called kpackagetool. Given the complications we've had with
frameworks co-installability does it make sense to call it kpackagetool5?
The class name in kpackagetool/kpackagetool.cpp should probably be renamed
Documentation at the top of PackageLoader should avoid saying Plasma quit
On Mon, Dec 15, 2014 at 10:25 AM, Marco Martin wrote:
>
> On Thursday 11 December 2014, Kevin Kofler wrote:
> > Marco Martin wrote:
> > > In the past weeks I have been working on a new framework, called
> > > KPackage.
> >
> > You ARE aware that KPackage was the name of an old frontend for RPM and
No objections from me
On Thu, Jan 1, 2015 at 4:50 PM, Albert Astals Cid wrote:
> El Divendres, 19 de desembre de 2014, a les 17:27:01, Jonathan Riddell va
> escriure:
> > Touchpad KCM, ported to KF5 by Rajeesh K Nambiar
> > https://projects.kde.org/projects/playground/utils/kcm-touchpad
>
> This is not a kcm, it's a
On Thu, Jan 1, 2015 at 4:56 PM, Albert Astals Cid wrote:
> El Dimarts, 23 de desembre de 2014, a les 13:17:46, Daniel Vrátil va
> escriure:
> > On Friday, December 19, 2014 06:46:11 PM Luigi Toscano wrote:
> > > Jonathan Riddell ha scritto:
> > > > Plasma 5.2 is due out next month and there's a f
On Thu, Jan 8, 2015 at 5:54 PM, Luigi Toscano
wrote:
> Jonathan Riddell ha scritto:
> > On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote:
> >>Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they
> are
> >>supposed to be frameworks stuff (not sure about baloo) b
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121084/#review73572
---
do you have commit access?
- David Edmundson
On Nov. 9
On Tue, Nov 10, 2020 at 3:21 AM Nicolás Alvarez
wrote:
>
> El lun., 9 de nov. de 2020 a la(s) 13:32, Aleix Pol (aleix...@kde.org)
> escribió:
> > - BasicUsageStatistics
> > Usage time
> > Launches count (Discover)
>
> Is "launches count" reset to 0 after each telemetry submission, or is
> it cumu
>
> It does indeed appear to always be null.
Just to clarify, as this email was intended as a privacy review.
That's a bug that will fail safe with less collected.
Everything looks safe.
David
Ultimately this isn't really dealing with cgroups directly but with
the manager to control them, systemd.
That's correct usage, kernel docs of cgroups say to go via a
controller for write operations. However that at point is it worth
naming the library ksystemd?
It might cause some contention due
On Thu, Dec 3, 2020 at 11:48 AM Kevin Ottens wrote:
>
> Hello,
>
> On Thursday, 3 December 2020 12:15:52 CET David Edmundson wrote:
> > Ultimately this isn't really dealing with cgroups directly but with
> > the manager to control them, systemd.
> >
>
>Doesn't look like translations would work, at least the C++ part, not sure
>about the QML one.
You were right at the time of writing.
I have tested that now both the C++ and QML side have correct
translations loaded with x-test.
David
> > (where 1000 is of course dynamic)
>
> Ditto, what enum names could we give to those?
/ -> All
/system.slice -> System
user.slice/user-1000.slice/user@1000.service -> User
user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps
user.slice/user-1000.slice/user@1000.service/session.sli
I wanted to bump this thread, just so people remember that it is this weekend!
There are many many slots still available.
David
Excellent news!! Thanks very much
> Once the scripts have been proven successfully for Frameworks, we will look
> at extending them to projects that depend only on Frameworks and repositories
Does this mean we would like Plasma to wait a while before merging?
Is it worth us creating the kde-cli
All of
https://invent.kde.org/libraries/kquickchatcomponents/-/blob/master/src/controls/
appear to be missing API docs
David
# Overall:
How is LTR meant to work? You're using it for internal layouting
purposes so any genuine LTR would now be quite broken, I suspect it
will all appear aligned to one side. At a minimum we would need to
inverse the logic inside ChatBubble::tailBase and it needs some
testing
# ChatBubble:
>Did you like it?
When we had an initial influx of reports after you first blogged it
was amazing. We were getting reports in places I hadn't seen before on
bugzilla.
It did a really good job of implicitly showing which things were the
most relevant needing fixing, and what's just noise we can jus
> All in all I am not convinced we still need the sycoca
As you noted it's 3 different things. I suggest we tackle it as 3
different tasks.
The mime apps part we should be able to drop silently without any issue.
The menu and desktop files are still needed by krunner and plasmashell
and xdg-deskt
on this was done last Season of KDE
(http://dot.kde.org/2010/12/29/season-kde-2010) by Yuvraj Tomar. It
would be worth trying to build upon whatever he did, so that we're not
duplicating work. Especially if he has written any useful profiling
tools.
David Edmundson
>
> http://www.kde.org
nds for LightDM has we get a lot of cool stuff and future
proofing. Wayland support is already on the cards, Plymouth integrates
and works. All the little bugs will be fixed before too long, and it
will match KDM in stability/features within a few months. Does KDM
still run the greeters as root?
David Edmundson
>
> David Edmunson should know.
>
> --
> Harald
>
/diff
Testing
---
Thanks,
David Edmundson
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102947/#review7560
---
On Oct. 23, 2011, 10:36 a.m., David Edmundson wrote:
>
> --
2012/2/7 Martin Klapetek :
> On Mon, Feb 6, 2012 at 08:12, Jos Poortvliet wrote:
>>
>> On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote:
>>
>>
>> Heya,
>>
>>
>> Ladies and gents - the reminder I promised to send: this weekend there
>> will be
>> a KDE PIM sprint in Osnabruck. Le
> First of all, the bugzilla is supposed to be a communication tool between the
> user and the developer.
Or is it?
If I understand Martin correctly, he wants bugzilla to be "a list of
things broken in my app", not a communication tool for every user who
wants to say something.
In KDE Telepathy
On Fri, Feb 24, 2012 at 8:44 AM, Andras Mantia wrote:
> On Thursday, February 23, 2012 04:57:16 PM David Edmundson wrote:
>> > First of all, the bugzilla is supposed to be a communication tool between
>> > the user and the developer.
>> Or is it?
>>
>> If
1 - 100 of 148 matches
Mail list logo
