Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Olivier Goffart
Le Wednesday 01 June 2011, Dawit A a écrit : > Isn't this problem easily solvable by changing those slots defined in > Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and > forwarding the call to the existing code ? See attached patch. there could also be a static private schedulerPrivate

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Dawit A
Isn't this problem easily solvable by changing those slots defined in Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and forwarding the call to the existing code ? See attached patch. On Wed, Jun 1, 2011 at 10:47 AM, Jeremy Whiting wrote: > Until those that know the code get this issue

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Jeremy Whiting
Until those that know the code get this issue sorted out, I've pasted a small workaround that gets it to build here: http://paste.kde.org/77059/ Jeremy On Wed, Jun 1, 2011 at 2:39 AM, Thiago Macieira wrote: > On Wednesday, 1 de June de 2011 01:42:13 argonel wrote: > > This makes a promise that

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Thiago Macieira
On Wednesday, 1 de June de 2011 01:42:13 argonel wrote: > This makes a promise that any class can use a private slot without > access checking. It doesn't say how that slot was declared, just that > the private slot can be invoked by any other class. The change to > Q_PRIVATE_SLOT introduces access

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-05-31 Thread argonel
On Mon, Apr 25, 2011 at 6:54 PM, Olivier Goffart wrote: > In this case, we have to see if we can fix it in Qt. I do not see any solution > on top of my head. We have to discuss if it is ok to break this use case if > there is no solution. The Qt documentation, about signals and slots[1] says thi

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-05-16 Thread Jeremy Whiting
Ping, Anyone know who should/can fix this issue? I've got a hack locally, but a proper fix would be very good imho. Jeremy On Fri, Apr 29, 2011 at 12:50 PM, Jeremy Whiting wrote: > > > On Mon, Apr 25, 2011 at 4:54 PM, Olivier Goffart wrote: > >> Le Monday 25 April 2011, Michael Pyne a écrit

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-29 Thread Jeremy Whiting
On Mon, Apr 25, 2011 at 4:54 PM, Olivier Goffart wrote: > Le Monday 25 April 2011, Michael Pyne a écrit : > > On Sunday, April 24, 2011 16:42:22 Christoph Feck wrote: > > > On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > > > > Olivier, these are your moc changes. > > > > > > Given that

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-25 Thread Olivier Goffart
Le Monday 25 April 2011, Michael Pyne a écrit : > On Sunday, April 24, 2011 16:42:22 Christoph Feck wrote: > > On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > > > Olivier, these are your moc changes. > > > > Given that Q_PRIVATE_SLOT is a private definition, shouldn't we rather > > fix t

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Michael Pyne
On Sunday, April 24, 2011 16:42:22 Christoph Feck wrote: > On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > > Olivier, these are your moc changes. > > Given that Q_PRIVATE_SLOT is a private definition, shouldn't we rather fix > the code in KDE? Perhaps, but let's let the developers makin

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Christoph Feck
On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: > On Sunday, 24 de April de 2011 12:53:18 Christoph Feck wrote: > > Hi, > > > > Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE > > with it. It already fails compiling kdelibs/kio/kio/scheduler.cpp > > because of this er

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Thiago Macieira
On Sunday, 24 de April de 2011 12:53:18 Christoph Feck wrote: > Hi, > > Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE with > it. It already fails compiling kdelibs/kio/kio/scheduler.cpp because of > this error: > > /local/build/KDE/libs/kdelibs/kio/scheduler.moc:77:21: error

kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-24 Thread Christoph Feck
Hi, Qt 4.8 has been branched, and (early as I am :) I tried compiling KDE with it. It already fails compiling kdelibs/kio/kio/scheduler.cpp because of this error: /local/build/KDE/libs/kdelibs/kio/scheduler.moc:77:21: error: ‘class KIO::Scheduler’ has no member named ‘schedulerPrivate’ The is