Re: Usefulness of Subject-header of git commit mails

2011-01-31 Thread Johannes Sixt
Am 1/28/2011 17:42, schrieb Andreas Hartmetz: > Semi-OT: What is the empty line good for? > Sometimes I just continue writing if the start of a long first sentence turns > out to be a good summary. No, really, you should make the summary line short (max 75 characters or so), and follow it by a bl

Re: Usefulness of Subject-header of git commit mails

2011-01-28 Thread Parker Coates
On Fri, Jan 28, 2011 at 11:42, Andreas Hartmetz wrote: > On Monday 24 January 2011 00:13:26 Eike Hein wrote: >> >> Yep - for the benefit of those who aren't used to the git >> jargon (sorry for that), in git the convention is to for- >> mat the commit message like this: >> >> >> >> >> >> While d

Re: Usefulness of Subject-header of git commit mails

2011-01-28 Thread Andreas Hartmetz
On Monday 24 January 2011 00:13:26 Eike Hein wrote: > > Yep - for the benefit of those who aren't used to the git > jargon (sorry for that), in git the convention is to for- > mat the commit message like this: > > > > > > While deviating from this format is not particularly harm- > ful, git a

Re: Usefulness of Subject-header of git commit mails

2011-01-24 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > Eike Hein, 23.01.2011: > > > @sysadmins: would it be possible to change the format for some repos or > > > is this not possible? I.e. leave the decision to the project > > > maintainers? > > > > Would you be OK with this hybrid format that we discus

Re: Usefulness of Subject-header of git commit mails

2011-01-24 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > But probably my problem is that I only work on "semi-large" repositories like > KDevelop/KDevplatform/Kate. There I'm interested in *everything* that goes > on. > In Calligra you have only one big repo for all the apps, correct? Here I > indeed

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Tom Albers
- Oorspronkelijk bericht - > On 1/23/2011 9:30 PM, Milian Wolff wrote: > > What was broken? > > Nothing as far as Commitfilter is concerned. Commitfilter actually > acts on the X-Commit-Directories headers, not the mail subject. > This header was actually somewhat broken in the old mails,

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/24/2011 12:03 AM, Allan Sandfeld Jensen wrote: Btw. This sounds like a really good format. Though I assume "commit subject" is still just the first line of the commit message, like it is commonly in git. When you have feature like that, the developers also needs to use that feature, so we ne

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Allan Sandfeld Jensen
On Sunday 23 January 2011, Eike Hein wrote: > > @sysadmins: would it be possible to change the format for some repos or > > is this not possible? I.e. leave the decision to the project > > maintainers? > > Would you be OK with this hybrid format that we discussed a few > days ago: > > [/*] : >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/23/2011 11:32 PM, Milian Wolff wrote: I really hate that noone told me this before. I was not kidding when I said what you quoted above. Noone gave me *any* arguments in favor of the old format, except "it was like that in SVN times". Hence this whole thread (which, btw, I started since your

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Allan Sandfeld Jensen
On Sunday 23 January 2011, Milian Wolff wrote: > c) it's not possible to prioritize commit mails for reviewing. I get tons > every day and often only look at "urgent" mails, where urgent was so far > mostly related to committer + short commit msg. This worked really well, > now I have to look at al

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: > > @sysadmins: would it be possible to change the format for some repos or > > is this not possible? I.e. leave the decision to the project > > maintainers? > > Would you be OK with this hybrid format that we discussed a few > days ago: > > [/*] : > > * branch only shown

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Eike Hein, 23.01.2011: > On 1/23/2011 9:30 PM, Milian Wolff wrote: > > What was broken? > > Nothing as far as Commitfilter is concerned. Commitfilter actually > acts on the X-Commit-Directories headers, not the mail subject. > This header was actually somewhat broken in the old mails, it has > bee

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
@sysadmins: would it be possible to change the format for some repos or is this not possible? I.e. leave the decision to the project maintainers? Would you be OK with this hybrid format that we discussed a few days ago: [/*] : * branch only shown if != master. If we could agree on a hybrid

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Eike Hein
On 1/23/2011 9:30 PM, Milian Wolff wrote: What was broken? Nothing as far as Commitfilter is concerned. Commitfilter actually acts on the X-Commit-Directories headers, not the mail subject. This header was actually somewhat broken in the old mails, it has been fixed now as part of the hooks rew

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Boudewijn Rempt, 23.01.2011: > On Sunday 23 January 2011, Milian Wolff wrote: > > Hey all, > > > > I've brought this discussion to the sysadmins recently and they asked me > > to ask for feedback here. So there it goes: > > > > Recently, the format of the subject of git commit emails was adapted

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Boudewijn Rempt
On Sunday 23 January 2011, Milian Wolff wrote: > Hey all, > > I've brought this discussion to the sysadmins recently and they asked me to > ask for feedback here. So there it goes: > > Recently, the format of the subject of git commit emails was adapted to use > the old SVN format. This sucks i

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Ingo Klöcker
On Sunday 23 January 2011, Milian Wolff wrote: > Stephen Kelly, 23.01.2011: > > FWIW the problem I had with the old git format was that the subject > > was not long enough. I guess pretty=oneline only takes the first > > 72 chars or whatever of the first commit line, but in practice > > people don'

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Stephen Kelly, 23.01.2011: > Thomas Lübking wrote: > > Am Sun, 23 Jan 2011 20:43:42 +0100 > > > > schrieb Milian Wolff : > >> Recently, the format of the subject of git commit emails was adapted > >> to use the old SVN format. This sucks in my opinion and I want to > >> have it changed. > > > > T

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Ivan Čukić, 23.01.2011: > > Example: > > [KDevPlatform] fafd165: Don't completely ignore the retrieved top-context > > For me, this is more useful, so +1 > > Maybe adding a keyword 'commit' before the short hash like this > [KDevPlatform] Commit fafd165: Don't completely ignore the retrieved >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Stephen Kelly
Thomas Lübking wrote: > Am Sun, 23 Jan 2011 20:43:42 +0100 > schrieb Milian Wolff : > >> Recently, the format of the subject of git commit emails was adapted >> to use the old SVN format. This sucks in my opinion and I want to >> have it changed. > > To me, this would be the driving question. >

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Thomas Lübking
Am Sun, 23 Jan 2011 20:43:42 +0100 schrieb Milian Wolff : > Recently, the format of the subject of git commit emails was adapted > to use the old SVN format. This sucks in my opinion and I want to > have it changed. To me, this would be the driving question. *Why* was it changed in the first plac

Re: Usefulness of Subject-header of git commit mails

2011-01-23 Thread Ivan Čukić
> Example: > [KDevPlatform] fafd165: Don't completely ignore the retrieved top-context For me, this is more useful, so +1 Maybe adding a keyword 'commit' before the short hash like this [KDevPlatform] Commit fafd165: Don't completely ignore the retrieved top-context -- Cheerio, Ivan -- Whil

Usefulness of Subject-header of git commit mails

2011-01-23 Thread Milian Wolff
Hey all, I've brought this discussion to the sysadmins recently and they asked me to ask for feedback here. So there it goes: Recently, the format of the subject of git commit emails was adapted to use the old SVN format. This sucks in my opinion and I want to have it changed. First lets expla