On Thu, Oct 9, 2014 at 12:56 AM, Jeremy Whiting wrote:
> David,
>
> I cloned the git repo here, and built it and installed it next to my
> other kf5 stuff. (The README still mentions kde4-config, that probably
> should be updated btw).
> It runs ok here, but doesn't work :) Maybe I need to symlin
I've fixed almost all the review comments, with the exception of unit
tests as I can't fake getting the list of users, and if I did fake it that
would remove the entire point of what I'm testing.
David
Hey David.
None of these are blockers. Just stuff I noticed.
* There is this strange ACKNOWLEDGEMENTS file
* themeconfig.cpp
** The delegate seems to have a fixed size of 128x128. This might not be
ideal for hidpi screens
** ThemeConfig::dump - Extra indendation
* thememodel.cpp - KStandardDirs
David,
I cloned the git repo here, and built it and installed it next to my
other kf5 stuff. (The README still mentions kde4-config, that probably
should be updated btw).
It runs ok here, but doesn't work :) Maybe I need to symlink some auth
file or dbus file or something, but the kcm's save() met
On Mon, Oct 6, 2014 at 11:48 PM, Albert Astals Cid wrote:
> There is no COPYING file (not sure if this one is mandatory or not, ask
> Riddell)
Mandatory it is. At least for just about all GNU licenses as they even
explicitly mention that a full copy needs to accompany the source.
HS
El Dissabte, 4 d'octubre de 2014, a les 22:38:30, David Edmundson va escriure:
> Hey all,
>
> I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now
> starting the mandatory review period.
>
> It's a config module for configuring SDDM, the Display Manager. Mostly
> themes and aut
On Saturday 04 October 2014 22:38:30 David Edmundson wrote:
> Application history:
> - I wrote a KCM for LightDM in Playground
> - This was forked and changed to work on SDDM in Github
> - We switched to SDDM as the recommended DM for Plasma
> - We want a KCM to configure it
> - It's easier (f
Hey all,
I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now
starting the mandatory review period.
It's a config module for configuring SDDM, the Display Manager. Mostly
themes and autologin, plus some misc options.
The final destination will be workspace.
Application histor
