Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2018-02-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Feb. 4, 2018, 3:14 nachm.) Status -- This change has been d

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2018-02-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/#review103862 --- Migrated to Phabricator: https://phabricator.kde.org/D10297

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 1:25 p.m.) Review request for KDE Base Apps, Marti

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Kevin Funk
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > > > > > Why this? > > Gregor Mi wrote: > When I try to capture "d", then I get the following compiler err

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 11:08 a.m.) Review request for KDE Base Apps, Mart

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > > > > > Why this? When I try to capture "d", then I get the following compiler error: processui/ksysguardpro

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > CMakeLists.txt, line 21 > > > > > > libksysguard should not require Plasma, it should stay optional at best. > > > > See one line below in that CMakeLi

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-31 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/#review103512 --- Note: Didn't really check the actual changes in this diff.

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-28 Thread Gregor Mi
> On Sept. 8, 2016, 8:26 a.m., Martin Flöser wrote: > > processui/ksysguardprocesslist.cpp, lines 403-413 > > > > > > KWin does install the dbus xml file. You could use that to generate the > > code through QDbu

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-28 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated July 28, 2017, 12:20 p.m.) Review request for KDE Base Apps, Mar

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2016-09-08 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/#review98998 --- Just as I'd imagined it, +1 from the usability side! - Thoma

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2016-09-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/#review98994 --- processui/ksysguardprocesslist.cpp (line 349)

Review Request 128854: Add a Tools button above the process list of System Monitor

2016-09-07 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas