Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- (Updated Jan. 9, 2015, 3:25 p.m.) Status -- This change has been mar

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73597 --- Ship it! kdecore/util/kshareddatacache_p.h

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- (Updated Jan. 9, 2015, 3:19 p.m.) Review request for KDE Software on Mac

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Ian Wadham
> On Jan. 8, 2015, 6:12 p.m., Milian Wolff wrote: > > personally, I also think that if you tested and it works, and Allan has no > > objections, that you can go ahead and push this. but please don't comment > > out code, just remove it. > > René J.V. Bertin wrote: > OK, will do. > >

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread René J . V . Bertin
> On Jan. 8, 2015, 7:12 p.m., Milian Wolff wrote: > > personally, I also think that if you tested and it works, and Allan has no > > objections, that you can go ahead and push this. but please don't comment > > out code, just remove it. OK, will do. I'll give it a bit more testing, though. Mu

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73521 --- Ship it! personally, I also think that if you tested and it w

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73519 --- No, I can't recall why i did that. You know a lot more about

Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- Review request for KDE Software on Mac OS X, kdelibs and Allen Winter. Re