Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-17 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Ian Wadham
> On Nov. 15, 2014, 2:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Albert Astals Cid
> On nov. 15, 2014, 8:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Thomas Lübking
> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm dire

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Thomas Lübking
> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Ian Wadham
> On Nov. 15, 2014, 2:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Martin Gräßlin
> On Nov. 15, 2014, 3:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Thomas Lübking
> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Thomas Lübking
> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm dire

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120931/#review70399 --- kdeui/windowmanagement/kwindowsystem_mac.cpp

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Thomas Lübking
> On Nov. 15, 2014, 8:41 vorm., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Martin Gräßlin
> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread René J . V . Bertin
> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120931/#review70388 --- As the maintainer of the framework in KF5 I would prefer if th

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120931/ --- (Updated Nov. 15, 2014, 12:04 a.m.) Review request for KDE Software on Ma

Review Request 120931: [OS X] improvements to KWindowSystem

2014-10-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120931/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel