Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 28, 2014, 11:05 p.m., Hrvoje Senjan wrote: > > forward port, for interested ones -> > > https://git.reviewboard.kde.org/r/120876/ Thank you, Hrvoje, you are a gentleman and a scholar... and I am happy to have been able to help... :-) - Ian

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review69367 --- forward port, for interested ones -> https://git.reviewboard.k

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 9, 2014, 11:30 p.m.) Status -- This change has been ma

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68187 --- Ship it! Ship It! - Albert Astals Cid On oct. 9, 2014, 12:

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 9, 2014, 8:06 p.m., Ian Wadham wrote: > > A simplified patch for Dr Konqi went in for review about 20 hours ago. > > There are now about 4 hours till the KDE 4.14.2 deadline and there has been > > no feedback re the new patch, but it does follow previous reviewers' > > suggestions. >

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Okt. 9, 2014, 8:06 nachm., Ian Wadham wrote: > > A simplified patch for Dr Konqi went in for review about 20 hours ago. > > There are now about 4 hours till the KDE 4.14.2 deadline and there has been > > no feedback re the new patch, but it does follow previous reviewers' > > suggestions.

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68183 --- A simplified patch for Dr Konqi went in for review about 20 ho

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > drkonqi/bugzillalib.cpp, line 81 > > > > > > The patch largely consists of hand-crafted version handling. > > > > replacing this by "int version = K

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 9, 2014, 12:06 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Okt. 7, 2014, 1:13 nachm., Thomas Lübking wrote: > > drkonqi/bugzillalib.cpp, line 81 > > > > > > The patch largely consists of hand-crafted version handling. > > > > replacing this by "int version =

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > drkonqi/bugzillalib.cpp, line 81 > > > > > > The patch largely consists of hand-crafted version handling. > > > > replacing this by "int version = K

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > drkonqi/bugzillalib.cpp, line 81 > > > > > > The patch largely consists of hand-crafted version handling. > > > > replacing this by "int version = K

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Okt. 7, 2014, 1:13 nachm., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codeb

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68051 --- My 2¢ Bugzilla will require an update anyway and that means at

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 9:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated oct. 7, 2014, 7:42 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 7, 2014, 6:49 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 7, 2014, 6:31 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Okt. 5, 2014, 7:43 vorm., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 9:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with the codebase of Dr Konqi,

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? Perhaps I am the person most familiar with the codebase of Dr Konqi, having worked on it for a fe

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67955 --- Not familiar with the codebase, sorry - just some codingstyle

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67946 --- As this is needed to restore the functionality of Dr Konqi, ca

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Oct. 5, 2014, 2:06 a.m., Ben Cooksley wrote: > > drkonqi/bugzillalib.cpp, line 161 > > > > > > Perhaps use kWarning() or kDebug() instead? Done. > On Oct. 5, 2014, 2:06 a.m., Ben Cooksley wrote: > > drkon

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 5, 2014, 4:27 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67943 --- drkonqi/bugzillalib.cpp

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 3, 2014, 7:52 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

> On Sept. 30, 2014, 9:22 a.m., Jan Kundrát wrote: > > drkonqi/bugzillalib.h, line 431 > > > > > > These are never saved on disk, right? > > > > I don't think that this makes much sense given that the re

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 3, 2014, 7:03 a.m.) Review request for KDE Software on Mac

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67658 --- drkonqi/bugzillalib.h

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67656 --- Great, it's been ... bugging me that the bug reporter hasn't b

Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- Review request for KDE Software on Mac OS X, KDE Runtime and Ben Cooksley.