Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated Srp. 4, 2014, 12:49 dop.) Status -- This change has been di

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Ben Cooksley
On July 28, 2014, 10:17 a.m., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Martin Klapetek
On July 28, 2014, 12:17 p.m., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated July 28, 2014, 10:21 a.m.) Review request for KDE Frameworks, kd

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63311 --- src/platformtheme/kdeplatformfiledialoghelper.h

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63309 --- +1, looks good to me - Martin Klapetek On July 28, 2014, 11

Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- Review request for kdelibs, Aleix Pol Gonzalez and Martin Klapetek. Repos