Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- (Updated July 16, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 16, 2014, 1:39 p.m., Raphael Kubo da Costa wrote: > > I guess it's important to note that PyKDE is still broken with this change > > -- it also assumes `pyqtconfig.py` exists. Fixing it is probably going to > > be more difficult. I will try to look at it, but I can't guarantee I'll d

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62509 --- I guess it's important to note that PyKDE is still broken with

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62505 --- Ship it! Ship It! - Luca Beltrame On Lug. 16, 2014, 1:21 p

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 4:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- (Updated July 16, 2014, 4:21 p.m.) Review request for kdelibs, Alex Merry

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 4:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62457 --- This is the method used in qscintilla2's configure.py (which u

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62456 --- I think PYQT4_SIP_DIR can still be determined automatically, b

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62435 --- Ship it! +1 on my side, but please wait to what the build sys

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 15, 2014, 9:28 p.m., Luca Beltrame wrote: > > cmake/modules/FindPyQt.py, line 40 > > > > > > If I understand correctly, configuring without -DPYQT4_SIP_DIR > > specified may cause undefined behavior? >

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62432 --- cmake/modules/FindPyQt.py

Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- Review request for Build System, KDE Bindings, kdelibs, Alex Merry, Luca B