Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2015-07-05 Thread Victor Dodon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118604/ --- (Updated Iulie 6, 2015, 12:16 a.m.) Status -- This change has been d

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2015-01-04 Thread Mark Gaiser
> On jun 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remot

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-12-30 Thread Mark Gaiser
> On jun 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remot

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-12-29 Thread David Faure
> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remo

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-14 Thread Mark Gaiser
> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remo

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-14 Thread Mark Gaiser
> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remo

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-14 Thread Mark Gaiser
> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remo

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-14 Thread Mark Gaiser
> On June 14, 2014, 8:54 a.m., David Faure wrote: > > What if the file isn't local? > > > > Sounds to me like the bug is elsewhere. > > > > Of course for local files, showing a local path looks better than a > > file:/// URL, so this could be improved, but in a way that doesn't break > > remo

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118604/#review60070 --- What if the file isn't local? Sounds to me like the bug is el

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-10 Thread Victor Dodon
> On June 10, 2014, 4:40 p.m., David Edmundson wrote: > > .toString() would be better if it still works, as that still keeps the URL > > scheme. In kurl.h it's said that it's forbidden to use toString(), and to use url(), prettyUrl(), or pathOrUrl() instead. But none of them work as expected.

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118604/#review59713 --- .toString() would be better if it still works, as that still k

Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

2014-06-07 Thread Victor Dodon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118604/ --- Review request for kdelibs, Albert Vaca Cintora and Aaron J. Seigo. Bugs: