Re: Review Request 112367: Include the icon's theme in the cache key

2013-10-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- (Updated Oct. 29, 2013, 8:04 a.m.) Status -- This change has been dis

Re: Review Request 112367: Include the icon's theme in the cache key

2013-10-21 Thread Kevin Ottens
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-10-09 Thread Kevin Ottens
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-23 Thread Kevin Ottens
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-02 Thread Àlex Fiestas
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-02 Thread David Faure
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-02 Thread Àlex Fiestas
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-30 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38968 --- Ship it! Well, why not commit it now, and if it ends up slow w

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-30 Thread Àlex Fiestas
> On Aug. 30, 2013, 12:29 a.m., Michael Pyne wrote: > > The change seems reasonable (but keep in mind it makes one of the hottest > > methods in KIconLoader that much slower). > > > > However I thought the KCM for the Desktop Theme Appearance already reset > > the cache as suggested by Aleix.

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38906 --- The change seems reasonable (but keep in mind it makes one of t

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38905 --- Yes it makes sense, although probably we should just nuke the c

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38893 --- Looks good to me, but someone else should approve. - David Edm

Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- Review request for KDE Frameworks, kdelibs and Michael Pyne. Description -