Re: Review Request 112260: Enable Dict DataEngine on KF5

> On Aug. 26, 2013, 11:29 a.m., David Edmundson wrote: > > plasma/generic/dataengines/dict/CMakeLists.txt, line 11 > > > > > > We try to avoid extra whitespace in files. > > You have a blank space after plasma_

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38630 --- This review has been submitted with commit b761d846ac6579a3086

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 12:55 p.m.) Status -- This change has been ma

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38609 --- Ship it! Two minor comments. plasma/generic/dataengines/dict

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38608 --- Ship it! please fix the whitespace and commit. Thanks! plas

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 11:09 a.m.) Review request for kde-workspace. De

Re: Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38600 --- plasma/generic/dataengines/dict/CMakeLists.txt

Review Request 112260: Enable Dict DataEngine on KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- Review request for kde-workspace. Description --- Enable dict DataEng