Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-20 Thread Albert Astals Cid
> On Aug. 19, 2013, 5:06 p.m., David Faure wrote: > > This patch looks OK. > > > > Deprecating it, I'm not sure. Please investigate porting some kde4 apps > > from createGUI to setupGUI to see what's actually involved in that. > > Albert Astals Cid wrote: > This is what is involved. Less c

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-20 Thread David Faure
> On Aug. 19, 2013, 5:06 p.m., David Faure wrote: > > This patch looks OK. > > > > Deprecating it, I'm not sure. Please investigate porting some kde4 apps > > from createGUI to setupGUI to see what's actually involved in that. > > Albert Astals Cid wrote: > This is what is involved. Less c

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/ --- (Updated Aug. 19, 2013, 6:18 p.m.) Status -- This change has been mar

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/#review38165 --- This review has been submitted with commit c75f908c280733e3d12

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread Albert Astals Cid
> On Aug. 19, 2013, 5:06 p.m., David Faure wrote: > > This patch looks OK. > > > > Deprecating it, I'm not sure. Please investigate porting some kde4 apps > > from createGUI to setupGUI to see what's actually involved in that. This is what is involved. Less code, less bugs. http://quickgit.kd

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/#review38159 --- Ship it! This patch looks OK. Deprecating it, I'm not sure. P

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-19 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/#review38157 --- Ship it! Ship It! - Jeremy Paul Whiting On Aug. 18, 2013, 8

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/ --- (Updated Aug. 18, 2013, 2:15 p.m.) Review request for kdelibs and David Fa

Review Request 112144: Smal KXmlGuiWindow documentation improvements

2013-08-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/ --- Review request for kdelibs and David Faure. Description --- Suggest p