Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/#review37860 --- This review has been submitted with commit dc12eba0f02545f6213

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 5:04 p.m.) Status -- This change has been mar

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 7:29 p.m.) Review request for KDE Runtime and Albe

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 7:29 p.m.) Review request for KDE Runtime and Albe

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 5:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 5:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
> On Aug. 15, 2013, 2:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 2:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/#review37845 --- Thanks for the patch! The enum thing seems a bit overkill to m

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 2:07 p.m.) Review request for KDE Runtime and Albe