Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:31 p.m.) Status -- This change has been mar

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37701 --- This review has been submitted with commit 66a27efd6900709b421

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37700 --- Ship it! Ship It! - Sebastian Kügler On Aug. 13, 2013, 3:16

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:16 p.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37698 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:01 p.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37696 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 12:37 p.m.) Review request for kde-workspace and M

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37677 --- Is good. however is not really for master since is about to swi

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37675 --- It's looking good already, a few stylistic remarks inline, and

Re: Review Request 111992: Activity bar in QML.

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41 > > > > > > If you want to optimise, you can make TabBar the root item. > >

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37672 --- Looks good to me. Wait for Marco or Sebas to tell you to Ship i

Re: Review Request 111992: Activity bar in QML.

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41 > > > > > > If you want to optimise, you can make TabBar the root item. > >

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 4:11 a.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 12, 2013, 10:30 a.m.) Review request for kde-workspace and M

Re: Review Request 111992: Activity bar in QML.

> On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 44 > > > > > > Here there is an old issue of TabBar that should be addressed one day > >

Re: Review Request 111992: Activity bar in QML.

> On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 37 > > > > > > whitespace s your friend > > > > for (i=0; ihttp://git.reviewboar

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37558 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 12, 2013, 3:14 a.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41 > > > > > > If you want to optimise, you can make TabBar the root item. > >

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37549 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 11, 2013, 11:39 a.m.) Review request for kde-workspace and M

Re: Review Request 111992: Activity bar in QML.

Hi Bhushan, [The right list for this discussion is plasma-de...@kde.org, I'm CC:ing this list, let's move the discussion there.] On Saturday, August 10, 2013 17:18:55 Bhushan Shah wrote: > Yes! I am showing all activities because if someone wants to switch to > activity which is not running then

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 11, 2013, 2:48 a.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 10, 2013, 5:28 p.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

> On Aug. 10, 2013, 5:04 p.m., David Edmundson wrote: > > Good start. > > > > You shouldn't delete the Messages.sh file. > > Copy from something that already uses QML, such as the battery applet. > > > > There's also a change from the current behaviour. The current one only > > shows where sta

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37476 --- Good start. You shouldn't delete the Messages.sh file. Copy fr

Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- Review request for kde-workspace and Marco Martin. Description --- Ac