Re: Review Request 111480: Notifications are shown multiple times

2013-07-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review36320 --- This breaks Amarok's "Show OSD" shortcut where you could tell i

Re: Review Request 111480: Notifications are shown multiple times

2013-07-16 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/ --- (Updated July 16, 2013, 12:01 p.m.) Status -- This change has been ma

Re: Review Request 111480: Notifications are shown multiple times

2013-07-16 Thread Aaron J. Seigo
> On July 15, 2013, 10:49 a.m., Aaron J. Seigo wrote: > > i think that technically this is a bug in the applications triggering it, > > but i agree we should probably work around it. the performance of the patch > > is theoretically bad (linear time), but hopefully nobody is storing 1000s > >

Re: Review Request 111480: Notifications are shown multiple times

2013-07-16 Thread Cedric Bellegarde
> On July 15, 2013, 10:49 a.m., Aaron J. Seigo wrote: > > i think that technically this is a bug in the applications triggering it, > > but i agree we should probably work around it. the performance of the patch > > is theoretically bad (linear time), but hopefully nobody is storing 1000s > >

Re: Review Request 111480: Notifications are shown multiple times

2013-07-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review35959 --- Ship it! i think that technically this is a bug in the applica

Re: Review Request 111480: Notifications are shown multiple times

2013-07-15 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/ --- (Updated July 15, 2013, 9:18 a.m.) Review request for kde-workspace and Ma

Re: Review Request 111480: Notifications are shown multiple times

2013-07-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review35898 --- plasma/generic/applets/notifications/contents/ui/Notifications

Re: Review Request 111480: Notifications are shown multiple times

2013-07-12 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/ --- (Updated July 12, 2013, 7:08 a.m.) Review request for kde-workspace and Ma

Re: Review Request 111480: Notifications are shown multiple times

2013-07-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review35860 --- This has the side-effect that the "Copy finished" message when

Re: Review Request 111480: Notifications are shown multiple times

2013-07-11 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/ --- (Updated July 11, 2013, 1:54 p.m.) Review request for kde-workspace and Ma

Review Request 111480: Notifications are shown multiple times

2013-07-11 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/ --- Review request for kde-workspace. Description --- Do not replace noti