Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-29 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated Nov. 29, 2013, 2:54 p.m.) Status -- This change has been mar

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44806 --- This review has been submitted with commit 40ded3efd3fa093247d

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread David Stephen Hubner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44724 --- Hi, I maintain KInfoCenter :) Also agree on the shipping it, so

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44671 --- Ship it! Besides the i18n misssing, sure, ship it, i don't see

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread Nico Kruber
> On July 1, 2013, 3:27 p.m., Martin Gräßlin wrote: > > from my side it looks OK, though I won't give a ship-it. This is a decision > > to the kinfocenter developers whether they are fine with the ifdefs. we'd like to include it in the next release and since the last message in this review req

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoC

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35374 --- from my side it looks OK, though I won't give a ship-it. This i

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 1:14 p.m.) Review request for kde-workspace and kwi

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35347 --- Not that I could comment on whether it's useful or not on Windo

Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- Review request for kde-workspace and kwin. Description --- make kinfo