Re: Review Request 111341: Oxygenify KNetattach

2013-08-05 Thread Rohan Garg
> On July 9, 2013, 12:17 a.m., Pino Toscano wrote: > > The patch is wrong. > > > > It is correct for knetattach to have an own icon and to use it its own > > code. If you want an Oxygen version of this icon, then create one (named > > "knetattach") and add it to the Oxygen icon theme, which wi

Re: Review Request 111341: Oxygenify KNetattach

2013-08-05 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- (Updated Aug. 5, 2013, 3:37 p.m.) Status -- This change has been disc

Re: Review Request 111341: Oxygenify KNetattach

2013-07-08 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35762 --- The patch is wrong. It is correct for knetattach to have an ow

Re: Review Request 111341: Oxygenify KNetattach

2013-07-08 Thread Rohan Garg
> On July 2, 2013, 1:32 a.m., Thomas Lübking wrote: > > Looks like the proper source, but i guess the icon should be rather > > replaced so that any user of knetattach (eg. a local .desktop file) gets > > the updated variant. > > > > Please attach Nuno to the review as the icons are his domain

Re: Review Request 111341: Oxygenify KNetattach

2013-07-03 Thread Rohan Garg
> On July 2, 2013, 1:32 a.m., Thomas Lübking wrote: > > Looks like the proper source, but i guess the icon should be rather > > replaced so that any user of knetattach (eg. a local .desktop file) gets > > the updated variant. > > > > Please attach Nuno to the review as the icons are his domain

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35402 --- Looks like the proper source, but i guess the icon should be ra

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- (Updated July 1, 2013, 8:42 p.m.) Review request for KDE Runtime. Change

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35352 --- knetattach/knetattach.cpp

Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- Review request for KDE Runtime. Description --- Patch from Kubuntu pa