Re: Review Request 111072: Drop internal X11 cmake module

2013-07-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/#review36317 --- This review has been submitted with commit 1822b197d9cbfe94435

Re: Review Request 111072: Drop internal X11 cmake module

2013-07-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/ --- (Updated July 22, 2013, 6:44 p.m.) Status -- This change has been mar

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/#review34533 --- Ship it! Go ahead, but it's still on your own peril. - Alexan

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
> On June 17, 2013, 6:34 p.m., Alexander Neundorf wrote: > > No other changes at all necessary ? > > Andrea Scarpino wrote: > kdelibs does not use any of the variables listed in the ECM_SiC page Then it's probably ok. - Alexander -

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:34 p.m., Alexander Neundorf wrote: > > No other changes at all necessary ? kdelibs does not use any of the variables listed in the ECM_SiC page - Andrea --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/#review34519 --- No other changes at all necessary ? - Alexander Neundorf On

Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us